Skip to content

HBASE-24423 No need to get lock in canSplit because hasReferences wil… #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2020
Merged

HBASE-24423 No need to get lock in canSplit because hasReferences wil… #1767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2061,17 +2061,12 @@ int versionsToReturn(final int wantedVersions) {

@Override
public boolean canSplit() {
this.lock.readLock().lock();
try {
// Not split-able if we find a reference store file present in the store.
boolean result = !hasReferences();
if (!result) {
LOG.trace("Not splittable; has references: {}", this);
}
return result;
} finally {
this.lock.readLock().unlock();
// Not split-able if we find a reference store file present in the store.
boolean result = !hasReferences();
if (!result) {
LOG.trace("Not splittable; has references: {}", this);
}
return result;
}

/**
Expand Down