Skip to content

Conversation

@wchevreuil
Copy link
Contributor

…p method from ReplicationLoadSource, but there were still references to this method on ruby admin.rb

…p method from ReplicationLoadSource, but there were still references to this method on ruby admin.rb
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚 rubocop 0m 9s There were no new rubocop issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
2m 0s
Subsystem Report/Notes
Docker Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1754/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1754
Optional Tests dupname asflicense rubocop
uname Linux 55cf4a052e93 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a8724e8
Max. process+thread count 47 (vs. ulimit of 12500)
modules C: hbase-shell U: hbase-shell
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1754/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) rubocop=0.80.0
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 46s master passed
+1 💚 javadoc 0m 16s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 26s the patch passed
+1 💚 javadoc 0m 13s the patch passed
_ Other Tests _
+1 💚 unit 6m 58s hbase-shell in the patch passed.
16m 22s
Subsystem Report/Notes
Docker Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1754/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #1754
Optional Tests javac javadoc unit
uname Linux 423e4fa41149 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a8724e8
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1754/1/testReport/
Max. process+thread count 2229 (vs. ulimit of 12500)
modules C: hbase-shell U: hbase-shell
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1754/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 37s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 31s master passed
+1 💚 javadoc 0m 16s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 14s the patch passed
+1 💚 javadoc 0m 14s the patch passed
_ Other Tests _
+1 💚 unit 7m 9s hbase-shell in the patch passed.
18m 9s
Subsystem Report/Notes
Docker Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1754/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1754
Optional Tests javac javadoc unit
uname Linux 182bf78873e1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a8724e8
Default Java 2020-01-14
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1754/1/testReport/
Max. process+thread count 2271 (vs. ulimit of 12500)
modules C: hbase-shell U: hbase-shell
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1754/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@HorizonNet HorizonNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wchevreuil Good catch! Let‘s bring it in.

@wchevreuil wchevreuil merged commit 9d9f07b into apache:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants