HBASE-24170 Remove hadoop-2.0 profile #1495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
Needs the changes to nightly to remove tests on Hadoop 2. Is there another PR already? |
|
🎊 +1 overall
This message was automatically generated. |
Nope. I think at least we need to include the Pre-Commit change in this PR, maybe there are just using the same personality script. Let me take a look. |
|
(!) A patch to the testing environment has been detected. |
2 similar comments
|
(!) A patch to the testing environment has been detected. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
2 similar comments
|
(!) A patch to the testing environment has been detected. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
2 similar comments
|
(!) A patch to the testing environment has been detected. |
|
(!) A patch to the testing environment has been detected. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
The pre commit is good now. The failure of the original master branch is expected, as we changed the personality and pre commit job to make the patched version pass, which will break the original master. And for nightly, plan to do it in another issue and we need to create a new branch to test it. Thanks. |
busbey
reviewed
Apr 14, 2020
dev-support/hbase-personality.sh
Outdated
| if [[ "${QUICK_HADOOPCHECK}" == "true" ]]; then | ||
| hbase_hadoop2_versions="2.10.0" | ||
| else | ||
| hbase_hadoop2_versions="2.10.0" | ||
| fi | ||
| else | ||
| yetus_info "Setting Hadoop 2 versions to test based on master/feature branch rules." | ||
| # we do not support hadoop 2 for hbase 3.x any more |
There was a problem hiding this comment.
put this in the info message to make clear we're skipping Hadoop 2 because hbase 3+ won't use it.
| @@ -2632,393 +2595,11 @@ | |||
| </build> | |||
| </profile> | |||
| <!-- Dependency management profiles for submodules when building against specific hadoop branches.--> | |||
| <!-- Submodules that need hadoop dependencies should declare | |||
There was a problem hiding this comment.
we should keep this guideline for the hadoop-3.0 profile.
saintstack
approved these changes
Apr 14, 2020
|
(!) A patch to the testing environment has been detected. |
2 similar comments
|
(!) A patch to the testing environment has been detected. |
|
(!) A patch to the testing environment has been detected. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
thangTang
pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
Signed-off-by: stack <stack@apache.org>
thangTang
pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
Signed-off-by: stack <stack@apache.org>
thangTang
pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
Signed-off-by: stack <stack@apache.org>
thangTang
pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
Signed-off-by: stack <stack@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.