Skip to content

Conversation

@Apache9
Copy link
Contributor

@Apache9 Apache9 commented Apr 11, 2019

… dependencies

All are NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE, which is because we use the Function interface from guava and it is marked as Nullable.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 32 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 273 master passed
+1 compile 53 master passed
+1 checkstyle 71 master passed
+1 shadedjars 262 branch has no errors when building our shaded downstream artifacts.
-1 findbugs 178 hbase-server in master has 11 extant Findbugs warnings.
+1 javadoc 35 master passed
_ Patch Compile Tests _
+1 mvninstall 259 the patch passed
+1 compile 55 the patch passed
+1 javac 55 the patch passed
+1 checkstyle 70 hbase-server: The patch generated 0 new + 18 unchanged - 2 fixed = 18 total (was 20)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 276 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 531 Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1 findbugs 186 hbase-server generated 0 new + 0 unchanged - 11 fixed = 0 total (was 11)
-1 javadoc 31 hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
-1 unit 8354 hbase-server in the patch failed.
+1 asflicense 23 The patch does not generate ASF License warnings.
10762
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-139/1/artifact/out/Dockerfile
GITHUB PR #139
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 6636c758e725 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / fc6e3fc
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-139/1/artifact/out/branch-findbugs-hbase-server-warnings.html
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-139/1/artifact/out/diff-javadoc-javadoc-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-139/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-139/1/testReport/
Max. process+thread count 4444 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-139/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 if tests pass

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 21 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 265 master passed
+1 compile 53 master passed
+1 checkstyle 76 master passed
+1 shadedjars 274 branch has no errors when building our shaded downstream artifacts.
-1 findbugs 179 hbase-server in master has 11 extant Findbugs warnings.
+1 javadoc 36 master passed
_ Patch Compile Tests _
+1 mvninstall 259 the patch passed
+1 compile 55 the patch passed
+1 javac 55 the patch passed
+1 checkstyle 74 hbase-server: The patch generated 0 new + 18 unchanged - 2 fixed = 18 total (was 20)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 274 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 534 Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1 findbugs 181 hbase-server generated 0 new + 0 unchanged - 11 fixed = 0 total (was 11)
+1 javadoc 32 the patch passed
_ Other Tests _
+1 unit 8179 hbase-server in the patch passed.
+1 asflicense 24 The patch does not generate ASF License warnings.
10590
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-139/2/artifact/out/Dockerfile
GITHUB PR #139
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux f9167ffe67ed 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 2bae04f
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-139/2/artifact/out/branch-findbugs-hbase-server-warnings.html
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-139/2/testReport/
Max. process+thread count 4867 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-139/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants