Skip to content

HBASE-24066 Let HBase master UI act as a maven repo #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

HBASE-24066 Let HBase master UI act as a maven repo #1365

wants to merge 3 commits into from

Conversation

joshelser
Copy link
Member

Advertise the version of HBase over the web UI and have a well-known
location from which users can pull shaded client jars from.

Rooted against branch-2.2, but that's just what I was working against when hacking this together. Intention would be for master, and any 2.x branches which want it.

@joshelser
HBASE-24066 Let HBase Master UI act as maven repository
947065c 
Advertise the version of HBase over the web UI and have a well-known
location from which users can pull shaded client jars from.
@joshelser
Copy link
Member Author

https://github.com/joshelser/HBASE-24066-webui-maven-repo-exemplar is the example of how a user might use this feature.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 58s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.2 Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for branch
+1 💚 mvninstall 8m 6s branch-2.2 passed
+1 💚 compile 1m 22s branch-2.2 passed
+1 💚 checkstyle 0m 45s branch-2.2 passed
+1 💚 shadedjars 6m 25s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 51s branch-2.2 passed
+0 🆗 spotbugs 0m 53s Used deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗 findbugs 0m 49s branch/hbase-assembly no findbugs output file (findbugsXml.xml)
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 7m 30s the patch passed
+1 💚 compile 1m 15s the patch passed
+1 💚 javac 1m 15s the patch passed
+1 💚 checkstyle 0m 41s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 4s The patch has no ill-formed XML file.
+1 💚 shadedjars 6m 29s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 28m 28s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2.
+1 💚 javadoc 0m 30s the patch passed
+0 🆗 findbugs 0m 27s hbase-assembly has no data from findbugs
_ Other Tests _
+1 💚 unit 1m 1s hbase-http in the patch passed.
+1 💚 unit 0m 27s hbase-assembly in the patch passed.
+1 💚 asflicense 0m 22s The patch does not generate ASF License warnings.
77m 50s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/artifact/out/Dockerfile
GITHUB PR #1365
Optional Tests dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle
uname Linux 153a3de1b2da 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1365/out/precommit/personality/provided.sh
git revision branch-2.2 / 1777513
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/testReport/
Max. process+thread count 261 (vs. ulimit of 10000)
modules C: hbase-http hbase-assembly U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 37s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.2 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 5m 10s branch-2.2 passed
+1 💚 compile 0m 48s branch-2.2 passed
+1 💚 checkstyle 0m 26s branch-2.2 passed
+1 💚 shadedjars 4m 22s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 30s branch-2.2 passed
+0 🆗 spotbugs 0m 34s Used deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗 findbugs 0m 29s branch/hbase-assembly no findbugs output file (findbugsXml.xml)
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 4m 46s the patch passed
+1 💚 compile 0m 48s the patch passed
+1 💚 javac 0m 47s the patch passed
+1 💚 checkstyle 0m 25s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 shadedjars 4m 13s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 22m 24s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2.
+1 💚 javadoc 0m 32s the patch passed
+0 🆗 findbugs 0m 28s hbase-assembly has no data from findbugs
_ Other Tests _
+1 💚 unit 1m 3s hbase-http in the patch passed.
+1 💚 unit 0m 27s hbase-assembly in the patch passed.
+1 💚 asflicense 0m 24s The patch does not generate ASF License warnings.
55m 54s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/2/artifact/out/Dockerfile
GITHUB PR #1365
Optional Tests dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle
uname Linux eeddef3b1488 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1365/out/precommit/personality/provided.sh
git revision branch-2.2 / 1777513
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/2/testReport/
Max. process+thread count 283 (vs. ulimit of 10000)
modules C: hbase-http hbase-assembly U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 52s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.2 Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 5m 33s branch-2.2 passed
+1 💚 compile 0m 46s branch-2.2 passed
+1 💚 checkstyle 0m 24s branch-2.2 passed
+1 💚 shadedjars 4m 23s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 29s branch-2.2 passed
+0 🆗 spotbugs 0m 35s Used deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗 findbugs 0m 30s branch/hbase-assembly no findbugs output file (findbugsXml.xml)
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 5m 12s the patch passed
+1 💚 compile 0m 46s the patch passed
+1 💚 javac 0m 46s the patch passed
+1 💚 checkstyle 0m 23s the patch passed
+1 💚 whitespace 0m 1s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 shadedjars 4m 26s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 22m 4s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2.
+1 💚 javadoc 0m 27s the patch passed
+0 🆗 findbugs 0m 29s hbase-assembly has no data from findbugs
_ Other Tests _
+1 💚 unit 1m 0s hbase-http in the patch passed.
+1 💚 unit 0m 27s hbase-assembly in the patch passed.
+1 💚 asflicense 0m 20s The patch does not generate ASF License warnings.
59m 46s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/artifact/out/Dockerfile
GITHUB PR #1365
Optional Tests dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle
uname Linux c936eccfd310 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1365/out/precommit/personality/provided.sh
git revision branch-2.2 / 88c0883
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/testReport/
Max. process+thread count 253 (vs. ulimit of 10000)
modules C: hbase-http hbase-assembly U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

wchevreuil
wchevreuil reviewed May 5, 2020
View reviewed changes
Copy link
Contributor

@wchevreuil wchevreuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea looks great. Just a small nit on the maven-repo directory path definitions in the assembly components.xml, as the current value gives a broken link.

hbase-assembly/src/main/assembly/components.xml
@@ -168,5 +168,11 @@
</includes>
<fileMode>0644</fileMode>
</fileSet>
<fileSet>
<directory>${project.build.directory}/maven-repo</directory>
<outputDirectory>hbase-webapps/maven-repo</outputDirectory>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be <outputDirectory>hbase-webapps/static/maven-repo</outputDirectory> instead.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 5m 11s branch-2.2 passed
+1 💚 compile 0m 47s branch-2.2 passed
+1 💚 checkstyle 0m 26s branch-2.2 passed
+1 💚 shadedjars 4m 3s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 30s branch-2.2 passed
+0 🆗 spotbugs 0m 37s Used deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗 findbugs 0m 31s branch/hbase-assembly no findbugs output file (findbugsXml.xml)
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 58s the patch passed
+1 💚 compile 0m 46s the patch passed
+1 💚 javac 0m 46s the patch passed
+1 💚 checkstyle 0m 26s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 shadedjars 4m 4s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 29m 14s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚 javadoc 0m 33s the patch passed
+0 🆗 findbugs 0m 35s hbase-assembly has no data from findbugs
_ Other Tests _
+1 💚 unit 1m 19s hbase-http in the patch passed.
+1 💚 unit 0m 35s hbase-assembly in the patch passed.
+1 💚 asflicense 0m 21s The patch does not generate ASF License warnings.
64m 39s
Subsystem Report/Notes
Docker Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/artifact/out/Dockerfile
GITHUB PR #1365
Optional Tests dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle
uname Linux a990d95a0991 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1365/out/precommit/personality/provided.sh
git revision branch-2.2 / 9ee786e
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/testReport/
Max. process+thread count 295 (vs. ulimit of 10000)
modules C: hbase-http hbase-assembly U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@joshelser
Copy link
Member Author

Not seeing a path forward. Closing until we think this is worth doing.

@joshelser joshelser closed this May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wchevreuil wchevreuil wchevreuil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshelser @Apache-HBase @wchevreuil