Skip to content

HBASE-22193 Add backoff when region failed open too many times #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2019
Merged

HBASE-22193 Add backoff when region failed open too many times #133

merged 1 commit into from
Apr 13, 2019

Conversation

infraio
Copy link
Contributor

@infraio infraio commented Apr 9, 2019

No description provided.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 43 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 254 master passed
+1 compile 52 master passed
+1 checkstyle 65 master passed
+1 shadedjars 257 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 159 master passed
+1 javadoc 33 master passed
_ Patch Compile Tests _
+1 mvninstall 259 the patch passed
+1 compile 53 the patch passed
+1 javac 53 the patch passed
+1 checkstyle 65 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 264 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 514 Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1 findbugs 169 the patch passed
+1 javadoc 32 the patch passed
_ Other Tests _
-1 unit 17615 hbase-server in the patch failed.
+1 asflicense 30 The patch does not generate ASF License warnings.
19936
Reason Tests
Failed junit tests hadoop.hbase.master.procedure.TestSCPWithReplicas
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
hadoop.hbase.master.TestSplitWALManager
hadoop.hbase.client.TestFromClientSideWithCoprocessor
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL
hadoop.hbase.client.TestFromClientSide
hadoop.hbase.quotas.TestSpaceQuotas
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL
hadoop.hbase.util.TestFromClientSide3WoUnsafe
hadoop.hbase.client.TestConnectionImplementation
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.client.TestFromClientSide3
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
hadoop.hbase.client.TestAdmin1
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/1/artifact/out/Dockerfile
GITHUB PR #133
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux e7b96488013a 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 74112e5
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/1/testReport/
Max. process+thread count 5247 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 251 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 264 master passed
+1 compile 52 master passed
+1 checkstyle 67 master passed
+1 shadedjars 256 branch has no errors when building our shaded downstream artifacts.
-1 findbugs 155 hbase-server in master has 11 extant Findbugs warnings.
+1 javadoc 32 master passed
_ Patch Compile Tests _
+1 mvninstall 236 the patch passed
+1 compile 51 the patch passed
+1 javac 52 the patch passed
+1 checkstyle 67 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 263 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 521 Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1 findbugs 193 the patch passed
+1 javadoc 32 the patch passed
_ Other Tests _
-1 unit 16154 hbase-server in the patch failed.
+1 asflicense 32 The patch does not generate ASF License warnings.
18697
Reason Tests
Failed junit tests hadoop.hbase.master.TestAssignmentManagerMetrics
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
hadoop.hbase.master.TestSplitWALManager
hadoop.hbase.client.TestSplitOrMergeStatus
hadoop.hbase.quotas.TestSpaceQuotas
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.client.TestFromClientSide3
hadoop.hbase.client.TestAdmin1
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/2/artifact/out/Dockerfile
GITHUB PR #133
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 5b804743a53e 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 494a8ef
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/2/artifact/out/branch-findbugs-hbase-server-warnings.html
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/2/testReport/
Max. process+thread count 5057 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@infraio infraio requested a review from Apache9 April 11, 2019 14:24
@infraio infraio requested a review from Apache9 April 12, 2019 07:50
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 47 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 295 master passed
+1 compile 63 master passed
+1 checkstyle 68 master passed
+1 shadedjars 264 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 194 master passed
+1 javadoc 30 master passed
_ Patch Compile Tests _
+1 mvninstall 241 the patch passed
+1 compile 51 the patch passed
+1 javac 51 the patch passed
+1 checkstyle 64 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 250 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 517 Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1 findbugs 184 the patch passed
+1 javadoc 33 the patch passed
_ Other Tests _
-1 unit 17484 hbase-server in the patch failed.
+1 asflicense 30 The patch does not generate ASF License warnings.
19888
Reason Tests
Failed junit tests hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
hadoop.hbase.master.TestSplitWALManager
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL
hadoop.hbase.quotas.TestSpaceQuotas
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.client.TestFromClientSide3
hadoop.hbase.client.TestAdmin1
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/3/artifact/out/Dockerfile
GITHUB PR #133
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux c4532375a2e8 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / f227eb7
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/3/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/3/testReport/
Max. process+thread count 5044 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/3/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@infraio infraio merged commit 249ac58 into apache:master Apr 13, 2019
@infraio infraio deleted the retry-backoff branch April 13, 2019 02:41
asfgit pushed a commit that referenced this pull request Apr 13, 2019
@infraio
Revert "Merge pull request #133 from infraio/retry-backoff
e4e561b 
        HBASE-22193 Add backoff when region failed open too many times"

This reverts commit 249ac58, reversing
changes made to f7867c4.
@wchevreuil wchevreuil mentioned this pull request Oct 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apache9 Apache9 Apache9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@infraio @Apache-HBase @Apache9