HBASE-23970 TestUsersOperationsWithSecureHadoop fails when an existing ticket is present #1293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
ndimiduk
reviewed
Mar 17, 2020
Member
ndimiduk
left a comment
ndimiduk
left a comment
There was a problem hiding this comment.
One question -- is it okay that we delete existing tickets? Shouldn't the test work by isolating itself to the realm of the test, ignoring other tickets that might be present?
| public static void destroyAndSetup() throws Exception { | ||
| //destroy localhost kerberos users | ||
| Process process = Runtime.getRuntime().exec(new String[]{"bash", "-c", "kdestroy"}); | ||
| process.waitFor(2, TimeUnit.SECONDS); |
Member
There was a problem hiding this comment.
This previous waitFor call doesn't check the return value. It's possible the call failed but the test didn't notice.
Contributor
There was a problem hiding this comment.
So, the previous exec w/ its kdestroy is better than klist with a 'notice' IMO. What tends to happen is you run test suite and then one hour in, it will fail with complaint about unmatched user for old ticket. WIth kdestroy, that doesn't happen. Means old ticket gets killed which should be fine most of the time -- you just re-kinit (unless you running test suite on some critical system).
Nick's idea of narrowing test so it only concerned about test ticket would be best. Not sure how to do that though myself.
| public static void checkAndSetup() throws Exception { | ||
| // check localhost kerberos users | ||
| Process process = Runtime.getRuntime().exec(new String[]{"bash", "-c", "klist"}); | ||
| boolean wait = process.waitFor(2, TimeUnit.SECONDS); |
Member
There was a problem hiding this comment.
I think a simple assertTrue is sufficient for this case.
Contributor
|
@ndimiduk noticed that some of this patch got accidentally committed as part of https://github.com/apache/hbase/pull/1278/files Let me revert that piece. I had this issue myself today. Its a pain. Lets get a fix in. I like Nick's idea of confining deletion to test realm but not sure its possible; would be cool if it was. |
Contributor
|
I removed the overcommit to TestUsersOperationsWithSecureHadoop with the below push on master commit 9804f73 (HEAD -> m, origin/master, origin/HEAD) |
|
💔 -1 overall
This message was automatically generated. |
1 similar comment
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
ndimiduk
reviewed
May 27, 2020
| boolean wait = process.waitFor(2, TimeUnit.SECONDS); | ||
| assertTrue("localhost exec klist timeout!", wait); | ||
| int ret = process.exitValue(); | ||
| assertTrue("localhost have an existing ticket!",ret != 0); |
Member
There was a problem hiding this comment.
about about assertNotEquals instead?
Contributor
Author
There was a problem hiding this comment.
yes, thanks. I commit on a new branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.