-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-23968 Periodically check whether a system stop is requested in compaction by time. #1274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 changes: 80 additions & 0 deletions
80
...e-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CloseChecker.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.hadoop.hbase.regionserver.compactions; | ||
|
|
||
| import org.apache.hadoop.conf.Configuration; | ||
| import org.apache.hadoop.hbase.regionserver.Store; | ||
| import org.apache.yetus.audience.InterfaceAudience; | ||
|
|
||
| /** | ||
| * Check periodically to see if a system stop is requested | ||
| */ | ||
| @InterfaceAudience.Private | ||
| public class CloseChecker { | ||
| public static final String SIZE_LIMIT_KEY = "hbase.hstore.close.check.interval"; | ||
| public static final String TIME_LIMIT_KEY = "hbase.hstore.close.check.time.interval"; | ||
|
|
||
| private final int closeCheckSizeLimit; | ||
| private final long closeCheckTimeLimit; | ||
|
|
||
| private long bytesWrittenProgressForCloseCheck; | ||
| private long lastCloseCheckMillis; | ||
|
|
||
| public CloseChecker(Configuration conf, long currentTime) { | ||
saintstack marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| this.closeCheckSizeLimit = conf.getInt(SIZE_LIMIT_KEY, 10 * 1000 * 1000 /* 10 MB */); | ||
| this.closeCheckTimeLimit = conf.getLong(TIME_LIMIT_KEY, 10 * 1000L /* 10 s */); | ||
| this.bytesWrittenProgressForCloseCheck = 0; | ||
| this.lastCloseCheckMillis = currentTime; | ||
| } | ||
|
|
||
| /** | ||
| * Check periodically to see if a system stop is requested every written bytes reach size limit. | ||
| * | ||
| * @return if true, system stop. | ||
| */ | ||
| public boolean isSizeLimit(Store store, long bytesWritten) { | ||
| if (closeCheckSizeLimit <= 0) { | ||
| return false; | ||
| } | ||
|
|
||
| bytesWrittenProgressForCloseCheck += bytesWritten; | ||
| if (bytesWrittenProgressForCloseCheck <= closeCheckSizeLimit) { | ||
| return false; | ||
| } | ||
|
|
||
| bytesWrittenProgressForCloseCheck = 0; | ||
| return !store.areWritesEnabled(); | ||
| } | ||
|
|
||
| /** | ||
| * Check periodically to see if a system stop is requested every time. | ||
| * | ||
| * @return if true, system stop. | ||
| */ | ||
| public boolean isTimeLimit(Store store, long now) { | ||
| if (closeCheckTimeLimit <= 0) { | ||
| return false; | ||
| } | ||
|
|
||
| final long elapsedMillis = now - lastCloseCheckMillis; | ||
| if (elapsedMillis <= closeCheckTimeLimit) { | ||
| return false; | ||
| } | ||
|
|
||
| lastCloseCheckMillis = now; | ||
saintstack marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return !store.areWritesEnabled(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it have to be public? Can it be package local? It is only used in this package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to use
package local.However, The package of
FaultyMobStoreCompactoris not the same asCloseChecker.The package of
FaultyMobStoreCompactorisorg.apache.hadoop.hbase.mob.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dang.
ok. public for now.