Skip to content

HBASE-23694 After RegionProcedureStore completes migration of WALProcedureStore, … #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2020
Merged

HBASE-23694 After RegionProcedureStore completes migration of WALProcedureStore, … #1048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...r/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,7 @@ public void handleCorrupted(ProcedureIterator procIter) throws IOException {
throw new IOException("Failed to delete the WALProcedureStore migrated proc wal directory " +
procWALDir);
}
store.stop(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why an abort and not non-abort here? Should this be in finally block? I closed my dupe of this over in HBASE-23696

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not need to be in finally block. If there are errors we just fail the start up of HMaster. If we pass abort = false then it will try to append a trailer which will cause teh stop to hang there.

Of course, a better way maybe call store.stop(false) before we delete the proc wal directory, but not a big deal?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Good enough for now. Thanks.

LOG.info("Migration of WALProcedureStore finished");
}

Expand Down Expand Up @@ -581,4 +582,4 @@ public void cleanup() {
LOG.warn("Failed to clean up delete procedures", e);
}
}
}
}