-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-23662 : Replace HColumnDescriptor(String cf) with ColumnFamilyD… #1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
0d55369
to
a770ff0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup @virajjasani!
hbase-server/src/test/java/org/apache/hadoop/hbase/mob/compactions/TestMobCompactor.java
Outdated
Show resolved
Hide resolved
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEncryptionKeyRotation.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
@petersomogyi a couple of test failures in above build seems irrelevant, they all are passing locally. |
Incorporated review comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, pending QA
Let's wait for QA result. The above is for the second run and not the latest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice cleanup. TestExportSnapshotNoCluster
seems to fail consistently, but not related to the changes made here.
Sure let pending QA complete. |
💔 -1 overall
This message was automatically generated. |
Thanks for the review @petersomogyi @HorizonNet |
…escriptor