Skip to content

Commit 2cc605a

Browse files
committed
HBASE-28731 Remove the IA.Private annotation on WALEdit's add methods as they have already been used by CP users (#6085)
Signed-off-by: Istvan Toth <stoty@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org> (cherry picked from commit a333dd9) (cherry picked from commit b85f243)
1 parent f9516fd commit 2cc605a

File tree

1 file changed

+0
-8
lines changed
  • hbase-server/src/main/java/org/apache/hadoop/hbase/wal

1 file changed

+0
-8
lines changed

hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALEdit.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,6 @@
4646
* that came in as a single transaction. All the edits for a given transaction are written out as a
4747
* single record, in PB format, followed (optionally) by Cells written via the WALCellEncoder.
4848
* <p>
49-
* This class is LimitedPrivate for CPs to read-only. The {@link #add} methods are classified as
50-
* private methods, not for use by CPs.
51-
* </p>
52-
* <p>
5349
* A particular WALEdit 'type' is the 'meta' type used to mark key operational events in the WAL
5450
* such as compaction, flush, or region open. These meta types do not traverse hbase memstores. They
5551
* are edits made by the hbase system rather than edit data submitted by clients. They only show in
@@ -73,7 +69,6 @@
7369
* file. See the hand-off in FSWALEntry Constructor.
7470
* @see WALKey
7571
*/
76-
// TODO: Do not expose this class to Coprocessors. It has set methods. A CP might meddle.
7772
@InterfaceAudience.LimitedPrivate({ HBaseInterfaceAudience.REPLICATION,
7873
HBaseInterfaceAudience.COPROC })
7974
public class WALEdit implements HeapSize {
@@ -240,13 +235,11 @@ public boolean isReplay() {
240235
return this.replay;
241236
}
242237

243-
@InterfaceAudience.Private
244238
public WALEdit add(Cell cell, byte[] family) {
245239
getOrCreateFamilies().add(family);
246240
return addCell(cell);
247241
}
248242

249-
@InterfaceAudience.Private
250243
public WALEdit add(Cell cell) {
251244
// We clone Family each time we add a Cell. Expensive but safe. For CPU savings, use
252245
// add(Map) or add(Cell, family).
@@ -270,7 +263,6 @@ public ArrayList<Cell> getCells() {
270263
* that nothing else depends on the contents being immutable.
271264
* @param cells the list of cells that this WALEdit now contains.
272265
*/
273-
@InterfaceAudience.Private
274266
// Used by replay.
275267
public void setCells(ArrayList<Cell> cells) {
276268
this.cells = cells;

0 commit comments

Comments
 (0)