Skip to content

Commit a333dd9

Browse files
committed
HBASE-28731 Remove the IA.Private annotation on WALEdit's add methods as they have already been used by CP users
1 parent 2b673bd commit a333dd9

File tree

1 file changed

+0
-9
lines changed
  • hbase-server/src/main/java/org/apache/hadoop/hbase/wal

1 file changed

+0
-9
lines changed

hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALEdit.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,6 @@
4646
* that came in as a single transaction. All the edits for a given transaction are written out as a
4747
* single record, in PB format, followed (optionally) by Cells written via the WALCellEncoder.
4848
* <p>
49-
* This class is LimitedPrivate for CPs to read-only. The {@link #add} methods are classified as
50-
* private methods, not for use by CPs.
51-
* </p>
52-
* <p>
5349
* A particular WALEdit 'type' is the 'meta' type used to mark key operational events in the WAL
5450
* such as compaction, flush, or region open. These meta types do not traverse hbase memstores. They
5551
* are edits made by the hbase system rather than edit data submitted by clients. They only show in
@@ -73,7 +69,6 @@
7369
* file. See the hand-off in FSWALEntry Constructor.
7470
* @see WALKey
7571
*/
76-
// TODO: Do not expose this class to Coprocessors. It has set methods. A CP might meddle.
7772
@InterfaceAudience.LimitedPrivate({ HBaseInterfaceAudience.REPLICATION,
7873
HBaseInterfaceAudience.COPROC })
7974
public class WALEdit implements HeapSize {
@@ -253,20 +248,17 @@ public boolean isReplay() {
253248
return this.replay;
254249
}
255250

256-
@InterfaceAudience.Private
257251
public WALEdit add(Cell cell, byte[] family) {
258252
getOrCreateFamilies().add(family);
259253
return addCell(cell);
260254
}
261255

262-
@InterfaceAudience.Private
263256
public WALEdit add(Cell cell) {
264257
// We clone Family each time we add a Cell. Expensive but safe. For CPU savings, use
265258
// add(Map) or add(Cell, family).
266259
return add(cell, CellUtil.cloneFamily(cell));
267260
}
268261

269-
@InterfaceAudience.Private
270262
public WALEdit add(List<? extends Cell> cells) {
271263
if (cells == null || cells.isEmpty()) {
272264
return this;
@@ -294,7 +286,6 @@ public ArrayList<Cell> getCells() {
294286
* that nothing else depends on the contents being immutable.
295287
* @param cells the list of cells that this WALEdit now contains.
296288
*/
297-
@InterfaceAudience.Private
298289
// Used by replay.
299290
public void setCells(ArrayList<Cell> cells) {
300291
this.cells = cells;

0 commit comments

Comments
 (0)