Skip to content

Pin ddtrace until deprecated module can be evaluated #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skrawcz merged 3 commits into from
Mar 3, 2025
Merged

Pin ddtrace until deprecated module can be evaluated #1288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d04151d
Pin `ddtrace<3.0` until issue with modules can be evaluated
cswartzvi Mar 2, 2025
0659f47
Pin `ddtrace<3.0` for docs
cswartzvi Mar 2, 2025
0095e48
Add comments about pin/deprecation
cswartzvi Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions hamilton/plugins/h_ddog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

logger = logging.getLogger(__name__)
try:
# TODO: this works for ddtrace < 3.0; Span was deprecated in 3.0
# See https://github.com/DataDog/dd-trace-py/pull/12186
from ddtrace import Span, context, tracer
except ImportError as e:
logger.error("ImportError: %s", e)
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ dask-core = ["dask-core"]
dask-dataframe = ["dask[dataframe]"]
dask-diagnostics = ["dask[diagnostics]"]
dask-distributed = ["dask[distributed]"]
datadog = ["ddtrace"]
datadog = ["ddtrace<3.0"] # Temporary pin until h_ddog.py import is fixed for >3.0 version
dev = [
"pre-commit",
"ruff==0.5.7", # this should match `.pre-commit-config.yaml`
Expand All @@ -53,7 +53,7 @@ docs = [
"commonmark==0.9.1", # read the docs pins
"dask-expr; python_version == '3.9'",
"dask[distributed]",
"ddtrace",
"ddtrace<3.0",
"diskcache",
# required for all the plugins
"dlt",
Expand Down