Enables Hamilton to install under WASM #1277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 4bc1bd2 in 1 minute and 47 seconds
More details
- Looked at
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. hamilton/execution/executors.py:7
- Draft comment:
Consider adding an inline comment explaining why ProcessPoolExecutor is set to None for WASM. This improves clarity for future maintainers. - Reason this comment was not posted:
Marked as duplicate.
2. hamilton/execution/executors.py:10
- Draft comment:
ProcessPoolExecutor is set to None in WASM, but MultiProcessingExecutor later uses it directly. Consider adding a safeguard in MultiProcessingExecutor (or a clear error message) to handle the case where ProcessPoolExecutor is None. - Reason this comment was not posted:
Marked as duplicate.
3. hamilton/execution/executors.py:7
- Draft comment:
Add a comment here explaining that on WASM environments (emscripten, wasi) the ProcessPoolExecutor is disabled due to lack of support. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_cNwJ4ePYMA77ad2i
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Seeing if this enables try hamilton to run the latest hamilton code.
this seems to work, but then it doesnt...
We don't want to import this in a WASM env. So we gate it now.
We don't want this in general Hamilton.
skrawcz
force-pushed
the
try-hamilton
branch
from
4bc1bd2 to
1b27a33
Compare
Closed
elijahbenizzy
approved these changes
Feb 11, 2025
Contributor
elijahbenizzy
left a comment
elijahbenizzy
left a comment
There was a problem hiding this comment.
Could have tests but I'm not worried for this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables Hamilton to be installed in a WASM environment.
This just special cases the environment and doesn't import process pool executor
which isn't available in a WASM env.
Changes
How I tested this
Notes
Checklist