-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-14541. When evictableMmapped or evictable size is zero, do not throw NoSuchElementException #977
Conversation
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
} | ||
} catch (NoSuchElementException e) { | ||
break; | ||
if (evictable.size() == 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use isEmpty() here for clarity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@goiri Thanks for your comments . I have updated this patch. Could you have time to help review this patch? Thank you.
…lementException Signed-off-by: sunlisheng <sunlisheng@xiaomi.com>
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
LGTM |
💔 -1 overall
This message was automatically generated. |
@goiri , I think we need to cherry-pick this feature to all branches, such as branch-2.9 etc. Thanks. |
Does github allow cherry-picking? git cherry-pick -x requires -m which is not clear to me. |
I saw you have done the cherry-pick, Thanks @goiri for your work :-) |
For full disclosure, I messed up the merge of the PR and I had to do the cherry-pick by hand through the patch. |
* Update the release variable in config.yml to generate javadocs. * Update the index.md to contain the 1.1-src location.
…lementException
Signed-off-by: sunlisheng sunlisheng@xiaomi.com