HDDS-1611. Evaluate ACL on volume bucket key and prefix to authorize access. Contributed by Ajay Kumar. #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Draft patch for initial feedback, will ad robot test and more unit tests soon. |
|
💔 -1 overall
This message was automatically generated. |
xiaoyuyao
reviewed
Jun 17, 2019
Contributor
There was a problem hiding this comment.
Can we move context.getClientUgi().getUserName() out of the for loop?
xiaoyuyao
reviewed
Jun 17, 2019
Contributor
There was a problem hiding this comment.
Discussed offline, we need to handle different identity types.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
anuengineer
reviewed
Jun 28, 2019
Contributor
There was a problem hiding this comment.
Perhaps write more detailed comment here ?
anuengineer
reviewed
Jun 29, 2019
Contributor
There was a problem hiding this comment.
We should perhaps add a not less than zero check also , so we can throw exception correctly.
anuengineer
reviewed
Jun 29, 2019
Contributor
There was a problem hiding this comment.
This is a good catch. I think we should move to more explicit error, where if the users tries to set world and a user name, we should throw an error, that way user is not making a mistake, which we are silently ignoring.
anuengineer
reviewed
Jun 29, 2019
Contributor
There was a problem hiding this comment.
we need to make sure that Audit system knows about these ACL check failures.
Contributor
Author
There was a problem hiding this comment.
Created HDDS-1768 to track it.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
ajayydv
force-pushed
the
HDDS-1611
branch
2 times, most recently
from
4ba675f to
881c4da
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
…access. Contributed by Ajay Kumar.
Contributor
Author
|
seems like some error in reporting, acceptance tests passed. |
Contributor
Author
|
/retest |
Contributor
Author
|
failed junit tests look unrelated, TestWatchForCommit & TestFailureHandlingByClient fail for trunk as well. |
anuengineer
approved these changes
Jul 10, 2019
asfgit
pushed a commit
that referenced
this pull request
Jul 10, 2019
…authorize access. Contributed by Ajay Kumar. (#973) Fixes a build break in ozone.
shanthoosh
added a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
…access. Contributed by Ajay Kumar. (apache#973)
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
…authorize access. Contributed by Ajay Kumar. (apache#973) Fixes a build break in ozone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.