HDFS-14478: Add libhdfs APIs for openFile #955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
I dont see any tests for trying to open a file which doesnt exist. When you do that. the failure is postponed until the completion is evaluated, so you need to add a test there to make sure the failure is escalated properly |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
….scala and SystemConfig.scala to Java (apache#955) * moving FileSystemCheckpointManagerConfig.scala and SystemConfig.scala to java * renaming JavaSystemConfig to SystemConfig now that the scala version is gone
This comment has been minimized.
This comment has been minimized.
Contributor
|
Thanks @Sahil for the patch. Would you rebase the commit on the latest trunk? so we can get a test run against trunk. |
Contributor
|
I should warn that in #2046 I'm adding opt/must to take a long as well; we just missed that out in the past. Needed so that applications like yours can pass in the known length of the file (split limit is fine) and we can skip the HEAD from that alone. hive needs that |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HDFS-14478: Add libhdfs APIs for openFile
Exposes the openFile API via libhdfs, adds new tests to
test_libhdfs_ops.c. For the most part, the libhdfs API mirrors the Java API (e.g. the async open file is modeled in a similar fashion tojava.util.concurrent.Future).