HDDS-1666. Issue in openKey when allocating block. #943

bharatviswa504 · 2019-06-11T04:23:20Z

We set size as below

final long size = args.getDataSize() >= 0 ?
args.getDataSize() : scmBlockSize;

and create OmKeyInfo with below size set. But when allocating Block for openKey, we use as below.

allocateBlockInKey(keyInfo, args.getDataSize(), currentTime);

I feel here, we should use size which is set above so that we allocate at least a block when the openKey call happens.

Current Code also works fine, but for readability I believe this should be good.

hadoop-yetus · 2019-06-11T05:55:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	33	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	551	trunk passed
+1	compile	299	trunk passed
+1	checkstyle	89	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	896	branch has no errors when building and testing our client artifacts.
+1	javadoc	181	trunk passed
0	spotbugs	330	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	521	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	483	the patch passed
+1	compile	296	the patch passed
+1	javac	296	the patch passed
+1	checkstyle	96	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	688	patch has no errors when building and testing our client artifacts.
+1	javadoc	180	the patch passed
+1	findbugs	541	the patch passed
		_ Other Tests _
-1	unit	158	hadoop-hdds in the patch failed.
-1	unit	146	hadoop-ozone in the patch failed.
+1	asflicense	54	The patch does not generate ASF License warnings.
		5416

Reason	Tests
Failed junit tests	hadoop.ozone.container.common.impl.TestHddsDispatcher
	hadoop.ozone.om.TestKeyManagerImpl

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-943/1/artifact/out/Dockerfile
GITHUB PR	#943
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux cc90a0e083ee 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `101d5b5`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-943/1/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-943/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-943/1/testReport/
Max. process+thread count	1304 (vs. ulimit of 5500)
modules	C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-943/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

arp7

+1

hadoop-yetus · 2019-06-24T23:49:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	30	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	471	trunk passed
+1	compile	241	trunk passed
+1	checkstyle	61	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	787	branch has no errors when building and testing our client artifacts.
+1	javadoc	149	trunk passed
0	spotbugs	345	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	558	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	464	the patch passed
+1	compile	256	the patch passed
+1	javac	256	the patch passed
+1	checkstyle	65	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	658	patch has no errors when building and testing our client artifacts.
+1	javadoc	159	the patch passed
+1	findbugs	586	the patch passed
		_ Other Tests _
+1	unit	248	hadoop-hdds in the patch passed.
-1	unit	1689	hadoop-ozone in the patch failed.
+1	asflicense	36	The patch does not generate ASF License warnings.
		6585

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.web.client.TestKeys
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.om.TestKeyManagerImpl

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-943/2/artifact/out/Dockerfile
GITHUB PR	#943
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux cd17417896f4 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `129576f`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-943/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-943/2/testReport/
Max. process+thread count	4169 (vs. ulimit of 5500)
modules	C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-943/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-07-15T22:02:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	86	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	45	Maven dependency ordering for branch
+1	mvninstall	642	trunk passed
+1	compile	361	trunk passed
+1	checkstyle	105	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	1186	branch has no errors when building and testing our client artifacts.
+1	javadoc	215	trunk passed
0	spotbugs	411	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	687	trunk passed
		_ Patch Compile Tests _
0	mvndep	30	Maven dependency ordering for patch
+1	mvninstall	587	the patch passed
+1	compile	333	the patch passed
+1	javac	333	the patch passed
+1	checkstyle	93	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	887	patch has no errors when building and testing our client artifacts.
+1	javadoc	211	the patch passed
+1	findbugs	673	the patch passed
		_ Other Tests _
+1	unit	391	hadoop-hdds in the patch passed.
-1	unit	3138	hadoop-ozone in the patch failed.
+1	asflicense	54	The patch does not generate ASF License warnings.
		9915

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
	hadoop.ozone.client.rpc.TestContainerStateMachine
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-943/3/artifact/out/Dockerfile
GITHUB PR	#943
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 0d327d652801 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `64d4abf`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-943/3/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-943/3/testReport/
Max. process+thread count	4108 (vs. ulimit of 5500)
modules	C: hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-943/3/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

arp7

+1 LGTM

bharatviswa504 self-assigned this Jun 11, 2019

bharatviswa504 added the ozone label Jun 11, 2019

arp7 approved these changes Jun 24, 2019

View reviewed changes

bharatviswa504 force-pushed the HDDS-1666 branch from 0450e44 to 489d0bf Compare June 24, 2019 21:59

bharatviswa504 added 2 commits July 15, 2019 09:37

HDDS-1666. Issue in openKey when allocating block.

32a2234

fix test

38ce537

bharatviswa504 force-pushed the HDDS-1666 branch from 489d0bf to 38ce537 Compare July 15, 2019 17:05

arp7 approved these changes Jul 16, 2019

View reviewed changes

arp7 merged commit ef66e49 into apache:trunk Jul 16, 2019

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019

HDDS-1666. Issue in openKey when allocating block. (apache#943)

36219f1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDDS-1666. Issue in openKey when allocating block. #943

HDDS-1666. Issue in openKey when allocating block. #943

Uh oh!

bharatviswa504 commented Jun 11, 2019

Uh oh!

hadoop-yetus commented Jun 11, 2019

Uh oh!

arp7 left a comment

Uh oh!

hadoop-yetus commented Jun 24, 2019

Uh oh!

hadoop-yetus commented Jul 15, 2019

Uh oh!

arp7 left a comment

Uh oh!

Uh oh!

HDDS-1666. Issue in openKey when allocating block. #943

HDDS-1666. Issue in openKey when allocating block. #943

Uh oh!

Conversation

bharatviswa504 commented Jun 11, 2019

Uh oh!

hadoop-yetus commented Jun 11, 2019

Uh oh!

arp7 left a comment

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Jun 24, 2019

Uh oh!

hadoop-yetus commented Jul 15, 2019

Uh oh!

arp7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!