Skip to content

HDDS-1655. Redundant toString() call for metaDataPath in KeyValueContainerCheck #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2019

Conversation

shwetayakkali
Copy link

Change-Id: Idf91e6367cf1a6e27986034e13cf34f59e79fc25

Redundant toString() call for variable metadataPath at:

https://github.com/apache/hadoop/blob/trunk/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainerCheck.java#L284

…ainerCheck

Change-Id: Idf91e6367cf1a6e27986034e13cf34f59e79fc25
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 844 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 499 trunk passed
+1 compile 289 trunk passed
+1 checkstyle 89 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 909 branch has no errors when building and testing our client artifacts.
+1 javadoc 168 trunk passed
0 spotbugs 321 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 506 trunk passed
_ Patch Compile Tests _
+1 mvninstall 446 the patch passed
+1 compile 303 the patch passed
+1 javac 303 the patch passed
+1 checkstyle 93 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 753 patch has no errors when building and testing our client artifacts.
+1 javadoc 178 the patch passed
+1 findbugs 546 the patch passed
_ Other Tests _
-1 unit 167 hadoop-hdds in the patch failed.
-1 unit 1201 hadoop-ozone in the patch failed.
+1 asflicense 49 The patch does not generate ASF License warnings.
7211
Reason Tests
Failed junit tests hadoop.ozone.container.common.impl.TestHddsDispatcher
hadoop.ozone.client.rpc.TestBCSID
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.TestMiniOzoneCluster
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
Subsystem Report/Notes
Docker Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-932/1/artifact/out/Dockerfile
GITHUB PR #932
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux a21c5772d636 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 9deac3b
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-932/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-932/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-932/1/testReport/
Max. process+thread count 3703 (vs. ulimit of 5500)
modules C: hadoop-hdds/container-service U: hadoop-hdds/container-service
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-932/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@bharatviswa504 bharatviswa504 merged commit fcfe7a3 into apache:trunk Jun 9, 2019
@bharatviswa504
Copy link
Contributor

Thank you @shwetayakkali for the contribution.
I have committed this to trunk.

bshashikant pushed a commit to bshashikant/hadoop that referenced this pull request Jul 10, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants