HDDS-1586. Allow Ozone RPC client to read with topology awareness. #931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadoop-yetus
reviewed
Jun 8, 2019
| @@ -1067,4 +1071,43 @@ public double getCurrentContainerThreshold() { | |||
| public SCMMetadataStore getScmMetadataStore() { | |||
| return scmMetadataStore; | |||
| } | |||
|
|
|||
xiaoyuyao
reviewed
Jun 13, 2019
| @@ -76,7 +81,8 @@ public XceiverClientManager(Configuration conf) { | |||
| SCM_CONTAINER_CLIENT_MAX_SIZE_DEFAULT); | |||
| long staleThresholdMs = conf.getTimeDuration( | |||
| SCM_CONTAINER_CLIENT_STALE_THRESHOLD_KEY, | |||
| SCM_CONTAINER_CLIENT_STALE_THRESHOLD_DEFAULT, TimeUnit.MILLISECONDS); | |||
| //SCM_CONTAINER_CLIENT_STALE_THRESHOLD_DEFAULT, TimeUnit.MILLISECONDS); | |||
There was a problem hiding this comment.
Is there a reason to hard code the stale threshold here?
There was a problem hiding this comment.
It's changed for unit test. Forget to remove it.
xiaoyuyao
reviewed
Jun 13, 2019
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
xiaoyuyao
reviewed
Jun 13, 2019
| 1, null, null, null, null, 0)); | ||
| nodeList.add((DatanodeDetails)scm.getClusterMap().getNode( | ||
| 2, null, null, null, null, 0)); | ||
| Assume.assumeTrue(nodeList.get(0) != nodeList.get(1)); |
There was a problem hiding this comment.
should we use .equals() here?
xiaoyuyao
reviewed
Jun 13, 2019
| throws IOException { | ||
| HddsProtos.ReplicationType type = pipeline.getType(); | ||
| try { | ||
| // create different client for read different pipeline node based on | ||
| // network topology | ||
| String key = pipeline.getId().getId().toString() + type; |
There was a problem hiding this comment.
Can we wrap this logic in a help function like getPipelineKey()?
|
rebase against latest trunk |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
/retest |
xiaoyuyao
reviewed
Jul 9, 2019
| @@ -2347,7 +2347,7 @@ public OmKeyInfo lookupKey(OmKeyArgs args) throws IOException { | |||
| boolean auditSuccess = true; | |||
| try { | |||
| metrics.incNumKeyLookups(); | |||
| return keyManager.lookupKey(args); | |||
| return keyManager.lookupKey(args, getClientAddress()); | |||
There was a problem hiding this comment.
Do we assume the topology mapping always use Ip address?
There was a problem hiding this comment.
No, use Ip address or hostname depends on the value of "dfs.datanode.use.datanode.hostname" property. If it's true, then use hostname, if it's false, the use Ipaddress. The default value of this property is false.
|
Thanks @ChenSammi for the patch. It LGTM, +1. I will commit it shortly. |
|
Thanks @xiaoyuyao for reviewing the code. |
|
The JIRA has been merged with a different PR. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
Author: Ray Matharu <rmatharu@linkedin.com> Reviewers: shanthoosh Closes apache#931 from rmatharu/test-standby-grouper-fix and squashes the following commits: 767ca92e [Ray Matharu] Updating test 4eab3c18 [Ray Matharu] Minor 1394a6d7 [Ray Matharu] Igoring standby tasks when grouping 96e3d8f3 [Ray Matharu] Merge branch 'master' of https://github.com/apache/samza 40f68a61 [Ray Matharu] Merge branch 'master' of https://github.com/apache/samza 497602ab [Ray Matharu] Merge branch 'master' of https://github.com/apache/samza 1a72dc48 [Ray Matharu] Merge branch 'master' of https://github.com/apache/samza 36c0b339 [Ray Matharu] Merge branch 'master' of https://github.com/apache/samza 12ca96bb [Ray Matharu] Merge branch 'master' of https://github.com/apache/samza ee7daac8 [Ray Matharu] Merge branch 'master' of https://github.com/apache/samza 08006871 [Ray Matharu] Merge branch 'master' of https://github.com/apache/samza 916f66ae [Ray Matharu] Merge branch 'master' of https://github.com/apache/samza 2c09b081 [Ray Matharu] Rocksdb bug fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HDDS-1586