HDDS-1543. Implement addAcl,removeAcl,setAcl,getAcl for Prefix. Contr… #927

xiaoyuyao · 2019-06-07T22:29:39Z

…ibuted by Xiaoyu Yao.

hadoop-yetus · 2019-06-08T00:01:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	34	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 3 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	46	Maven dependency ordering for branch
+1	mvninstall	574	trunk passed
+1	compile	308	trunk passed
+1	checkstyle	72	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	829	branch has no errors when building and testing our client artifacts.
+1	javadoc	190	trunk passed
0	spotbugs	340	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	528	trunk passed
		_ Patch Compile Tests _
0	mvndep	26	Maven dependency ordering for patch
+1	mvninstall	485	the patch passed
+1	compile	313	the patch passed
+1	cc	313	the patch passed
+1	javac	313	the patch passed
-0	checkstyle	49	hadoop-ozone: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	689	patch has no errors when building and testing our client artifacts.
+1	javadoc	180	the patch passed
-1	findbugs	348	hadoop-ozone generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1	unit	162	hadoop-hdds in the patch failed.
-1	unit	60	hadoop-ozone in the patch failed.
+1	asflicense	58	The patch does not generate ASF License warnings.
		5438

Reason	Tests
FindBugs	module:hadoop-ozone
	Potentially dangerous use of non-short-circuit logic in org.apache.hadoop.ozone.om.PrefixManagerImpl.removeAcl(OzoneObj, OzoneAcl) At PrefixManagerImpl.java:logic in org.apache.hadoop.ozone.om.PrefixManagerImpl.removeAcl(OzoneObj, OzoneAcl) At PrefixManagerImpl.java:[line 163]
Failed junit tests	hadoop.ozone.container.common.impl.TestHddsDispatcher
	hadoop.ozone.om.exceptions.TestResultCodes

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-927/1/artifact/out/Dockerfile
GITHUB PR	#927
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux 19b79af66244 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `76b94c2`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/1/artifact/out/new-findbugs-hadoop-ozone.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/1/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/1/testReport/
Max. process+thread count	440 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

xiaoyuyao · 2019-06-08T04:42:48Z

/retest

hadoop-yetus · 2019-06-08T05:01:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	26	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 3 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	49	Maven dependency ordering for branch
+1	mvninstall	521	trunk passed
+1	compile	302	trunk passed
+1	checkstyle	98	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	975	branch has no errors when building and testing our client artifacts.
+1	javadoc	168	trunk passed
0	spotbugs	357	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	558	trunk passed
		_ Patch Compile Tests _
0	mvndep	20	Maven dependency ordering for patch
+1	mvninstall	484	the patch passed
+1	compile	284	the patch passed
+1	cc	284	the patch passed
+1	javac	284	the patch passed
+1	checkstyle	84	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	734	patch has no errors when building and testing our client artifacts.
+1	javadoc	179	the patch passed
+1	findbugs	616	the patch passed
		_ Other Tests _
-1	unit	166	hadoop-hdds in the patch failed.
-1	unit	52	hadoop-ozone in the patch failed.
+1	asflicense	43	The patch does not generate ASF License warnings.
		5511

Reason	Tests
Failed junit tests	hadoop.ozone.container.common.impl.TestHddsDispatcher
	hadoop.ozone.om.exceptions.TestResultCodes

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-927/2/artifact/out/Dockerfile
GITHUB PR	#927
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux aacb4fffcf39 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `76b94c2`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/2/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/2/testReport/
Max. process+thread count	340 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-06-08T09:07:26Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	44	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 3 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	27	Maven dependency ordering for branch
+1	mvninstall	515	trunk passed
+1	compile	292	trunk passed
+1	checkstyle	87	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	956	branch has no errors when building and testing our client artifacts.
+1	javadoc	169	trunk passed
0	spotbugs	343	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	534	trunk passed
		_ Patch Compile Tests _
0	mvndep	21	Maven dependency ordering for patch
+1	mvninstall	471	the patch passed
+1	compile	298	the patch passed
+1	cc	298	the patch passed
+1	javac	298	the patch passed
-0	checkstyle	45	hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	1	The patch has no whitespace issues.
+1	shadedclient	751	patch has no errors when building and testing our client artifacts.
+1	javadoc	170	the patch passed
+1	findbugs	638	the patch passed
		_ Other Tests _
-1	unit	212	hadoop-hdds in the patch failed.
-1	unit	1326	hadoop-ozone in the patch failed.
+1	asflicense	52	The patch does not generate ASF License warnings.
		6835

Reason	Tests
Failed junit tests	hadoop.ozone.container.common.impl.TestHddsDispatcher
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.ozone.client.rpc.TestWatchForCommit
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.hdds.scm.pipeline.TestSCMPipelineManager
	hadoop.ozone.TestMiniOzoneCluster
	hadoop.ozone.om.TestOzoneManager

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-927/3/artifact/out/Dockerfile
GITHUB PR	#927
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux 8a74a8490a5e 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `9deac3b`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/3/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/3/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/3/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/3/testReport/
Max. process+thread count	4603 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/3/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/acl/OzoneObjInfo.java

...ration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java

hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/PrefixManagerImpl.java

hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestKeyManagerImpl.java

hadoop-yetus · 2019-06-12T02:25:07Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	31	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 3 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	41	Maven dependency ordering for branch
+1	mvninstall	506	trunk passed
+1	compile	304	trunk passed
+1	checkstyle	69	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	801	branch has no errors when building and testing our client artifacts.
+1	javadoc	158	trunk passed
0	spotbugs	335	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	530	trunk passed
		_ Patch Compile Tests _
0	mvndep	18	Maven dependency ordering for patch
+1	mvninstall	448	the patch passed
+1	compile	284	the patch passed
+1	cc	284	the patch passed
+1	javac	284	the patch passed
-0	checkstyle	40	hadoop-ozone: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	634	patch has no errors when building and testing our client artifacts.
+1	javadoc	163	the patch passed
-1	findbugs	376	hadoop-ozone generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1	unit	160	hadoop-hdds in the patch failed.
-1	unit	1739	hadoop-ozone in the patch failed.
+1	asflicense	46	The patch does not generate ASF License warnings.
		6785

Reason	Tests
FindBugs	module:hadoop-ozone
	Redundant nullcheck of list, which is known to be non-null in org.apache.hadoop.ozone.om.PrefixManagerImpl.removeAcl(OzoneObj, OzoneAcl) Redundant null check at PrefixManagerImpl.java:is known to be non-null in org.apache.hadoop.ozone.om.PrefixManagerImpl.removeAcl(OzoneObj, OzoneAcl) Redundant null check at PrefixManagerImpl.java:[line 180]
Failed junit tests	hadoop.ozone.container.common.impl.TestHddsDispatcher
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
	hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-927/4/artifact/out/Dockerfile
GITHUB PR	#927
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux 5195a3f2a5be 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `4ea6c2f`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/4/artifact/out/diff-checkstyle-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/4/artifact/out/new-findbugs-hadoop-ozone.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/4/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/4/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/4/testReport/
Max. process+thread count	3984 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/4/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-06-12T05:32:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	26	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 3 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	50	Maven dependency ordering for branch
+1	mvninstall	517	trunk passed
+1	compile	282	trunk passed
+1	checkstyle	80	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	952	branch has no errors when building and testing our client artifacts.
+1	javadoc	175	trunk passed
0	spotbugs	379	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	593	trunk passed
		_ Patch Compile Tests _
0	mvndep	18	Maven dependency ordering for patch
+1	mvninstall	462	the patch passed
+1	compile	288	the patch passed
+1	cc	288	the patch passed
+1	javac	288	the patch passed
+1	checkstyle	83	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	742	patch has no errors when building and testing our client artifacts.
+1	javadoc	165	the patch passed
+1	findbugs	543	the patch passed
		_ Other Tests _
-1	unit	163	hadoop-hdds in the patch failed.
-1	unit	1176	hadoop-ozone in the patch failed.
+1	asflicense	51	The patch does not generate ASF License warnings.
		6531

Reason	Tests
Failed junit tests	hadoop.ozone.container.common.impl.TestHddsDispatcher
	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestFailureHandlingByClient
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestOzoneRpcClient

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-927/6/artifact/out/Dockerfile
GITHUB PR	#927
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux 4b38b4a2239a 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `4ea6c2f`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/6/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/6/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/6/testReport/
Max. process+thread count	4999 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/6/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-06-12T05:38:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	76	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 3 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	12	Maven dependency ordering for branch
+1	mvninstall	514	trunk passed
+1	compile	319	trunk passed
+1	checkstyle	83	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	916	branch has no errors when building and testing our client artifacts.
+1	javadoc	168	trunk passed
0	spotbugs	414	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	608	trunk passed
		_ Patch Compile Tests _
0	mvndep	21	Maven dependency ordering for patch
+1	mvninstall	465	the patch passed
+1	compile	325	the patch passed
+1	cc	325	the patch passed
+1	javac	325	the patch passed
+1	checkstyle	98	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	846	patch has no errors when building and testing our client artifacts.
+1	javadoc	199	the patch passed
+1	findbugs	574	the patch passed
		_ Other Tests _
-1	unit	184	hadoop-hdds in the patch failed.
-1	unit	1300	hadoop-ozone in the patch failed.
+1	asflicense	49	The patch does not generate ASF License warnings.
		6975

Reason	Tests
Failed junit tests	hadoop.ozone.container.common.impl.TestHddsDispatcher
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.om.TestOzoneManager
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

Subsystem	Report/Notes
Docker	Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-927/5/artifact/out/Dockerfile
GITHUB PR	#927
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux e9ebbe5d3976 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `4ea6c2f`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/5/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/5/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/5/testReport/
Max. process+thread count	4452 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/5/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

…ibuted by Xiaoyu Yao.

hadoop-yetus · 2019-06-12T16:15:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	46	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 3 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	43	Maven dependency ordering for branch
+1	mvninstall	569	trunk passed
+1	compile	332	trunk passed
+1	checkstyle	83	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	954	branch has no errors when building and testing our client artifacts.
+1	javadoc	183	trunk passed
0	spotbugs	387	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	602	trunk passed
		_ Patch Compile Tests _
0	mvndep	21	Maven dependency ordering for patch
+1	mvninstall	489	the patch passed
+1	compile	304	the patch passed
+1	cc	304	the patch passed
+1	javac	304	the patch passed
+1	checkstyle	84	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	731	patch has no errors when building and testing our client artifacts.
+1	javadoc	184	the patch passed
+1	findbugs	625	the patch passed
		_ Other Tests _
-1	unit	200	hadoop-hdds in the patch failed.
-1	unit	1506	hadoop-ozone in the patch failed.
+1	asflicense	48	The patch does not generate ASF License warnings.
		7192

Reason	Tests
Failed junit tests	hadoop.ozone.container.common.impl.TestHddsDispatcher
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestBCSID

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-927/7/artifact/out/Dockerfile
GITHUB PR	#927
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux 274cdbff273b 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `3b31694`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/7/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/7/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/7/testReport/
Max. process+thread count	5031 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/7/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-06-12T20:36:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	531	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 3 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	45	Maven dependency ordering for branch
+1	mvninstall	517	trunk passed
+1	compile	297	trunk passed
+1	checkstyle	80	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	926	branch has no errors when building and testing our client artifacts.
+1	javadoc	175	trunk passed
0	spotbugs	340	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	535	trunk passed
		_ Patch Compile Tests _
0	mvndep	21	Maven dependency ordering for patch
+1	mvninstall	455	the patch passed
+1	compile	284	the patch passed
+1	cc	284	the patch passed
+1	javac	284	the patch passed
+1	checkstyle	84	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	733	patch has no errors when building and testing our client artifacts.
+1	javadoc	168	the patch passed
+1	findbugs	544	the patch passed
		_ Other Tests _
-1	unit	161	hadoop-hdds in the patch failed.
-1	unit	1175	hadoop-ozone in the patch failed.
+1	asflicense	50	The patch does not generate ASF License warnings.
		6979

Reason	Tests
Failed junit tests	hadoop.ozone.container.common.impl.TestHddsDispatcher
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestOzoneRpcClient

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-927/8/artifact/out/Dockerfile
GITHUB PR	#927
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux 310eaf9e301e 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `cf84881`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/8/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/8/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/8/testReport/
Max. process+thread count	3767 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-927/8/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

ajayydv · 2019-06-12T22:06:43Z

+1 pending unit tests.

apache#927)

Adding invokeApplicationRunner public static API in preparation for fast sql where this API will be called directly within the same process. Author: Aditya Toomula <atoomula@linkedin.com> Reviewers: prateekm Closes apache#927 from atoomula/runner and squashes the following commits: 47c33884 [Aditya Toomula] Refactoring ApplicationRunnerMain code in preparation for fast samza sql. c7c525a9 [Aditya Toomula] Refactoring ApplicationRunnerMain code in preparation for fast samza sql. 4b5fb24d [Aditya Toomula] Refactoring ApplicationRunnerMain code in preparation for fast samza sql. 39a8626c [Aditya Toomula] Refactoring ApplicationRunnerMain code in preparation for fast samza sql.

xiaoyuyao self-assigned this Jun 7, 2019

xiaoyuyao added the ozone label Jun 7, 2019

xiaoyuyao force-pushed the HDDS-1543 branch from b2ea1c0 to a40dbc6 Compare June 8, 2019 07:12

ajayydv reviewed Jun 10, 2019

View reviewed changes

xiaoyuyao force-pushed the HDDS-1543 branch from a40dbc6 to f24692b Compare June 12, 2019 00:31

xiaoyuyao force-pushed the HDDS-1543 branch from 3dec18b to 9143ea4 Compare June 12, 2019 03:42

HDDS-1543. Implement addAcl,removeAcl,setAcl,getAcl for Prefix. Contr…

8b55aa3

…ibuted by Xiaoyu Yao.

xiaoyuyao force-pushed the HDDS-1543 branch from 9143ea4 to 8b55aa3 Compare June 12, 2019 14:14

Fix unit test

da486b3

xiaoyuyao merged commit a43f444 into apache:trunk Jun 12, 2019

bshashikant pushed a commit to bshashikant/hadoop that referenced this pull request Jul 10, 2019

HDDS-1543. Implement addAcl,removeAcl,setAcl,getAcl for Prefix. Contr… (

3958e30

apache#927)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDDS-1543. Implement addAcl,removeAcl,setAcl,getAcl for Prefix. Contr… #927

HDDS-1543. Implement addAcl,removeAcl,setAcl,getAcl for Prefix. Contr… #927

xiaoyuyao commented Jun 7, 2019

hadoop-yetus commented Jun 8, 2019

xiaoyuyao commented Jun 8, 2019

hadoop-yetus commented Jun 8, 2019

hadoop-yetus commented Jun 8, 2019

hadoop-yetus commented Jun 12, 2019

hadoop-yetus commented Jun 12, 2019

hadoop-yetus commented Jun 12, 2019

hadoop-yetus commented Jun 12, 2019

hadoop-yetus commented Jun 12, 2019

ajayydv commented Jun 12, 2019

HDDS-1543. Implement addAcl,removeAcl,setAcl,getAcl for Prefix. Contr… #927

HDDS-1543. Implement addAcl,removeAcl,setAcl,getAcl for Prefix. Contr… #927

Conversation

xiaoyuyao commented Jun 7, 2019

hadoop-yetus commented Jun 8, 2019

xiaoyuyao commented Jun 8, 2019

hadoop-yetus commented Jun 8, 2019

hadoop-yetus commented Jun 8, 2019

hadoop-yetus commented Jun 12, 2019

hadoop-yetus commented Jun 12, 2019

hadoop-yetus commented Jun 12, 2019

hadoop-yetus commented Jun 12, 2019

hadoop-yetus commented Jun 12, 2019

ajayydv commented Jun 12, 2019