HDDS-1659. Define the process to add proposal/design docs to the Ozone subproject #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elek
commented
Jun 7, 2019
|
|
||
| * Open a dedicated Jira (`HDDS-*` but with specific component) | ||
| * Use standard name prefix in the jira (easy to filter on the mailing list) `[OEP] | ||
| * Create a PR to merge the design doc (markdown) to `hadoop-hdds/docs/content/proposal` (will be part of the docs) |
There was a problem hiding this comment.
During an offline discussion @arp7 had some concerns about the usability of reviewing markdown files in PR vs. reviewing google docs.
There was a problem hiding this comment.
Note: this is a complex PR because it contains the changes to show design docs on the docs page. A normal design doc would contain just one markdown file.
There was a problem hiding this comment.
Update: I removed the HTTP/template changes.
|
🎊 +1 overall
This message was automatically generated. |
ajayydv
reviewed
Jun 10, 2019
| * [Apache Spark Project Improvement Proposals](https://spark.apache.org/improvement-proposals.html) | ||
| * [Kubernetes Enhancement Proposals](https://github.com/kubernetes/enhancements/tree/master/keps) | ||
|
|
||
| Short summary if the porcesses: |
|
i like the idea of more detailed information in markdown format. It will be easier to update in subsequent changes and will be included in docs in case some user wants to access it. |
|
At all, this is just the start of this conversation, let us commit this and iterate over this process and get into a good shape. Thank you all for a wonderful discussion during the community call. |
|
Thanks to commit this @anuengineer I repoened it temporary as it introduced a RAT error in daily build. Will upload a fixed version soon. |
bshashikant
pushed a commit
to bshashikant/hadoop
that referenced
this pull request
Jul 10, 2019
…e subproject (apache#922) * HDDS-1659. Define the process to add proposal/design docs to the Ozone subproject * Remove Site improvements to display proposals
bshashikant
pushed a commit
to bshashikant/hadoop
that referenced
this pull request
Jul 10, 2019
…the Ozone subproject (apache#922)" This reverts commit e997f2a.
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
Checkstyle version upgrade 5.9 -> 6.11 and fixes to pass checks **Why this version (6.11) but not latest (8.17)?** In version [6.11.1](http://checkstyle.sourceforge.net/releasenotes.html#Release_6.11.1) lambda indentation support was added, and it reports tremendous amount of errors in project. I found no option to change indent policy for lambdas therefore set version without this check. Author: strkkk <andreypaykin@gmail.com> Reviewers: Sanil Jain <snjain@linkedin.com> Closes apache#922 from strkkk/checkstyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We think that it would be more effective to collect all the design docs in one place and make it easier to review them by the community.
We propose to follow an approach where the proposals are committed to the hadoop-hdds/docs project and the review can be the same as a review of a PR
See: https://issues.apache.org/jira/browse/HDDS-1659