Skip to content

HDDS-1650. Fix Ozone tests leaking volume checker thread. Contributed… #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2019
Merged

HDDS-1650. Fix Ozone tests leaking volume checker thread. Contributed… #915

merged 1 commit into from
Jun 6, 2019

Conversation

xiaoyuyao
Copy link
Contributor

… by Xiaoyu Yao.

@xiaoyuyao xiaoyuyao self-assigned this Jun 5, 2019
@xiaoyuyao xiaoyuyao added bug ozone and removed bug labels Jun 5, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 156 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 6 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 670 trunk passed
+1 compile 323 trunk passed
+1 checkstyle 90 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 987 branch has no errors when building and testing our client artifacts.
+1 javadoc 174 trunk passed
0 spotbugs 376 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 603 trunk passed
_ Patch Compile Tests _
+1 mvninstall 472 the patch passed
+1 compile 277 the patch passed
+1 javac 277 the patch passed
+1 checkstyle 84 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 727 patch has no errors when building and testing our client artifacts.
+1 javadoc 163 the patch passed
+1 findbugs 522 the patch passed
_ Other Tests _
-1 unit 166 hadoop-hdds in the patch failed.
-1 unit 1217 hadoop-ozone in the patch failed.
+1 asflicense 50 The patch does not generate ASF License warnings.
6883
Reason Tests
Failed junit tests hadoop.ozone.container.common.impl.TestHddsDispatcher
hadoop.ozone.client.rpc.TestBCSID
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
Subsystem Report/Notes
Docker Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-915/1/artifact/out/Dockerfile
GITHUB PR #915
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 6fb421f8a9b4 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 3b1c257
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-915/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-915/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-915/1/testReport/
Max. process+thread count 4416 (vs. ulimit of 5500)
modules C: hadoop-hdds/container-service U: hadoop-hdds/container-service
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-915/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

nandakumar131
nandakumar131 approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@nandakumar131 nandakumar131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@nandakumar131 nandakumar131 merged commit c7e6f07 into apache:trunk Jun 6, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@rmatharu @atoomula
Consolidating offset read and write for store-offsets and side-inputs…
551192f 
…, maintaining backward compatbility

This consolidates the two different kinds of offsets used by stores and side-inputs into one.
The code can still read and make sense of store-offset files written in the old format.
The new format stores a map of ssp to offset, rather than a singular string.

Updated tests.
And added tests to ensure the reading of the old-format offset still works.

Author: Ray Matharu <rmatharu@linkedin.com>

Reviewers: mynameborat

Closes apache#915 from rmatharu/test-offset and squashes the following commits:

c20e94c4 [Ray Matharu] minor
403f72b1 [Ray Matharu] simplifying code
b5868066 [Ray Matharu] minor
ca648223 [Ray Matharu] gradle.props
b50e5fe1 [Ray Matharu] Applying comments
75905b0c [Ray Matharu] minor
a8d1dcdc [Ray Matharu] Addressing review comments
1f7ecdcc [Ray Matharu] minor
666157ad [Ray Matharu] test fix
d621a51c [Ray Matharu] Adding test for read of old format
b9e58997 [Ray Matharu] build fix
9cb822ca [Ray Matharu] bug fix
5484e430 [Ray Matharu] Consolidating writing of offsets
55f35b7b [Ray Matharu] minor
88963a8c [Ray Matharu] minor
f14ee03b [Ray Matharu] Consolidating read of offset file
12ca96bb [Ray Matharu] Merge branch 'master' of https://github.com/apache/samza
ee7daac8 [Ray Matharu] Merge branch 'master' of https://github.com/apache/samza
08006871 [Ray Matharu] Merge branch 'master' of https://github.com/apache/samza
916f66ae [Ray Matharu] Merge branch 'master' of https://github.com/apache/samza
2c09b081 [Ray Matharu] Rocksdb bug fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nandakumar131 nandakumar131 nandakumar131 approved these changes

Assignees

@xiaoyuyao xiaoyuyao

Labels
ozone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaoyuyao @hadoop-yetus @nandakumar131