HDDS-1555. Disable install snapshot for ContainerStateMachine. #846

swagle · 2019-05-23T03:11:49Z

pom change is needed to get the latest RATIS master and get RATIS-564 changes.

The configuration installSnapshotEnabled = false actually controls whether only a notification is sent to the follower and not the snapshot chunk, I guess this flag is not correctly named and I can address that in a later version of the patch.
The fact that the snapshot contents cannot be used to actually catch up the follower, it is the reason to initiate close pipeline and not install the snapshot. The follower will basically never be able to catch up.
The Replication monitor after the close will take care of replication of closed containers.

hadoop-yetus · 2019-05-23T05:03:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	31	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	13	Maven dependency ordering for branch
+1	mvninstall	612	trunk passed
+1	compile	327	trunk passed
+1	checkstyle	78	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	989	branch has no errors when building and testing our client artifacts.
+1	javadoc	163	trunk passed
0	spotbugs	387	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	637	trunk passed
		_ Patch Compile Tests _
0	mvndep	21	Maven dependency ordering for patch
-1	mvninstall	126	hadoop-hdds in the patch failed.
-1	compile	78	hadoop-hdds in the patch failed.
-1	javac	78	hadoop-hdds in the patch failed.
+1	checkstyle	81	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	744	patch has no errors when building and testing our client artifacts.
+1	javadoc	149	the patch passed
-1	findbugs	127	hadoop-hdds in the patch failed.
		_ Other Tests _
-1	unit	139	hadoop-hdds in the patch failed.
-1	unit	1152	hadoop-ozone in the patch failed.
+1	asflicense	54	The patch does not generate ASF License warnings.
		6639

Reason	Tests
Failed junit tests	hadoop.ozone.container.common.impl.TestContainerPersistence
	hadoop.ozone.client.rpc.TestOzoneRpcClient

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-846/1/artifact/out/Dockerfile
GITHUB PR	#846
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 62fb57d2ccc7 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `03aa70f`
Default Java	1.8.0_212
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/1/artifact/out/patch-mvninstall-hadoop-hdds.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/1/artifact/out/patch-compile-hadoop-hdds.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/1/artifact/out/patch-compile-hadoop-hdds.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/1/artifact/out/patch-findbugs-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/1/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/1/testReport/
Max. process+thread count	4182 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java

...java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java

bshashikant · 2019-05-30T05:59:26Z

Thanks @swagle for working on this. The changes look good. I have just one point to make here:
Add a javadoc/comments for handleInstallSnapshotFromLeader() specifying the reason to close down the pipeline as well for disabling the installSnapshotEnabled in the code.

I am +1 after that.

jiwq

+1 (non-binding)

hadoop-yetus · 2019-05-31T23:23:33Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	75	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	41	Maven dependency ordering for branch
+1	mvninstall	625	trunk passed
+1	compile	300	trunk passed
+1	checkstyle	73	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	919	branch has no errors when building and testing our client artifacts.
+1	javadoc	173	trunk passed
0	spotbugs	336	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	526	trunk passed
		_ Patch Compile Tests _
0	mvndep	16	Maven dependency ordering for patch
-1	mvninstall	93	hadoop-hdds in the patch failed.
-1	compile	79	hadoop-hdds in the patch failed.
-1	javac	79	hadoop-hdds in the patch failed.
-0	checkstyle	40	hadoop-hdds: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	686	patch has no errors when building and testing our client artifacts.
+1	javadoc	166	the patch passed
-1	findbugs	124	hadoop-hdds in the patch failed.
		_ Other Tests _
-1	unit	139	hadoop-hdds in the patch failed.
-1	unit	1760	hadoop-ozone in the patch failed.
+1	asflicense	56	The patch does not generate ASF License warnings.
		7062

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-846/2/artifact/out/Dockerfile
GITHUB PR	#846
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 7aa0167c5af2 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `c1d2d92`
Default Java	1.8.0_212
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/2/artifact/out/patch-mvninstall-hadoop-hdds.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/2/artifact/out/patch-compile-hadoop-hdds.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/2/artifact/out/patch-compile-hadoop-hdds.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/2/artifact/out/diff-checkstyle-hadoop-hdds.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/2/artifact/out/patch-findbugs-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/2/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/2/testReport/
Max. process+thread count	5060 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

bshashikant · 2019-06-04T11:35:42Z

Thanks @swagle for updating the patch. The patch looks good me. I am +1 on this. Please take care of the checkstyle issues reported.

hadoop-yetus · 2019-06-04T21:17:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	37	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	28	Maven dependency ordering for branch
+1	mvninstall	580	trunk passed
+1	compile	292	trunk passed
+1	checkstyle	71	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	859	branch has no errors when building and testing our client artifacts.
+1	javadoc	164	trunk passed
0	spotbugs	363	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	567	trunk passed
		_ Patch Compile Tests _
0	mvndep	20	Maven dependency ordering for patch
-1	mvninstall	93	hadoop-hdds in the patch failed.
-1	compile	70	hadoop-hdds in the patch failed.
-1	javac	70	hadoop-hdds in the patch failed.
+1	checkstyle	76	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	626	patch has no errors when building and testing our client artifacts.
+1	javadoc	154	the patch passed
-1	findbugs	128	hadoop-hdds in the patch failed.
		_ Other Tests _
-1	unit	137	hadoop-hdds in the patch failed.
-1	unit	966	hadoop-ozone in the patch failed.
+1	asflicense	46	The patch does not generate ASF License warnings.
		5954

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestWatchForCommit
	hadoop.hdds.scm.pipeline.TestRatisPipelineProvider

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-846/3/artifact/out/Dockerfile
GITHUB PR	#846
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 05a7abdae568 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `580b639`
Default Java	1.8.0_212
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/3/artifact/out/patch-mvninstall-hadoop-hdds.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/3/artifact/out/patch-compile-hadoop-hdds.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/3/artifact/out/patch-compile-hadoop-hdds.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/3/artifact/out/patch-findbugs-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/3/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/3/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/3/testReport/
Max. process+thread count	4637 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/3/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-06-06T06:10:26Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	29	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	76	Maven dependency ordering for branch
+1	mvninstall	557	trunk passed
+1	compile	317	trunk passed
+1	checkstyle	81	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	924	branch has no errors when building and testing our client artifacts.
+1	javadoc	174	trunk passed
0	spotbugs	334	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	536	trunk passed
		_ Patch Compile Tests _
0	mvndep	30	Maven dependency ordering for patch
-1	mvninstall	106	hadoop-hdds in the patch failed.
-1	mvninstall	130	hadoop-ozone in the patch failed.
-1	compile	51	hadoop-hdds in the patch failed.
-1	compile	51	hadoop-ozone in the patch failed.
-1	javac	51	hadoop-hdds in the patch failed.
-1	javac	51	hadoop-ozone in the patch failed.
+1	checkstyle	71	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	2	The patch has no ill-formed XML file.
+1	shadedclient	728	patch has no errors when building and testing our client artifacts.
+1	javadoc	149	the patch passed
-1	findbugs	96	hadoop-hdds in the patch failed.
-1	findbugs	102	hadoop-ozone in the patch failed.
		_ Other Tests _
-1	unit	153	hadoop-hdds in the patch failed.
-1	unit	101	hadoop-ozone in the patch failed.
+1	asflicense	37	The patch does not generate ASF License warnings.
		4656

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-846/4/artifact/out/Dockerfile
GITHUB PR	#846
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux e48d747d7af1 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `73954c1`
Default Java	1.8.0_212
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/4/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/4/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/4/artifact/out/patch-compile-hadoop-hdds.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/4/artifact/out/patch-compile-hadoop-ozone.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/4/artifact/out/patch-compile-hadoop-hdds.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/4/artifact/out/patch-compile-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/4/artifact/out/patch-findbugs-hadoop-hdds.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/4/artifact/out/patch-findbugs-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/4/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/4/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/4/testReport/
Max. process+thread count	339 (vs. ulimit of 5500)
modules	C: hadoop-hdds hadoop-hdds/common hadoop-hdds/container-service hadoop-ozone U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/4/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

mukul1987

Thanks for the updated pull request @swagle. There are some compilation failures with the new patch. Can you please look into that ?

hadoop-yetus · 2019-06-06T17:21:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	35	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	68	Maven dependency ordering for branch
+1	mvninstall	511	trunk passed
+1	compile	295	trunk passed
+1	checkstyle	88	trunk passed
+1	mvnsite	0	trunk passed
-1	shadedclient	170	branch has errors when building and testing our client artifacts.
+1	javadoc	173	trunk passed
0	spotbugs	326	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	511	trunk passed
		_ Patch Compile Tests _
0	mvndep	31	Maven dependency ordering for patch
+1	mvninstall	469	the patch passed
+1	compile	295	the patch passed
-1	javac	100	hadoop-hdds generated 3 new + 11 unchanged - 0 fixed = 14 total (was 11)
-0	checkstyle	43	hadoop-hdds: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	3	The patch has no ill-formed XML file.
-1	shadedclient	60	patch has errors when building and testing our client artifacts.
+1	javadoc	172	the patch passed
+1	findbugs	569	the patch passed
		_ Other Tests _
+1	unit	209	hadoop-hdds in the patch passed.
-1	unit	1726	hadoop-ozone in the patch failed.
+1	asflicense	53	The patch does not generate ASF License warnings.
		5701

Reason	Tests
Failed junit tests	hadoop.ozone.container.common.transport.server.ratis.TestCSMMetrics
	hadoop.ozone.client.rpc.TestContainerStateMachineFailures
	hadoop.ozone.client.rpc.TestWatchForCommit
	hadoop.ozone.scm.TestGetCommittedBlockLengthAndPutKey
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.container.server.TestSecureContainerServer
	hadoop.ozone.scm.node.TestQueryNode
	hadoop.ozone.client.rpc.TestReadRetries
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.scm.TestContainerSmallFile
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.client.rpc.TestContainerStateMachine
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.web.TestOzoneRestWithMiniCluster
	hadoop.ozone.TestContainerStateMachineIdempotency

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-846/5/artifact/out/Dockerfile
GITHUB PR	#846
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux cbb07eb2fec9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `36757ad`
Default Java	1.8.0_212
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/5/artifact/out/diff-compile-javac-hadoop-hdds.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/5/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/5/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/5/testReport/
Max. process+thread count	5404 (vs. ulimit of 5500)
modules	C: hadoop-hdds hadoop-hdds/client hadoop-hdds/common hadoop-hdds/container-service hadoop-ozone hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/5/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-06-06T22:42:48Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	31	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	23	Maven dependency ordering for branch
+1	mvninstall	538	trunk passed
+1	compile	277	trunk passed
+1	checkstyle	70	trunk passed
+1	mvnsite	0	trunk passed
-1	shadedclient	1232	branch has errors when building and testing our client artifacts.
+1	javadoc	159	trunk passed
0	spotbugs	333	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	518	trunk passed
		_ Patch Compile Tests _
0	mvndep	35	Maven dependency ordering for patch
+1	mvninstall	462	the patch passed
+1	compile	301	the patch passed
-1	javac	104	hadoop-hdds generated 3 new + 11 unchanged - 0 fixed = 14 total (was 11)
+1	checkstyle	85	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	3	The patch has no ill-formed XML file.
+1	shadedclient	692	patch has no errors when building and testing our client artifacts.
+1	javadoc	180	the patch passed
+1	findbugs	540	the patch passed
		_ Other Tests _
-1	unit	149	hadoop-hdds in the patch failed.
-1	unit	1528	hadoop-ozone in the patch failed.
+1	asflicense	58	The patch does not generate ASF License warnings.
		7101

Reason	Tests
Failed junit tests	hadoop.ozone.container.common.impl.TestHddsDispatcher
	hadoop.ozone.container.common.transport.server.ratis.TestCSMMetrics
	hadoop.ozone.client.rpc.TestContainerStateMachineFailures
	hadoop.ozone.scm.TestGetCommittedBlockLengthAndPutKey
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.container.server.TestSecureContainerServer
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestFailureHandlingByClient
	hadoop.ozone.scm.TestContainerSmallFile
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.client.rpc.TestContainerStateMachine
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.hdds.scm.pipeline.TestPipelineClose
	hadoop.ozone.web.TestOzoneRestWithMiniCluster
	hadoop.ozone.TestContainerStateMachineIdempotency

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-846/6/artifact/out/Dockerfile
GITHUB PR	#846
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux 5e847226af57 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / cb9bc6e
Default Java	1.8.0_212
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/6/artifact/out/diff-compile-javac-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/6/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/6/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/6/testReport/
Max. process+thread count	5183 (vs. ulimit of 5500)
modules	C: hadoop-hdds hadoop-hdds/client hadoop-hdds/common hadoop-hdds/container-service hadoop-ozone hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/6/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

...ne/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisClient.java

...java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java

hadoop-yetus · 2019-06-11T19:33:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	32	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	65	Maven dependency ordering for branch
+1	mvninstall	516	trunk passed
+1	compile	295	trunk passed
+1	checkstyle	87	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	907	branch has no errors when building and testing our client artifacts.
+1	javadoc	170	trunk passed
0	spotbugs	329	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	509	trunk passed
		_ Patch Compile Tests _
0	mvndep	36	Maven dependency ordering for patch
+1	mvninstall	468	the patch passed
+1	compile	277	the patch passed
-1	javac	91	hadoop-hdds generated 3 new + 11 unchanged - 0 fixed = 14 total (was 11)
+1	checkstyle	68	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	2	The patch has no ill-formed XML file.
+1	shadedclient	608	patch has no errors when building and testing our client artifacts.
+1	javadoc	147	the patch passed
+1	findbugs	537	the patch passed
		_ Other Tests _
-1	unit	135	hadoop-hdds in the patch failed.
-1	unit	1525	hadoop-ozone in the patch failed.
+1	asflicense	44	The patch does not generate ASF License warnings.
		6615

Reason	Tests
Failed junit tests	hadoop.ozone.container.common.impl.TestHddsDispatcher
	hadoop.ozone.container.common.transport.server.ratis.TestCSMMetrics
	hadoop.ozone.client.rpc.TestContainerStateMachineFailures
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.scm.TestGetCommittedBlockLengthAndPutKey
	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.container.server.TestSecureContainerServer
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestFailureHandlingByClient
	hadoop.ozone.scm.TestContainerSmallFile
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.client.rpc.TestContainerStateMachine
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.web.TestOzoneRestWithMiniCluster
	hadoop.ozone.TestContainerStateMachineIdempotency

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-846/7/artifact/out/Dockerfile
GITHUB PR	#846
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux 4f4c68feacc3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `60c95e9`
Default Java	1.8.0_212
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/7/artifact/out/diff-compile-javac-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/7/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/7/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/7/testReport/
Max. process+thread count	3859 (vs. ulimit of 5500)
modules	C: hadoop-hdds hadoop-hdds/client hadoop-hdds/common hadoop-hdds/container-service hadoop-ozone hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/7/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

mukul1987

Thanks for the updated patch @swagle, +1, the patch looks good to me.

hanishakoneru · 2019-06-12T23:00:21Z

@swagle some of the unit test failures are likely related to the patch. Can you please take a look.

hadoop-yetus · 2019-06-28T06:32:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	517	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	64	Maven dependency ordering for branch
+1	mvninstall	477	trunk passed
+1	compile	251	trunk passed
+1	checkstyle	73	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	864	branch has no errors when building and testing our client artifacts.
+1	javadoc	162	trunk passed
0	spotbugs	312	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	501	trunk passed
		_ Patch Compile Tests _
0	mvndep	34	Maven dependency ordering for patch
+1	mvninstall	437	the patch passed
+1	compile	266	the patch passed
-1	javac	98	hadoop-hdds generated 3 new + 14 unchanged - 0 fixed = 17 total (was 14)
+1	checkstyle	80	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	3	The patch has no ill-formed XML file.
+1	shadedclient	687	patch has no errors when building and testing our client artifacts.
+1	javadoc	162	the patch passed
+1	findbugs	525	the patch passed
		_ Other Tests _
-1	unit	239	hadoop-hdds in the patch failed.
-1	unit	1946	hadoop-ozone in the patch failed.
+1	asflicense	37	The patch does not generate ASF License warnings.
		7498

Reason	Tests
Failed junit tests	hadoop.hdds.scm.container.placement.algorithms.TestSCMContainerPlacementRackAware
	hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline
	hadoop.ozone.container.common.transport.server.ratis.TestCSMMetrics
	hadoop.ozone.client.rpc.TestContainerStateMachineFailures
	hadoop.ozone.scm.TestGetCommittedBlockLengthAndPutKey
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestFailureHandlingByClient
	hadoop.ozone.scm.TestContainerSmallFile
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.client.rpc.TestContainerStateMachine
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerHandler
	hadoop.ozone.web.TestOzoneRestWithMiniCluster
	hadoop.ozone.TestContainerStateMachineIdempotency

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-846/8/artifact/out/Dockerfile
GITHUB PR	#846
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux 011ba88db14f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `4a21224`
Default Java	1.8.0_212
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/8/artifact/out/diff-compile-javac-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/8/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/8/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/8/testReport/
Max. process+thread count	5405 (vs. ulimit of 5500)
modules	C: hadoop-hdds hadoop-hdds/client hadoop-hdds/common hadoop-hdds/container-service hadoop-ozone hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/8/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-06-28T17:26:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	33	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	70	Maven dependency ordering for branch
+1	mvninstall	494	trunk passed
+1	compile	255	trunk passed
+1	checkstyle	66	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	854	branch has no errors when building and testing our client artifacts.
+1	javadoc	151	trunk passed
0	spotbugs	321	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	519	trunk passed
		_ Patch Compile Tests _
0	mvndep	34	Maven dependency ordering for patch
+1	mvninstall	433	the patch passed
+1	compile	264	the patch passed
-1	javac	95	hadoop-hdds generated 3 new + 14 unchanged - 0 fixed = 17 total (was 14)
+1	checkstyle	79	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	3	The patch has no ill-formed XML file.
+1	shadedclient	680	patch has no errors when building and testing our client artifacts.
+1	javadoc	157	the patch passed
+1	findbugs	514	the patch passed
		_ Other Tests _
-1	unit	144	hadoop-hdds in the patch failed.
-1	unit	416	hadoop-ozone in the patch failed.
+1	asflicense	37	The patch does not generate ASF License warnings.
		5376

Reason	Tests
Failed junit tests	hadoop.ozone.container.ozoneimpl.TestOzoneContainer
	hadoop.ozone.scm.TestGetCommittedBlockLengthAndPutKey
	hadoop.hdds.scm.container.TestContainerStateManagerIntegration
	hadoop.ozone.web.client.TestKeysRatis
	hadoop.ozone.scm.pipeline.TestPipelineManagerMXBean
	hadoop.hdds.scm.safemode.TestSCMSafeModeWithPipelineRules
	hadoop.ozone.om.TestMultipleContainerReadWrite
	hadoop.ozone.client.rpc.TestContainerStateMachineFailures
	hadoop.ozone.TestContainerStateMachineIdempotency
	hadoop.ozone.web.client.TestBuckets
	hadoop.ozone.scm.TestContainerSmallFile
	hadoop.hdds.scm.pipeline.TestNode2PipelineMap
	hadoop.ozone.web.client.TestVolume
	hadoop.ozone.TestStorageContainerManager
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode
	hadoop.ozone.om.TestOmMetrics
	hadoop.ozone.scm.TestXceiverClientManager
	hadoop.ozone.ozShell.TestOzoneDatanodeShell
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestFailureHandlingByClient
	hadoop.ozone.container.common.statemachine.commandhandler.TestDeleteContainerHandler
	hadoop.ozone.scm.node.TestSCMNodeMetrics
	hadoop.ozone.client.rpc.TestBlockOutputStream
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
	hadoop.ozone.scm.TestXceiverClientMetrics
	hadoop.ozone.web.TestOzoneRestWithMiniCluster
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.om.TestOmAcls
	hadoop.ozone.om.TestOzoneManager
	hadoop.ozone.web.client.TestOzoneClient
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.ozone.web.client.TestKeys
	hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerHandler
	hadoop.ozone.ozShell.TestOzoneShell
	hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.TestMiniChaosOzoneCluster
	hadoop.ozone.scm.node.TestQueryNode
	hadoop.ozone.client.rpc.TestContainerStateMachine
	hadoop.ozone.om.TestContainerReportWithKeys
	hadoop.ozone.container.TestContainerReplication
	hadoop.ozone.client.rpc.TestReadRetries
	hadoop.ozone.container.ozoneimpl.TestSecureOzoneContainer
	hadoop.hdds.scm.pipeline.TestSCMRestart
	hadoop.ozone.web.TestOzoneWebAccess
	hadoop.ozone.web.TestOzoneVolumes
	hadoop.ozone.client.rpc.TestKeyInputStream
	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.om.TestOMDbCheckpointServlet
	hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
	hadoop.ozone.om.TestOzoneManagerHA
	hadoop.ozone.scm.TestSCMMXBean
	hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion
	hadoop.ozone.om.TestOmInit
	hadoop.ozone.container.ozoneimpl.TestOzoneContainer
	hadoop.ozone.om.TestOmBlockVersioning
	hadoop.ozone.om.TestOzoneManagerRestInterface
	hadoop.ozone.scm.pipeline.TestSCMPipelineMetrics
	hadoop.ozone.scm.TestAllocateContainer
	hadoop.ozone.scm.TestSCMNodeManagerMXBean
	hadoop.ozone.container.common.transport.server.ratis.TestCSMMetrics
	hadoop.hdds.scm.pipeline.TestPipelineClose
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.TestMiniOzoneCluster
	hadoop.ozone.container.server.TestSecureContainerServer
	hadoop.ozone.ozShell.TestS3Shell
	hadoop.hdds.scm.pipeline.TestNodeFailure
	hadoop.ozone.client.rpc.TestWatchForCommit
	hadoop.ozone.TestContainerOperations
	hadoop.ozone.om.snapshot.TestOzoneManagerSnapshotProvider

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-846/9/artifact/out/Dockerfile
GITHUB PR	#846
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux 4cb1667ad8ec 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / cbae241
Default Java	1.8.0_212
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/9/artifact/out/diff-compile-javac-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/9/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/9/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/9/testReport/
Max. process+thread count	4225 (vs. ulimit of 5500)
modules	C: hadoop-hdds hadoop-hdds/client hadoop-hdds/common hadoop-hdds/container-service hadoop-ozone hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/9/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

swagle · 2019-06-28T18:03:51Z

/retest

hadoop-yetus · 2019-06-29T00:12:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	68	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	322	Maven dependency ordering for branch
+1	mvninstall	605	trunk passed
+1	compile	257	trunk passed
+1	checkstyle	74	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	967	branch has no errors when building and testing our client artifacts.
+1	javadoc	184	trunk passed
0	spotbugs	340	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	550	trunk passed
		_ Patch Compile Tests _
0	mvndep	32	Maven dependency ordering for patch
+1	mvninstall	461	the patch passed
+1	compile	271	the patch passed
-1	javac	94	hadoop-hdds generated 3 new + 14 unchanged - 0 fixed = 17 total (was 14)
-0	checkstyle	39	hadoop-hdds: The patch generated 14 new + 0 unchanged - 0 fixed = 14 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	4	The patch has no ill-formed XML file.
+1	shadedclient	720	patch has no errors when building and testing our client artifacts.
+1	javadoc	176	the patch passed
+1	findbugs	549	the patch passed
		_ Other Tests _
-1	unit	101	hadoop-hdds in the patch failed.
-1	unit	1712	hadoop-ozone in the patch failed.
+1	asflicense	42	The patch does not generate ASF License warnings.
		7341

Reason	Tests
Failed junit tests	hadoop.hdds.conf.TestOzoneConfiguration
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestFailureHandlingByClient
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.ozone.client.rpc.TestWatchForCommit
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

Subsystem	Report/Notes
Docker	Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-846/10/artifact/out/Dockerfile
GITHUB PR	#846
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux 8e2386712003 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `29465bf`
Default Java	1.8.0_212
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/10/artifact/out/diff-compile-javac-hadoop-hdds.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/10/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/10/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/10/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/10/testReport/
Max. process+thread count	5106 (vs. ulimit of 5500)
modules	C: hadoop-hdds hadoop-hdds/client hadoop-hdds/common hadoop-hdds/config hadoop-hdds/container-service hadoop-ozone hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/10/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-hdds/common/src/main/resources/ozone-default.xml

hadoop-hdds/config/src/main/java/org/apache/hadoop/hdds/conf/ConfigFileGenerator.java

...a/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java

mukul1987 · 2019-06-29T05:56:42Z

/retest

hadoop-yetus · 2019-06-29T06:30:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	30	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	77	Maven dependency ordering for branch
+1	mvninstall	485	trunk passed
+1	compile	259	trunk passed
+1	checkstyle	74	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	867	branch has no errors when building and testing our client artifacts.
+1	javadoc	155	trunk passed
0	spotbugs	318	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	507	trunk passed
		_ Patch Compile Tests _
0	mvndep	34	Maven dependency ordering for patch
+1	mvninstall	451	the patch passed
+1	compile	263	the patch passed
+1	javac	263	the patch passed
-0	checkstyle	38	hadoop-hdds: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	5	The patch has no ill-formed XML file.
+1	shadedclient	697	patch has no errors when building and testing our client artifacts.
+1	javadoc	164	the patch passed
+1	findbugs	521	the patch passed
		_ Other Tests _
-1	unit	237	hadoop-hdds in the patch failed.
-1	unit	1068	hadoop-ozone in the patch failed.
+1	asflicense	43	The patch does not generate ASF License warnings.
		6192

Reason	Tests
Failed junit tests	hadoop.hdds.scm.container.placement.algorithms.TestSCMContainerPlacementRackAware
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-846/11/artifact/out/Dockerfile
GITHUB PR	#846
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux 6c293bf07f18 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `d203045`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/11/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/11/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/11/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/11/testReport/
Max. process+thread count	4878 (vs. ulimit of 5500)
modules	C: hadoop-hdds hadoop-hdds/client hadoop-hdds/common hadoop-hdds/config hadoop-hdds/container-service hadoop-ozone hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-846/11/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

…buted by Siddharth Wagle. (#846)

…buted by Siddharth Wagle. (apache#846)

+ address few review comments Author: Boris S <bshkolnik@linkedin.com> Author: Boris S <boryas@apache.org> Author: Boris Shkolnik <bshkolni@linkedin.com> Reviewers: xiliu <xiliu@linkedin.com> Closes apache#846 from sborya/isBroadcast1

…buted by Siddharth Wagle. (apache#846)

jiwq reviewed May 23, 2019

View reviewed changes

hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java Show resolved Hide resolved

bharatviswa504 reviewed May 23, 2019

View reviewed changes

...java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java Outdated Show resolved Hide resolved

jiwq reviewed May 30, 2019

View reviewed changes

swagle force-pushed the HDDS-1555 branch from f7add7d to 8fa963c Compare May 31, 2019 21:24

swagle force-pushed the HDDS-1555 branch from 8fa963c to d8c037f Compare June 4, 2019 19:35

swagle force-pushed the HDDS-1555 branch from d8c037f to 17fc16e Compare June 6, 2019 04:47

mukul1987 reviewed Jun 6, 2019

View reviewed changes

swagle force-pushed the HDDS-1555 branch from 17fc16e to f03358d Compare June 6, 2019 15:45

swagle mentioned this pull request Jun 6, 2019

HDDS-1441. Remove usage of getRetryFailureException. (swagle) #745

Closed

mukul1987 requested changes Jun 11, 2019

View reviewed changes

...ne/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisClient.java Show resolved Hide resolved

...java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java Show resolved Hide resolved

swagle force-pushed the HDDS-1555 branch from 76e1a43 to 38d48ad Compare June 11, 2019 17:42

mukul1987 approved these changes Jun 12, 2019

View reviewed changes

arp7 added the ozone label Jun 12, 2019

swagle force-pushed the HDDS-1555 branch from 38d48ad to d71cd51 Compare June 28, 2019 04:26

swagle added 5 commits June 28, 2019 08:55

HDDS-1555. Disable install snapshot for ContainerStateMachine.

e1f1a84

HDDS-1555. Remove redundant groupId from signature of notify.

ac07b98

HDDS-1555. Disable install snapshot for ContainerStateMachine.

68653ed

HDDS-1555. Update ratis.version to latest snapshot.

8e9b130

HDDS-1555. Fix issues discovered by ratis version update.

011cb71

swagle added 3 commits June 28, 2019 08:55

HDDS-1555. Checkstyle fix.

d5faf6e

HDDS-1555. Parameterized logging fixed.

994ef66

HDDS-1555. Update to latest ratis version and add purge gap config.

43c548a

swagle force-pushed the HDDS-1555 branch from d71cd51 to 43c548a Compare June 28, 2019 15:56

HDDS-1555. Config unit test fix.

29d3e93

mukul1987 requested changes Jun 29, 2019

View reviewed changes

HDDS-1555. Fixed review comments.

b28e3af

mukul1987 approved these changes Jun 29, 2019

View reviewed changes

asfgit pushed a commit that referenced this pull request Jul 1, 2019

HDDS-1555. Disable install snapshot for ContainerStateMachine. Contri…

9df6275

…buted by Siddharth Wagle. (#846)

bshashikant pushed a commit to bshashikant/hadoop that referenced this pull request Jul 10, 2019

HDDS-1555. Disable install snapshot for ContainerStateMachine. Contri…

4343424

…buted by Siddharth Wagle. (apache#846)

elek closed this Aug 21, 2019

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019

HDDS-1555. Disable install snapshot for ContainerStateMachine. Contri…

197f149

…buted by Siddharth Wagle. (apache#846)

HDDS-1555. Disable install snapshot for ContainerStateMachine. #846

HDDS-1555. Disable install snapshot for ContainerStateMachine. #846

Uh oh!

Conversation

swagle commented May 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hadoop-yetus commented May 23, 2019

Uh oh!

Uh oh!

Uh oh!

bshashikant commented May 30, 2019

Uh oh!

jiwq left a comment

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented May 31, 2019

Uh oh!

bshashikant commented Jun 4, 2019

Uh oh!

hadoop-yetus commented Jun 4, 2019

Uh oh!

hadoop-yetus commented Jun 6, 2019

Uh oh!

mukul1987 left a comment

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Jun 6, 2019

Uh oh!

hadoop-yetus commented Jun 6, 2019

Uh oh!

Uh oh!

Uh oh!

hadoop-yetus commented Jun 11, 2019

Uh oh!

mukul1987 left a comment

Choose a reason for hiding this comment

Uh oh!

hanishakoneru commented Jun 12, 2019

Uh oh!

hadoop-yetus commented Jun 28, 2019

Uh oh!

hadoop-yetus commented Jun 28, 2019

Uh oh!

swagle commented Jun 28, 2019

Uh oh!

hadoop-yetus commented Jun 29, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mukul1987 commented Jun 29, 2019

Uh oh!

hadoop-yetus commented Jun 29, 2019

Uh oh!

Uh oh!

swagle commented May 23, 2019 •

edited

Loading