-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-19790. Updating Minimum Required Maven Version For Hadoop Build #8214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anujmodi2021
wants to merge
8
commits into
apache:trunk
Choose a base branch
from
ABFSDriver:HADOOP-19790
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9
−3
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
951ac4b
Updating Min Req Maven Version
anujmodi2021 d0865fb
Min Req Maven 3.9.9
anujmodi2021 5c0f23d
Updating Building.txt
anujmodi2021 6283543
Updating Version to 3.9.11
anujmodi2021 b6da2e3
Removing Not necessary code
anujmodi2021 67a35a8
Merge branch 'trunk' into HADOOP-19790
anujmodi2021 53e42b4
mvnw incormporate
anujmodi2021 675da5e
Merge branch 'trunk' into HADOOP-19790
anujmodi2021 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a checksum/signature validation stage if we are putting in code for people to run, or at least recommend it.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steveloughran, if you look at the context, no installation does such verification. can we make the guide simple to match the context for now?
later we can consider Maven Wrapper https://maven.apache.org/tools/wrapper/, then
./mvnwwould automatically trigger the requested version of Maven downloading, which is a much simpler way. (my previous try was abandoned because I didn't figure out how to let Yetus invoke./mvnwinstead ofmvnunder$PATH, but it's simple if we keepmvnforYetusand add a./mvnwas an alternative for developers)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, if mvnw is listed as the install mechanism, it's a lot simpler to detail as it does the validation. Docs can just say "use an up to date version of maven; the mvnw command will download one and validate it before execution"