Skip to content

Conversation

@steveloughran
Copy link
Contributor

Updates the PR message as seen in the section below.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

AI Tooling

If an AI tool was used:

Copy link
Contributor

@cnauroth cnauroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that Spark has started asking for a "Generated-by" tag in the commit message, intended to capture both the tool used and the model version, e.g. apache/spark#53675. I don't know if this is a standardized tag, but do you think it would be helpful to handle it this way?

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 8m 23s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 23m 23s trunk passed
-1 ❌ mvnsite 6m 42s /branch-mvnsite-root.txt root in trunk failed.
+1 💚 shadedclient 44m 1s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 14m 23s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-1 ❌ mvnsite 3m 49s /patch-mvnsite-root.txt root in the patch failed.
+1 💚 shadedclient 17m 13s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ asflicense 0m 23s /results-asflicense.txt The patch generated 2 ASF License warnings.
86m 9s
Subsystem Report/Notes
Docker ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8165/1/artifact/out/Dockerfile
GITHUB PR #8165
Optional Tests dupname asflicense mvnsite codespell detsecrets markdownlint
uname Linux 78160ee2a541 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 8d8d5f2
Max. process+thread count 617 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8165/1/console
versions git=2.25.1 maven=3.9.11
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor Author

I don't know if this is a standardized tag, but do you think it would be helpful to handle it this way?

ASF want the tool listed; we can choose what to do. I've just stuck this one up as an initial one.
If you look @ the JIRA I was also thinking of having the .md files the various tools use to tell them

  • java standard with two spaces
  • tests with assertj asserts expected

work for someone else

Copy link
Contributor

@cnauroth cnauroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks!

@slfan1989
Copy link
Contributor

+1

Copy link
Contributor

@Hexiaoqiao Hexiaoqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1.

@steveloughran steveloughran merged commit b4b221c into apache:trunk Jan 6, 2026
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants