Skip to content

HADOOP-19731. Fix SpotBugs warnings introduced after SpotBugs version upgrade. #8053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
+561 −204
Open

HADOOP-19731. Fix SpotBugs warnings introduced after SpotBugs version upgrade. #8053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8611578
HADOOP-19731. Fix SpotBugs warnings introduced after SpotBugs version…
zhtttylz Oct 30, 2025
582a4f1
CI: trigger SpotBugs (no-op)
zhtttylz Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions dev-support/findbugs-exclude-global.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
<?xml version="1.0" encoding="UTF-8"?>
<FindBugsFilter>
<Match>
<Bug pattern="AT_NONATOMIC_64BIT_PRIMITIVE,
AT_NONATOMIC_OPERATIONS_ON_SHARED_VARIABLE,
AT_STALE_THREAD_WRITE_OF_PRIMITIVE"/>
</Match>
<Match>
<Bug pattern="CT_CONSTRUCTOR_THROW"/>
</Match>
<Match>
<Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2"/>
</Match>
<Match>
<Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR"/>
</Match>
<Match>
<Bug pattern="SING_SINGLETON_IMPLEMENTS_SERIALIZABLE"/>
</Match>
<Match>
<Bug pattern="NN_NAKED_NOTIFY"/>
</Match>
<Match>
<Bug pattern="MS_EXPOSE_REP"/>
</Match>
<Match>
<Bug pattern="HSM_HIDING_METHOD"/>
</Match>
<Match>
<Bug pattern="DMI_RANDOM_USED_ONLY_ONCE"/>
</Match>
<Match>
<Bug pattern="DCN_NULLPOINTER_EXCEPTION"/>
</Match>
<Match>
<Bug pattern="SSD_DO_NOT_USE_INSTANCE_LOCK_ON_SHARED_STATIC_DATA"/>
</Match>
<Match>
<Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
</Match>
<Match>
<Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
</Match>
<Match>
<Bug pattern="SS_SHOULD_BE_STATIC"/>
</Match>
<Match>
<Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
</Match>
<Match>
<Bug pattern="REFLC_REFLECTION_MAY_INCREASE_ACCESSIBILITY_OF_CLASS"/>
</Match>
<Match>
<Bug pattern="SING_SINGLETON_GETTER_NOT_SYNCHRONIZED"/>
</Match>
</FindBugsFilter>
8 changes: 6 additions & 2 deletions hadoop-cloud-storage-project/hadoop-cos/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,12 @@
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<xmlOutput>true</xmlOutput>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
<effort>Max</effort>
</configuration>
</plugin>
Expand Down
8 changes: 6 additions & 2 deletions hadoop-cloud-storage-project/hadoop-huaweicloud/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,12 @@
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<xmlOutput>true</xmlOutput>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
<effort>Max</effort>
</configuration>
</plugin>
Expand Down
8 changes: 6 additions & 2 deletions hadoop-cloud-storage-project/hadoop-tos/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,12 @@
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<xmlOutput>true</xmlOutput>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml
</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
<effort>Max</effort>
</configuration>
</plugin>
Expand Down
6 changes: 5 additions & 1 deletion hadoop-common-project/hadoop-auth/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,11 @@
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml</excludeFilterFile>
<excludeFilterFiles>
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml</excludeFilterFile>
<excludeFilterFile>${repo.root}/dev-support/findbugs-exclude-global.xml
</excludeFilterFile>
</excludeFilterFiles>
</configuration>
</plugin>
</plugins>
Expand Down
5 changes: 3 additions & 2 deletions ...adoop-auth/src/test/java/org/apache/hadoop/security/authentication/KerberosTestUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
/**
* Test helper class for Java Kerberos setup.
*/
// CI: trigger SpotBugs (no-op)
public class KerberosTestUtils {
private static String keytabFile = new File(System.getProperty("test.dir", "target"),
UUID.randomUUID().toString()).getAbsolutePath();
Expand Down Expand Up @@ -68,7 +69,7 @@ public KerberosConfiguration(String principal) {
public AppConfigurationEntry[] getAppConfigurationEntry(String name) {
Map<String, String> options = new HashMap<String, String>();
if (IBM_JAVA) {
options.put("useKeytab", KerberosTestUtils.getKeytabFile().startsWith("file://") ?
options.put("useKeytab", KerberosTestUtils.getKeytabFile().startsWith("file://") ?
KerberosTestUtils.getKeytabFile() : "file://" + KerberosTestUtils.getKeytabFile());
options.put("principal", principal);
options.put("refreshKrb5Config", "true");
Expand All @@ -83,7 +84,7 @@ public AppConfigurationEntry[] getAppConfigurationEntry(String name) {
options.put("renewTGT", "true");
options.put("refreshKrb5Config", "true");
options.put("isInitiator", "true");
}
}
String ticketCache = System.getenv("KRB5CCNAME");
if (ticketCache != null) {
if (IBM_JAVA) {
Expand Down
Loading