-
Notifications
You must be signed in to change notification settings - Fork 9.1k
YARN-11875. Fix build failure caused by color@5.0.2. #8016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
This was noted in YARN-11873, where Michael Smith highlighted that we can lock down dependencies in our yarn/npm builds. I believe we should do this -I never realised until now that we weren't getting a consistent build. Also, this has broken branch-3.4, so please do a PR there too. We probably need to backport everywhere else too. |
@steveloughran Thanks for helping review the code — I’ll backport this PR to branch-3.4. |
…ted by Shilun Fan * YARN-11875. Fix build failure caused by color@5.0.2. Reviewed-by: Steve Loughran <stevel@cloudera.com> Signed-off-by: Shilun Fan <slfan1989@apache.org>
#8016 has been pushed to the branch-3.4. |
llContributed by Shilun Fan * YARN-11875. Fix build failure caused by color@5.0.2. Reviewed-by: Steve Loughran <stevel@cloudera.com> Signed-off-by: Shilun Fan <slfan1989@apache.org>
llContributed by Shilun Fan * YARN-11875. Fix build failure caused by color@5.0.2. Reviewed-by: Steve Loughran <stevel@cloudera.com> Signed-off-by: Shilun Fan <slfan1989@apache.org>
…ted by Shilun Fan * YARN-11875. Fix build failure caused by color@5.0.2. Reviewed-by: Steve Loughran <stevel@cloudera.com> Signed-off-by: Shilun Fan <slfan1989@apache.org>
Description of PR
JIRA: YARN-11875. Fix build failure caused by color@5.0.2.
A build failure occurs in the Yarn UI module due to an incompatible dependency version of
color@5.0.2
, which requiresNode.js ≥ 18
. The current build environment usesNode.js 12.22.1
, resulting in the following error during dependency installation.The color package was pulled in as a transitive dependency from other modules (e.g., apidoc).
Version 5.0.2 introduced a strict Node.js engine requirement (≥18), which is incompatible with the current Node 12 environment
This resolves the build failure without requiring a Node.js upgrade.
How was this patch tested?
CI.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?