Skip to content

Conversation

slfan1989
Copy link
Contributor

@slfan1989 slfan1989 commented Oct 7, 2025

Description of PR

JIRA: YARN-11875. Fix build failure caused by color@5.0.2.

A build failure occurs in the Yarn UI module due to an incompatible dependency version of color@5.0.2, which requires Node.js ≥ 18. The current build environment uses Node.js 12.22.1, resulting in the following error during dependency installation.

error color@5.0.2: The engine "node" is incompatible with this module. Expected version ">=18". Got "12.22.1"
error Found incompatible module. 
  • Root Cause

The color package was pulled in as a transitive dependency from other modules (e.g., apidoc).
Version 5.0.2 introduced a strict Node.js engine requirement (≥18), which is incompatible with the current Node 12 environment

  • Fix
Manually pinned the dependency to a Node 12–compatible version:
"resolutions": {
  "color": "^3.1.3"
}

This resolves the build failure without requiring a Node.js upgrade.

How was this patch tested?

CI.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 14m 40s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 jsonlint 0m 0s jsonlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 shadedclient 39m 41s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shadedclient 33m 16s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 39s The patch does not generate ASF License warnings.
89m 57s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8016/1/artifact/out/Dockerfile
GITHUB PR #8016
Optional Tests dupname asflicense codespell detsecrets jsonlint
uname Linux 74663a648988 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / b56112c
Max. process+thread count 718 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8016/1/console
versions git=2.25.1 maven=3.9.11
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@steveloughran
Copy link
Contributor

This was noted in YARN-11873, where Michael Smith highlighted that we can lock down dependencies in our yarn/npm builds.

I believe we should do this -I never realised until now that we weren't getting a consistent build.

Also, this has broken branch-3.4, so please do a PR there too. We probably need to backport everywhere else too.

@slfan1989
Copy link
Contributor Author

This was noted in YARN-11873, where Michael Smith highlighted that we can lock down dependencies in our yarn/npm builds.

I believe we should do this -I never realised until now that we weren't getting a consistent build.

Also, this has broken branch-3.4, so please do a PR there too. We probably need to backport everywhere else too.

@steveloughran Thanks for helping review the code — I’ll backport this PR to branch-3.4.

@slfan1989 slfan1989 merged commit d9c3308 into apache:trunk Oct 8, 2025
4 checks passed
slfan1989 added a commit that referenced this pull request Oct 8, 2025
…ted by Shilun Fan

* YARN-11875. Fix build failure caused by color@5.0.2. 

Reviewed-by:  Steve Loughran <stevel@cloudera.com>
Signed-off-by: Shilun Fan <slfan1989@apache.org>
@slfan1989
Copy link
Contributor Author

#8016 has been pushed to the branch-3.4.

steveloughran pushed a commit that referenced this pull request Oct 8, 2025
llContributed by Shilun Fan

* YARN-11875. Fix build failure caused by color@5.0.2.

Reviewed-by:  Steve Loughran <stevel@cloudera.com>
Signed-off-by: Shilun Fan <slfan1989@apache.org>
asf-gitbox-commits pushed a commit that referenced this pull request Oct 8, 2025
llContributed by Shilun Fan

* YARN-11875. Fix build failure caused by color@5.0.2.

Reviewed-by:  Steve Loughran <stevel@cloudera.com>
Signed-off-by: Shilun Fan <slfan1989@apache.org>
asf-gitbox-commits pushed a commit that referenced this pull request Oct 8, 2025
…ted by Shilun Fan

* YARN-11875. Fix build failure caused by color@5.0.2.

Reviewed-by:  Steve Loughran <stevel@cloudera.com>
Signed-off-by: Shilun Fan <slfan1989@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants