-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part7. #7664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
c93f4cc
to
bbe019a
Compare
d659e76
to
d1f75ad
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
c27bbc3
to
e43f856
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
e43f856
to
a75b4d2
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
a75b4d2
to
9aad18d
Compare
@cnauroth @steveloughran @Hexiaoqiao Could you please review this PR? Thank you very much! This PR primarily involves changes to the |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @slfan1989 . I saw HADOOP-19550 before this one and merged #7646 . This one now has merge conflicts. Can you please take a look?
@cnauroth Thank you for your review and comments! I will try to resolve the conflict. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@cnauroth Could you please help review this PR again? Thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1,LGTM @slfan1989
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Hi @slfan1989 , There are some compile error of last report. Please check it first. Thanks. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +1. Thanks @slfan1989 for your works.
🎊 +1 overall
This message was automatically generated. |
@Hexiaoqiao @cnauroth This PR has passed the Yetus check. The existing Checkstyle issues were already present and will not be addressed in this update. I will merge this PR into the trunk branch to proceed with the JUnit 5 upgrade for the Azure and AWS modules. cc: @zhtttylz |
Description of PR
JIRA: HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part7.
How was this patch tested?
junit test & mvn clean test.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?