[WIP] HADOOP-15984. Update jersey from 1.19 to 2.x #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/wsrs/ParametersProvider.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
jojochuang
reviewed
Aug 8, 2019
jojochuang
requested changes
Aug 9, 2019
| @@ -34,7 +34,6 @@ log4j.additivity.kms-audit=false | |||
|
|
|||
| log4j.rootLogger=INFO, kms | |||
| log4j.logger.org.apache.hadoop=INFO | |||
| log4j.logger.com.sun.jersey.server.wadl.generators.WadlGeneratorJAXBGrammarGenerator=OFF | |||
There was a problem hiding this comment.
This is related to HADOOP-15686. If I get HADOOP-15686 in, we'll have to update here.
| @@ -25,7 +25,6 @@ log4j.appender.stdout.layout.ConversionPattern=%d{ISO8601} %-5p %c{1} - %m%n | |||
| log4j.rootLogger=INFO, stdout | |||
| log4j.logger.org.apache.hadoop.conf=ERROR | |||
| log4j.logger.org.apache.hadoop.crytpo.key.kms.server=ALL | |||
| log4j.logger.com.sun.jersey.server.wadl.generators.WadlGeneratorJAXBGrammarGenerator=OFF | |||
...dfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/UserProvider.java
Outdated
Show resolved
Hide resolved
aajisaka
force-pushed
the
HADOOP-15984-3
branch
from
04e43dc to
ce79f11
Compare
| Map<String, List<Param<?>>> map = new HashMap<String, List<Param<?>>>(); | ||
| Map<String, List<String>> queryString = | ||
| httpContext.getRequest().getQueryParameters(); | ||
|
|
|
💔 -1 overall
This message was automatically generated. |
| Map<String, List<Param<?>>> map = new HashMap<String, List<Param<?>>>(); | ||
| Map<String, List<String>> queryString = | ||
| httpContext.getRequest().getQueryParameters(); | ||
|
|
|
💔 -1 overall
This message was automatically generated. |
| Map<String, List<Param<?>>> map = new HashMap<String, List<Param<?>>>(); | ||
| Map<String, List<String>> queryString = | ||
| httpContext.getRequest().getQueryParameters(); | ||
|
|
|
💔 -1 overall
This message was automatically generated. |
hadoop-yetus
reviewed
Sep 3, 2019
| Map<String, List<Param<?>>> map = new HashMap<String, List<Param<?>>>(); | ||
| Map<String, List<String>> queryString = | ||
| httpContext.getRequest().getQueryParameters(); | ||
|
|
|
💔 -1 overall
This message was automatically generated. |
aajisaka
force-pushed
the
HADOOP-15984-3
branch
from
ce79f11 to
f4dc6cf
Compare
|
Now there is a problem: In Jersey 1.19, we set In Jersey 2.x, there is no parameter to disable parsing matrix parameters. Cc: @iwasakims |
hadoop-yetus
reviewed
Oct 8, 2019
| httpContext.getRequest().getQueryParameters(); | ||
| String str = ((MultivaluedMap<String, String>) queryString). | ||
| getFirst(driverParam); | ||
|
|
|
💔 -1 overall
This message was automatically generated. |
hadoop-yetus
reviewed
Oct 8, 2019
| httpContext.getRequest().getQueryParameters(); | ||
| String str = ((MultivaluedMap<String, String>) queryString). | ||
| getFirst(driverParam); | ||
|
|
|
💔 -1 overall
This message was automatically generated. |
|
Updated:
|
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
Minor fix to print the logical plan. Author: Srinivasulu Punuru <spunuru@linkedin.com> Reviewers: Aditya Toomula <atoomula@linkedin.com> Closes apache#763 from srinipunuru/print.1
|
@aajisaka qq. how do you get this to compile? |
|
@smengcl Now I cannot compile this. |
|
@aajisaka Hmm. Okay. I was just trying to run the HDFS tests to see which are broken by the upgrade. How am I supposed to check which ones are broken now that it won't compile? I see HDFS component is built. Somehow skip the YARN build and run the HDFS tests directly? |
|
@smengcl Yes. I ran HDFS tests without building YARN. |
aajisaka
force-pushed
the
HADOOP-15984-3
branch
from
e11e6b0 to
0d96a1d
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
aajisaka
force-pushed
the
HADOOP-15984-3
branch
from
15238fb to
7821526
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
May I know when can we expect this PR to be merged? We have some whitesource findings which we need to resolve. |
I'd like to merge this by the end of 2021Q1. |
|
💔 -1 overall
This message was automatically generated. |
|
Any way to help with this @aajisaka? |
|
@h-vetinari
Sorry, I don't think I can merge this by 2021Q1 because I'm busy. |
|
so we need this for jav 11? going to be traumatic downstream. |
|
I see many folks have asked for merging the PR, just wanted to know if anyone has cloned this PR to make more progress? If not, I can pick up from where we left off? |
|
This long standing issue has been completed by #7019 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/HADOOP-15984
TODO list