Skip to content

YARN-11810. Fix SQL script in SQLServer/FederationStateStoreTables.sql #7605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

p-szucs
Copy link
Contributor

@p-szucs p-szucs commented Apr 11, 2025

Change-Id: I5b2a4f6436b1d55984f0420321a62b6d0b4b087b

Description of PR

The SQLServer/FederationStateStoreTables.sql script contains duplicated create statements and SQL syntax errors which makes TestFederationSQLServerScriptAccuracy#checkSqlServerScriptAccuracy unit test fail. Details can be found in YARN-11810.

How was this patch tested?

Unit tests

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

Change-Id: I5b2a4f6436b1d55984f0420321a62b6d0b4b087b
@p-szucs p-szucs marked this pull request as ready for review April 11, 2025 13:45
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 21s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 shadedclient 24m 36s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shadedclient 19m 46s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 24s The patch does not generate ASF License warnings.
46m 25s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7605/1/artifact/out/Dockerfile
GITHUB PR #7605
Optional Tests dupname asflicense codespell detsecrets
uname Linux ddfd65da1b2d 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / d57d921
Max. process+thread count 553 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn U: hadoop-yarn-project/hadoop-yarn
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7605/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989
Copy link
Contributor

@p-szucs Thanks for the contribution! LGTM.

@slfan1989 slfan1989 merged commit 40c7000 into apache:trunk Apr 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants