-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HDFS-17641. Change badly distributed blocks metric protobuf requirement to optional #7274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17641. Change badly distributed blocks metric protobuf requirement to optional #7274
Conversation
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PrateekSane Thanks for the work! What testing was done to ensure backwards compatibility with 3.x? For example, did you confirm that the new code around GetFsECBlockGroupStatsRequestProto and GetFsReplicatedBlockStatsResponseProto can handle the case where the badly_distributed_blocks field does not exist?
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for walking back the backwards incompatible change @PrateekSane !
The build and yetus failures are for unrelated reasons to this patch. +1 from me.
…nt to optional (apache#7274) Note: This is a follow on pr from apache#7123 that walks back an incompatible change that was made.
Description of PR
Change from required to optional as not critically important and needed to be optional to allow backwards compatibility to 3.3.
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?