HDDS-1422. Exception during DataNode shutdown. Contributed by Arpit A… #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @arp7 Is my understanding correct or am I missing something here? |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
That is correct @bharatviswa504 . |
Contributor
|
Thank You @arp7 for the reply. |
Contributor
Author
|
This is to avoid spurious exception messages during DataNode shutdown. They were creating noise in the logs, especially when running MiniOzoneChaosCluster which frequently restarts nodes. |
bharatviswa504
approved these changes
Apr 11, 2019
Contributor
bharatviswa504
left a comment
bharatviswa504
left a comment
There was a problem hiding this comment.
Thank You @arp7 for the explanation.
+1 LGTM pending CI.
Contributor
Author
|
/retest |
Contributor
Author
|
Addressed issues flagged by CI, and rebased to current trunk. |
|
💔 -1 overall
This message was automatically generated. |
…garwal. Change-Id: I6db6bdd19839a45e5341ed7e745cd38f68af8378
Contributor
Author
|
Fix UT failures caused by previous commit. |
Contributor
Author
|
/retest |
bharatviswa504
approved these changes
May 17, 2019
Contributor
bharatviswa504
left a comment
bharatviswa504
left a comment
There was a problem hiding this comment.
+1 LGTM, An extra file is added which is not required can be taken care during the commit.
bharatviswa504
approved these changes
May 17, 2019
Contributor
|
+1, LGTM. Thanks for the patch, and thanks for the review. @bharatviswa504 |
ajayydv
pushed a commit
to ajayydv/hadoop
that referenced
this pull request
May 20, 2019
apache#725) * HDDS-1422. Exception during DataNode shutdown. Contributed by Arpit Agarwal. Change-Id: I6db6bdd19839a45e5341ed7e745cd38f68af8378 * Suppress spurious findbugs warning. * Remove log file that got committed in error
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
1. Made public methods in ApplicationDescriptorImpl non-final for mocking. 2. Updated CachedTableDescriptor public method return types to include type parameters. 3. Changed next release version to 1.0.0 4. Made KafkaSystemAdmin#toKafkaSpec public. Author: Prateek Maheshwari <pmaheshwari@apache.org> Reviewers: Shanthoosh Venkatraman <svenkatr@linkedin.com> Closes apache#725 from prateekm/minor-fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…garwal.
Change-Id: I981fbd087baca80cc6b4ff58e91e63dcd9726c13