-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17642. Add target node list, exclude source node list, and exclude target node list parameters to balancer #7127
base: trunk
Are you sure you want to change the base?
Conversation
…y moves blocks to those nodes
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments then LGTM for adding the parameters. I assume this needs a separate commit for the functionality itself. Is OSS okay with merging this now or should we wait until we have both commits?
...-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
Outdated
Show resolved
Hide resolved
...-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
Outdated
Show resolved
Hide resolved
…, clarified when processing excluded source/target lists
...-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
Outdated
Show resolved
Hide resolved
…ludeSource or target & excludeTarget options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I don't have approval permissions
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@aQuigs This PR includes functionality - the change in private long init(List reports) method is where we filter out the allowed/excluded nodes from being targets or or sources |
Ah, got it, I overlooked that piece. LGTM - thanks |
Description of PR
Adds target parameter to balancer which will allow only datanodes in the provided list of hosts to be picked as a target node.
Adds excludeSource and excludeTarget parameters to balancer which will exclude specified hosts from being picked as a source or target node.
How was this patch tested?
mvn install -DskipTests
add unit test for parameter check in balancer
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?