-
Notifications
You must be signed in to change notification settings - Fork 9.1k
YARN-11733. Fix the order of updating CPU controls with cgroup v1 #7069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I09429c878c124be9d6a09e8f027ab89d34606f2f
Change-Id: I28b4a73fa7ec56ef8af413c5d76ceee8b2e9d7e4
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Thanks @p-szucs for the patch, LGTM. Merging to trunk. |
susheelgupta7
pushed a commit
to susheel-gupta/hadoop
that referenced
this pull request
Apr 30, 2025
…cgroup v1 (apache#7069) (cherry picked from commit b078f86) Change-Id: I334bc1dd2707b2b3432c768677eeab5c2d658fc4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I09429c878c124be9d6a09e8f027ab89d34606f2f
Description of PR
With using cgroup v1, cpu.cfs_period_us control gets the default value of 100 000 when a new cgroup is created, but when YARN calculates the limit, it uses 1 000 000 for that. Because of this we need to update cpu.cfs_period_us before cpu.cfs_quota_us, to keep the ratio between the two values and not to exceed the limit defined at parent level.
How was this patch tested?
Unit tests, tested the change on a cluster
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?