HDFS-17611. Move all DistCp execution logic to execute() #7025

kokon191 · 2024-09-03T07:13:37Z

Description of PR

Many code flows create a DistCp instance and call the public method execute() to get the Job object for better control over the distcp job but some logics are only called by the run() method. Should move these lines over to execute().

How was this patch tested?

Trivial code change

hadoop-yetus · 2024-09-03T09:43:42Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 29s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	44m 35s		trunk passed
+1 💚	compile	0m 33s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	compile	0m 30s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	checkstyle	0m 30s		trunk passed
+1 💚	mvnsite	0m 35s		trunk passed
+1 💚	javadoc	0m 34s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	0m 30s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	spotbugs	0m 51s		trunk passed
+1 💚	shadedclient	33m 49s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 23s		the patch passed
+1 💚	compile	0m 23s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javac	0m 23s		the patch passed
+1 💚	compile	0m 21s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	javac	0m 21s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 18s	/results-checkstyle-hadoop-tools_hadoop-distcp.txt	hadoop-tools/hadoop-distcp: The patch generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13)
+1 💚	mvnsite	0m 24s		the patch passed
+1 💚	javadoc	0m 22s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	0m 20s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	spotbugs	0m 51s		the patch passed
+1 💚	shadedclient	33m 55s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	25m 59s	/patch-unit-hadoop-tools_hadoop-distcp.txt	hadoop-distcp in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		148m 51s

Reason	Tests
Failed junit tests	hadoop.tools.contract.TestHDFSContractDistCp
	hadoop.tools.TestExternalCall
	hadoop.tools.contract.TestLocalContractDistCp

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/1/artifact/out/Dockerfile
GITHUB PR	#7025
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 95f198158801 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `d6f8168`
Default Java	Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/1/testReport/
Max. process+thread count	699 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

steveloughran

this going to cause any problems in use by apps like Hive?

kokon191 · 2024-09-04T02:51:48Z

Hi @steveloughran , thanks for the review. I think it won't affect apps that use distcp like Hive since the code flow from run() stays the same, and the code flow from execute() is changed to add some related configs. In Hive's case in particular, HIVE-13704 changed Hive from using execute() to run() for the same reason of some configs not being set by execute() (which is moved to execute() by this PR).

kokon191 · 2024-09-04T03:35:06Z

Actually, upon further checks + during UT fixing, it does seem like the default behaviour of execute() is impacted so I moved the default behaviour back to no extra configs for execute() but still keep run() the same.

hadoop-yetus · 2024-09-04T06:04:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 29s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	45m 5s		trunk passed
+1 💚	compile	0m 32s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	compile	0m 30s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	checkstyle	0m 30s		trunk passed
+1 💚	mvnsite	0m 35s		trunk passed
+1 💚	javadoc	0m 35s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	0m 31s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	spotbugs	0m 53s		trunk passed
+1 💚	shadedclient	34m 10s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 23s		the patch passed
+1 💚	compile	0m 23s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javac	0m 23s		the patch passed
+1 💚	compile	0m 22s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	javac	0m 22s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 17s		the patch passed
+1 💚	mvnsite	0m 25s		the patch passed
-1 ❌	javadoc	0m 21s	/results-javadoc-javadoc-hadoop-tools_hadoop-distcp-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt	hadoop-tools_hadoop-distcp-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 generated 1 new + 37 unchanged - 0 fixed = 38 total (was 37)
-1 ❌	javadoc	0m 20s	/results-javadoc-javadoc-hadoop-tools_hadoop-distcp-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt	hadoop-tools_hadoop-distcp-jdkPrivateBuild-1.8.0_422-8u422-b05-1~~20.04-b05 with JDK Private Build-1.8.0_422-8u422-b05-1~~20.04-b05 generated 1 new + 37 unchanged - 0 fixed = 38 total (was 37)
+1 💚	spotbugs	0m 50s		the patch passed
+1 💚	shadedclient	33m 21s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	24m 48s		hadoop-distcp in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		147m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/2/artifact/out/Dockerfile
GITHUB PR	#7025
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 63ea3b65f04d 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `ce39039`
Default Java	Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/2/testReport/
Max. process+thread count	642 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

steveloughran · 2024-09-04T10:53:02Z

I was worried about the "Trivial code change" comment. never is, sadly.

hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java

hadoop-yetus · 2024-09-04T13:36:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 31s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	47m 1s		trunk passed
+1 💚	compile	0m 32s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	compile	0m 30s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	checkstyle	0m 30s		trunk passed
+1 💚	mvnsite	0m 35s		trunk passed
+1 💚	javadoc	0m 35s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	0m 29s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	spotbugs	0m 52s		trunk passed
+1 💚	shadedclient	34m 33s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
-1 ❌	mvninstall	0m 21s	/patch-mvninstall-hadoop-tools_hadoop-distcp.txt	hadoop-distcp in the patch failed.
-1 ❌	compile	0m 23s	/patch-compile-hadoop-tools_hadoop-distcp-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt	hadoop-distcp in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.
-1 ❌	javac	0m 23s	/patch-compile-hadoop-tools_hadoop-distcp-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt	hadoop-distcp in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.
-1 ❌	compile	0m 21s	/patch-compile-hadoop-tools_hadoop-distcp-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt	hadoop-distcp in the patch failed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05.
-1 ❌	javac	0m 21s	/patch-compile-hadoop-tools_hadoop-distcp-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt	hadoop-distcp in the patch failed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05.
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 17s		the patch passed
-1 ❌	mvnsite	0m 22s	/patch-mvnsite-hadoop-tools_hadoop-distcp.txt	hadoop-distcp in the patch failed.
-1 ❌	javadoc	0m 22s	/patch-javadoc-hadoop-tools_hadoop-distcp-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt	hadoop-distcp in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.
-1 ❌	javadoc	0m 21s	/patch-javadoc-hadoop-tools_hadoop-distcp-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt	hadoop-distcp in the patch failed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05.
-1 ❌	spotbugs	0m 20s	/patch-spotbugs-hadoop-tools_hadoop-distcp.txt	hadoop-distcp in the patch failed.
+1 💚	shadedclient	36m 57s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	0m 25s	/patch-unit-hadoop-tools_hadoop-distcp.txt	hadoop-distcp in the patch failed.
+1 💚	asflicense	0m 38s		The patch does not generate ASF License warnings.
		126m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/3/artifact/out/Dockerfile
GITHUB PR	#7025
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 3bde0aa611ea 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `72adb72`
Default Java	Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/3/testReport/
Max. process+thread count	658 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-09-05T05:04:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 29s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
-1 ❌	mvninstall	45m 31s	/branch-mvninstall-root.txt	root in trunk failed.
+1 💚	compile	0m 30s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	compile	0m 28s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	checkstyle	0m 28s		trunk passed
+1 💚	mvnsite	0m 35s		trunk passed
+1 💚	javadoc	0m 35s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	0m 29s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	spotbugs	0m 58s		trunk passed
-1 ❌	shadedclient	41m 28s		branch has errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 24s		the patch passed
+1 💚	compile	0m 23s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javac	0m 23s		the patch passed
+1 💚	compile	0m 21s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	javac	0m 21s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 16s		the patch passed
+1 💚	mvnsite	0m 24s		the patch passed
-1 ❌	javadoc	0m 21s	/patch-javadoc-hadoop-tools_hadoop-distcp-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt	hadoop-distcp in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.
-1 ❌	javadoc	0m 20s	/patch-javadoc-hadoop-tools_hadoop-distcp-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt	hadoop-distcp in the patch failed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05.
+1 💚	spotbugs	0m 50s		the patch passed
-1 ❌	shadedclient	34m 44s		patch has errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	25m 14s		hadoop-distcp in the patch passed.
+1 💚	asflicense	0m 38s		The patch does not generate ASF License warnings.
		157m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/4/artifact/out/Dockerfile
GITHUB PR	#7025
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 65ab10eea76f 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `42800f5`
Default Java	Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/4/testReport/
Max. process+thread count	552 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

haiyang1987 · 2024-09-10T07:55:21Z

Thanks @kokon191 for your work, please fix javadoc issue, thanks~

kokon191 · 2024-09-10T08:46:20Z

Thanks @haiyang1987 for taking a look. ~~It seems to be a CI issue since all javadoc errors are unrelated to the changes.~~ Nvm I found an issue, fixed.

hadoop-yetus · 2024-09-10T11:42:36Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	12m 15s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	43m 59s		trunk passed
+1 💚	compile	0m 31s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	compile	0m 30s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	checkstyle	0m 30s		trunk passed
+1 💚	mvnsite	0m 34s		trunk passed
+1 💚	javadoc	0m 36s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	0m 29s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	spotbugs	0m 54s		trunk passed
+1 💚	shadedclient	35m 1s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 23s		the patch passed
+1 💚	compile	0m 22s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javac	0m 22s		the patch passed
+1 💚	compile	0m 21s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	javac	0m 21s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 18s		the patch passed
+1 💚	mvnsite	0m 24s		the patch passed
-1 ❌	javadoc	0m 22s	/results-javadoc-javadoc-hadoop-tools_hadoop-distcp-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt	hadoop-tools_hadoop-distcp-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37)
-1 ❌	javadoc	0m 20s	/results-javadoc-javadoc-hadoop-tools_hadoop-distcp-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt	hadoop-tools_hadoop-distcp-jdkPrivateBuild-1.8.0_422-8u422-b05-1~~20.04-b05 with JDK Private Build-1.8.0_422-8u422-b05-1~~20.04-b05 generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37)
+1 💚	spotbugs	0m 50s		the patch passed
+1 💚	shadedclient	34m 29s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	24m 36s		hadoop-distcp in the patch passed.
+1 💚	asflicense	0m 40s		The patch does not generate ASF License warnings.
		160m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/5/artifact/out/Dockerfile
GITHUB PR	#7025
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux a56324e1fd92 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `460475c`
Default Java	Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/5/testReport/
Max. process+thread count	699 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/5/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-09-10T16:36:48Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	18m 5s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	50m 47s		trunk passed
+1 💚	compile	0m 31s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	compile	0m 28s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	checkstyle	0m 29s		trunk passed
+1 💚	mvnsite	0m 33s		trunk passed
+1 💚	javadoc	0m 34s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	0m 27s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	spotbugs	0m 50s		trunk passed
+1 💚	shadedclient	40m 39s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 23s		the patch passed
+1 💚	compile	0m 22s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javac	0m 22s		the patch passed
+1 💚	compile	0m 21s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	javac	0m 21s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 17s		the patch passed
+1 💚	mvnsite	0m 23s		the patch passed
-1 ❌	javadoc	0m 21s	/results-javadoc-javadoc-hadoop-tools_hadoop-distcp-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt	hadoop-tools_hadoop-distcp-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 generated 1 new + 37 unchanged - 0 fixed = 38 total (was 37)
-1 ❌	javadoc	0m 19s	/results-javadoc-javadoc-hadoop-tools_hadoop-distcp-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt	hadoop-tools_hadoop-distcp-jdkPrivateBuild-1.8.0_422-8u422-b05-1~~20.04-b05 with JDK Private Build-1.8.0_422-8u422-b05-1~~20.04-b05 generated 1 new + 37 unchanged - 0 fixed = 38 total (was 37)
+1 💚	spotbugs	0m 50s		the patch passed
+1 💚	shadedclient	39m 33s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	25m 20s		hadoop-distcp in the patch passed.
+1 💚	asflicense	0m 37s		The patch does not generate ASF License warnings.
		183m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/6/artifact/out/Dockerfile
GITHUB PR	#7025
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 3ca0268a8baa 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `3cfae63`
Default Java	Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/6/testReport/
Max. process+thread count	585 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/6/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

steveloughran

still got that javadoc. i know, it's a losing battle..

hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java

hadoop-yetus · 2024-09-10T22:11:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	45m 48s		trunk passed
+1 💚	compile	0m 32s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	compile	0m 30s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	checkstyle	0m 29s		trunk passed
+1 💚	mvnsite	0m 36s		trunk passed
+1 💚	javadoc	0m 36s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	0m 30s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	spotbugs	0m 52s		trunk passed
+1 💚	shadedclient	34m 41s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 24s		the patch passed
+1 💚	compile	0m 23s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javac	0m 23s		the patch passed
+1 💚	compile	0m 20s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	javac	0m 20s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 17s		the patch passed
+1 💚	mvnsite	0m 24s		the patch passed
+1 💚	javadoc	0m 21s		hadoop-tools_hadoop-distcp-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 generated 0 new + 36 unchanged - 1 fixed = 36 total (was 37)
+1 💚	javadoc	0m 20s		hadoop-tools_hadoop-distcp-jdkPrivateBuild-1.8.0_422-8u422-b05-1~~20.04-b05 with JDK Private Build-1.8.0_422-8u422-b05-1~~20.04-b05 generated 0 new + 36 unchanged - 1 fixed = 36 total (was 37)
+1 💚	spotbugs	0m 50s		the patch passed
+1 💚	shadedclient	34m 36s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	24m 53s		hadoop-distcp in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		150m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/7/artifact/out/Dockerfile
GITHUB PR	#7025
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux b3a142ad3a82 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `bb03ed1`
Default Java	Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/7/testReport/
Max. process+thread count	675 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7025/7/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

haiyang1987

LGTM +1

haiyang1987 · 2024-09-23T02:38:57Z

Committed to trunk. Thanks @kokon191 for your works. And @steveloughran @ferhui for your reviews.

…)" This reverts commit ff75aa5.

…)" (#7059) This reverts commit ff75aa5.

haiyang1987 · 2024-09-23T02:47:20Z

Hi @kokon191 this PR should be move to hadoop common. thanks~

HDFS-17611. Move all DistCp execution logic to execute()

d6f8168

github-actions bot added DistCp trunk TOOLS labels Sep 3, 2024

steveloughran reviewed Sep 3, 2024

View reviewed changes

HDFS-17611. Fix unit tests

ce39039

steveloughran requested changes Sep 4, 2024

View reviewed changes

HDFS-17611. Change according to comments

72adb72

HDFS-17611. Fix compilation error

42800f5

ferhui approved these changes Sep 10, 2024

View reviewed changes

HDFS-17611. Fix javadocs error

460475c

HDFS-17611. Fix javadocs error

3cfae63

steveloughran requested changes Sep 10, 2024

View reviewed changes

hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java Outdated Show resolved Hide resolved

HDFS-17611. Fix javadocs error

bb03ed1

haiyang1987 approved these changes Sep 11, 2024

View reviewed changes

haiyang1987 merged commit ff75aa5 into apache:trunk Sep 23, 2024
4 checks passed

haiyang1987 added a commit that referenced this pull request Sep 23, 2024

Revert "HDFS-17611. Move all DistCp execution logic to execute() (#7025…

e1b4f59

…)" This reverts commit ff75aa5.

haiyang1987 mentioned this pull request Sep 23, 2024

Revert "HDFS-17611. Move all DistCp execution logic to execute()" #7059

Merged

haiyang1987 added a commit that referenced this pull request Sep 23, 2024

Revert "HDFS-17611. Move all DistCp execution logic to execute() (#7025…

81faae6

…)" (#7059) This reverts commit ff75aa5.

kokon191 mentioned this pull request Sep 23, 2024

HADOOP-19283. Move all DistCp execution logic to execute() #7060

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-17611. Move all DistCp execution logic to execute() #7025

HDFS-17611. Move all DistCp execution logic to execute() #7025

kokon191 commented Sep 3, 2024

hadoop-yetus commented Sep 3, 2024

steveloughran left a comment

kokon191 commented Sep 4, 2024

kokon191 commented Sep 4, 2024

hadoop-yetus commented Sep 4, 2024

steveloughran commented Sep 4, 2024

hadoop-yetus commented Sep 4, 2024

hadoop-yetus commented Sep 5, 2024

haiyang1987 commented Sep 10, 2024

kokon191 commented Sep 10, 2024 •

edited

Loading

hadoop-yetus commented Sep 10, 2024

hadoop-yetus commented Sep 10, 2024

steveloughran left a comment

hadoop-yetus commented Sep 10, 2024

haiyang1987 left a comment

haiyang1987 commented Sep 23, 2024

haiyang1987 commented Sep 23, 2024

HDFS-17611. Move all DistCp execution logic to execute() #7025

HDFS-17611. Move all DistCp execution logic to execute() #7025

Conversation

kokon191 commented Sep 3, 2024

Description of PR

How was this patch tested?

hadoop-yetus commented Sep 3, 2024

steveloughran left a comment

Choose a reason for hiding this comment

kokon191 commented Sep 4, 2024

kokon191 commented Sep 4, 2024

hadoop-yetus commented Sep 4, 2024

steveloughran commented Sep 4, 2024

hadoop-yetus commented Sep 4, 2024

hadoop-yetus commented Sep 5, 2024

haiyang1987 commented Sep 10, 2024

kokon191 commented Sep 10, 2024 • edited Loading

hadoop-yetus commented Sep 10, 2024

hadoop-yetus commented Sep 10, 2024

steveloughran left a comment

Choose a reason for hiding this comment

hadoop-yetus commented Sep 10, 2024

haiyang1987 left a comment

Choose a reason for hiding this comment

haiyang1987 commented Sep 23, 2024

haiyang1987 commented Sep 23, 2024

kokon191 commented Sep 10, 2024 •

edited

Loading