HDFS-17602. RBF: Fix mount point with SPACE order can not find the available namespace. #6991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
KeeProMise
reviewed
Sep 3, 2024
| @@ -118,6 +121,20 @@ protected String chooseFirstNamespace(String path, PathLocation loc) { | |||
| getSubclusterMapping(); | |||
| List<SubclusterAvailableSpace> subclusterList = new LinkedList<>( | |||
| subclusterInfo.values()); | |||
|
|
|||
| if (loc != null && loc.getDestinations() != null) { | |||
There was a problem hiding this comment.
Hi, @wzk784533 I think this modification is good, but I want to consult under what circumstances this loc or loc.getDestinations() would be null.
KeeProMise
reviewed
Sep 3, 2024
Comment on lines
126
to
136
| Set<String> locSet = new HashSet<String>(); | ||
| for (RemoteLocation dest : loc.getDestinations()) { | ||
| locSet.add(dest.getNameserviceId()); | ||
| } | ||
| List<SubclusterAvailableSpace> filteredSubclusterList = new LinkedList<>(); | ||
| for (SubclusterAvailableSpace cluster : subclusterList) { | ||
| if (locSet.contains(cluster.getNameserviceId())) { | ||
| filteredSubclusterList.add(cluster); | ||
| } | ||
| } | ||
| subclusterList = filteredSubclusterList; |
There was a problem hiding this comment.
You can change the code indentation.
There was a problem hiding this comment.
Ok, I will fix it later
|
Hi, @wzk784533 For the failure of test4tests, you need to add a UT |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
…ailable namespace, it will choose an irrelevant namespace
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@KeeProMise Please review this pull request, thanks |
|
@wzk784533 Hi, thanks for you contribution, LGTM, @Hexiaoqiao @goiri If you have time, please help to take a look. |
KeeProMise
approved these changes
Dec 10, 2024
|
@Hexiaoqiao @goiri Please review this pull request, thanks |
|
@KeeProMise Could you please merge this pull request, or is there anything else I shoud do please let me know |
1 similar comment
|
@KeeProMise Could you please merge this pull request, or is there anything else I shoud do please let me know |
Hi, @wzk784533 thanks for your contribution, LGTM, but I don't have the permission to merge the trunk branch. |
Hexiaoqiao
changed the title
Hexiaoqiao
approved these changes
Jan 6, 2025
|
Committed to trunk. Thanks @wzk784533 and @KeeProMise . |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HDFS-17602. RBF mount point with SPACE order can not find the most available namespace, it will choose an irrelevant namespace
How was this patch tested?
I have it test in our own clusters
For code changes:
I compare the namespaces in the StateStore and the mount point, and choose only the namespaces which are set in the mount point.