Skip to content

Fix so dfs.client.failover.max.attempts is respected correctly #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Fix so dfs.client.failover.max.attempts is respected correctly #699

wants to merge 1 commit into from
+1 −1

Conversation

jbarefoot
Copy link

Without this change, you would get incorrect behavior in that you would always have to set dfs.client.failover.max.attempts to be +1 greater to have the desired behavior, e.g. if you want it to attempt failover exactly once, you would have to set dfs.client.failover.max.attempts=2.

Without this change, if you set dfs.client.failover.max.attempts=1, to attempt to failover just once time, instead it wouldn't try at all, and you see this log message:

org.apache.hadoop.io.retry.RetryInvocationHandler - Exception while invoking class org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getFileInfo over hadoop-node-01.docker.infra.atscale.com/127.0.0.21:8020. Not retrying because failovers (1) exceeded maximum allowed (1)

Note that the non-failover retries just below this change is correct.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 26 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1027 trunk passed
+1 compile 979 trunk passed
+1 checkstyle 46 trunk passed
+1 mvnsite 72 trunk passed
+1 shadedclient 753 branch has no errors when building and testing our client artifacts.
+1 findbugs 95 trunk passed
+1 javadoc 55 trunk passed
_ Patch Compile Tests _
+1 mvninstall 43 the patch passed
+1 compile 936 the patch passed
+1 javac 936 the patch passed
+1 checkstyle 52 the patch passed
+1 mvnsite 77 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 655 patch has no errors when building and testing our client artifacts.
+1 findbugs 110 the patch passed
+1 javadoc 60 the patch passed
_ Other Tests _
-1 unit 489 hadoop-common in the patch failed.
+1 asflicense 45 The patch does not generate ASF License warnings.
5573
Reason Tests
Failed junit tests hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider
hadoop.ha.TestZKFailoverController
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/1/artifact/out/Dockerfile
GITHUB PR #699
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 6c32d6f96f27 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / d2141ef
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-699/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-699/1/testReport/
Max. process+thread count 1463 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-699/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 34 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1025 trunk passed
+1 compile 1026 trunk passed
+1 checkstyle 44 trunk passed
+1 mvnsite 81 trunk passed
+1 shadedclient 760 branch has no errors when building and testing our client artifacts.
+1 javadoc 59 trunk passed
0 spotbugs 116 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 115 trunk passed
_ Patch Compile Tests _
+1 mvninstall 45 the patch passed
+1 compile 1082 the patch passed
+1 javac 1082 the patch passed
+1 checkstyle 39 the patch passed
+1 mvnsite 69 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 606 patch has no errors when building and testing our client artifacts.
+1 javadoc 51 the patch passed
+1 findbugs 131 the patch passed
_ Other Tests _
-1 unit 509 hadoop-common in the patch failed.
+1 asflicense 40 The patch does not generate ASF License warnings.
5758
Reason Tests
Failed junit tests hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider
Subsystem Report/Notes
Docker Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/2/artifact/out/Dockerfile
GITHUB PR #699
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 3f2c41df6486 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / cd967c7
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-699/2/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-699/2/testReport/
Max. process+thread count 1507 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-699/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 43 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1058 trunk passed
+1 compile 1125 trunk passed
+1 checkstyle 40 trunk passed
+1 mvnsite 75 trunk passed
+1 shadedclient 796 branch has no errors when building and testing our client artifacts.
+1 javadoc 61 trunk passed
0 spotbugs 123 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 122 trunk passed
_ Patch Compile Tests _
+1 mvninstall 50 the patch passed
+1 compile 1097 the patch passed
+1 javac 1097 the patch passed
+1 checkstyle 38 the patch passed
+1 mvnsite 72 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 629 patch has no errors when building and testing our client artifacts.
+1 javadoc 60 the patch passed
+1 findbugs 131 the patch passed
_ Other Tests _
-1 unit 539 hadoop-common in the patch failed.
+1 asflicense 44 The patch does not generate ASF License warnings.
6032
Reason Tests
Failed junit tests hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/3/artifact/out/Dockerfile
GITHUB PR #699
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 8280560c21e0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / c0a0c35
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-699/3/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-699/3/testReport/
Max. process+thread count 1446 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-699/3/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 80 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1222 trunk passed
+1 compile 1160 trunk passed
+1 checkstyle 44 trunk passed
+1 mvnsite 81 trunk passed
+1 shadedclient 885 branch has no errors when building and testing our client artifacts.
+1 javadoc 63 trunk passed
0 spotbugs 128 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 126 trunk passed
_ Patch Compile Tests _
+1 mvninstall 51 the patch passed
+1 compile 1113 the patch passed
+1 javac 1113 the patch passed
+1 checkstyle 45 the patch passed
+1 mvnsite 76 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 757 patch has no errors when building and testing our client artifacts.
+1 javadoc 68 the patch passed
+1 findbugs 148 the patch passed
_ Other Tests _
-1 unit 548 hadoop-common in the patch failed.
+1 asflicense 48 The patch does not generate ASF License warnings.
6584
Reason Tests
Failed junit tests hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/4/artifact/out/Dockerfile
GITHUB PR #699
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux dbf5908f2fcd 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / e20b195
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-699/4/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-699/4/testReport/
Max. process+thread count 1345 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-699/4/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 77 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1226 trunk passed
+1 compile 1122 trunk passed
+1 checkstyle 48 trunk passed
+1 mvnsite 89 trunk passed
+1 shadedclient 940 branch has no errors when building and testing our client artifacts.
+1 javadoc 66 trunk passed
0 spotbugs 133 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 131 trunk passed
_ Patch Compile Tests _
+1 mvninstall 48 the patch passed
+1 compile 1067 the patch passed
+1 javac 1067 the patch passed
+1 checkstyle 49 the patch passed
+1 mvnsite 86 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 743 patch has no errors when building and testing our client artifacts.
+1 javadoc 63 the patch passed
+1 findbugs 131 the patch passed
_ Other Tests _
-1 unit 526 hadoop-common in the patch failed.
+1 asflicense 41 The patch does not generate ASF License warnings.
6507
Reason Tests
Failed junit tests hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/5/artifact/out/Dockerfile
GITHUB PR #699
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 4391f1b04cdf 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 70b4617
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-699/5/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-699/5/testReport/
Max. process+thread count 1713 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-699/5/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@jojochuang
Copy link
Contributor

Is there a jira filed for this?

@jojochuang
Copy link
Contributor

Please follow this doc to file a jira and contribute https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
Thanks!

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 42 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1090 trunk passed
+1 compile 1192 trunk passed
+1 checkstyle 42 trunk passed
+1 mvnsite 78 trunk passed
+1 shadedclient 756 branch has no errors when building and testing our client artifacts.
+1 javadoc 61 trunk passed
0 spotbugs 118 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 116 trunk passed
_ Patch Compile Tests _
+1 mvninstall 46 the patch passed
+1 compile 1061 the patch passed
+1 javac 1061 the patch passed
+1 checkstyle 36 the patch passed
+1 mvnsite 72 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 650 patch has no errors when building and testing our client artifacts.
+1 javadoc 63 the patch passed
+1 findbugs 122 the patch passed
_ Other Tests _
-1 unit 527 hadoop-common in the patch failed.
+1 asflicense 39 The patch does not generate ASF License warnings.
6044
Reason Tests
Failed junit tests hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider
hadoop.util.TestReadWriteDiskValidator
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/6/artifact/out/Dockerfile
GITHUB PR #699
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 1ac925886d57 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 397a563
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-699/6/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-699/6/testReport/
Max. process+thread count 1424 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-699/6/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 86 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1276 trunk passed
+1 compile 1071 trunk passed
+1 checkstyle 42 trunk passed
+1 mvnsite 80 trunk passed
+1 shadedclient 844 branch has no errors when building and testing our client artifacts.
+1 javadoc 66 trunk passed
0 spotbugs 124 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 122 trunk passed
_ Patch Compile Tests _
+1 mvninstall 49 the patch passed
+1 compile 1114 the patch passed
+1 javac 1114 the patch passed
+1 checkstyle 48 the patch passed
+1 mvnsite 89 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 750 patch has no errors when building and testing our client artifacts.
+1 javadoc 66 the patch passed
+1 findbugs 146 the patch passed
_ Other Tests _
-1 unit 556 hadoop-common in the patch failed.
+1 asflicense 42 The patch does not generate ASF License warnings.
6516
Reason Tests
Failed junit tests hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/7/artifact/out/Dockerfile
GITHUB PR #699
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 2360f0c08d62 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / e356e4f
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-699/7/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-699/7/testReport/
Max. process+thread count 1345 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-699/7/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 44 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1050 trunk passed
+1 compile 1143 trunk passed
+1 checkstyle 39 trunk passed
+1 mvnsite 70 trunk passed
+1 shadedclient 739 branch has no errors when building and testing our client artifacts.
+1 javadoc 56 trunk passed
0 spotbugs 110 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 107 trunk passed
_ Patch Compile Tests _
+1 mvninstall 43 the patch passed
+1 compile 1027 the patch passed
+1 javac 1027 the patch passed
+1 checkstyle 37 the patch passed
+1 mvnsite 66 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 646 patch has no errors when building and testing our client artifacts.
+1 javadoc 57 the patch passed
+1 findbugs 124 the patch passed
_ Other Tests _
-1 unit 484 hadoop-common in the patch failed.
+1 asflicense 41 The patch does not generate ASF License warnings.
5828
Reason Tests
Failed junit tests hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/8/artifact/out/Dockerfile
GITHUB PR #699
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux f3d6053765b9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 094d736
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-699/8/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-699/8/testReport/
Max. process+thread count 1379 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-699/8/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 39 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1109 trunk passed
+1 compile 1050 trunk passed
+1 checkstyle 37 trunk passed
+1 mvnsite 71 trunk passed
+1 shadedclient 749 branch has no errors when building and testing our client artifacts.
+1 javadoc 60 trunk passed
0 spotbugs 118 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 116 trunk passed
_ Patch Compile Tests _
+1 mvninstall 44 the patch passed
+1 compile 1027 the patch passed
+1 javac 1027 the patch passed
+1 checkstyle 39 the patch passed
+1 mvnsite 72 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 671 patch has no errors when building and testing our client artifacts.
+1 javadoc 64 the patch passed
+1 findbugs 135 the patch passed
_ Other Tests _
-1 unit 512 hadoop-common in the patch failed.
+1 asflicense 51 The patch does not generate ASF License warnings.
5910
Reason Tests
Failed junit tests hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/9/artifact/out/Dockerfile
GITHUB PR #699
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 75df786e9d9f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 69ddb36
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-699/9/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-699/9/testReport/
Max. process+thread count 1378 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-699/9/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 37 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1207 trunk passed
+1 compile 1133 trunk passed
+1 checkstyle 42 trunk passed
+1 mvnsite 79 trunk passed
+1 shadedclient 864 branch has no errors when building and testing our client artifacts.
+1 javadoc 65 trunk passed
0 spotbugs 125 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 123 trunk passed
_ Patch Compile Tests _
+1 mvninstall 48 the patch passed
+1 compile 1080 the patch passed
+1 javac 1080 the patch passed
+1 checkstyle 45 the patch passed
+1 mvnsite 73 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 729 patch has no errors when building and testing our client artifacts.
+1 javadoc 65 the patch passed
+1 findbugs 138 the patch passed
_ Other Tests _
-1 unit 559 hadoop-common in the patch failed.
+1 asflicense 47 The patch does not generate ASF License warnings.
6403
Reason Tests
Failed junit tests hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/10/artifact/out/Dockerfile
GITHUB PR #699
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 5d3264d27ac4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 3329257
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-699/10/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-699/10/testReport/
Max. process+thread count 1326 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-699/10/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 33 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1251 trunk passed
+1 compile 1118 trunk passed
+1 checkstyle 45 trunk passed
+1 mvnsite 77 trunk passed
+1 shadedclient 862 branch has no errors when building and testing our client artifacts.
+1 javadoc 72 trunk passed
0 spotbugs 147 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 144 trunk passed
_ Patch Compile Tests _
+1 mvninstall 58 the patch passed
+1 compile 1143 the patch passed
+1 javac 1143 the patch passed
+1 checkstyle 50 the patch passed
+1 mvnsite 84 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 737 patch has no errors when building and testing our client artifacts.
+1 javadoc 72 the patch passed
+1 findbugs 143 the patch passed
_ Other Tests _
-1 unit 538 hadoop-common in the patch failed.
+1 asflicense 42 The patch does not generate ASF License warnings.
6538
Reason Tests
Failed junit tests hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-699/11/artifact/out/Dockerfile
GITHUB PR #699
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux e4f4d6cbf791 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 915cbc9
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-699/11/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-699/11/testReport/
Max. process+thread count 1494 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-699/11/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@mynameborat @prateekm
Fix potential null pointer issues in StreamOperatorTask
e312bb5 
Author: bharathkk <codin.martial@gmail.com>

Reviewers: Prateek Maheshwari <pmaheshwari@apache.org>, Shanthoosh Venkatraman <svenkatr@linkedin.com>

Closes apache#699 from bharathkk/bug-fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbarefoot @hadoop-yetus @jojochuang