-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19250. Fix test TestServiceInterruptHandling.testRegisterAndRaise #6987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good; some minor suggestions
@steveloughran Sorry, I can not find your suggestions. |
oh dear. something went wrong with the review. will try again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
+1
decided my comments weren't worth a second iteration. merging as is |
@slfan1989 @steveloughran Hi! I want to rerun the failed ci for other pr, is it ready to merge? |
merged to trunk...do we need a similar PR for branch-3.4/3.4.x |
@steveloughran @slfan1989 Thanks for your review. This pr is just to improve the success rate of the unit test. Do you need me to submit another PR to branch-3.4/3.4.x? Maybe we can cherry-pick it. |
…ise (apache#6987) Contributed by Chenyu Zheng
…terAndRaise (apache#6987)" This reverts commit 7e91c75.
…ise (apache#6987) Contributed by Chenyu Zheng
…ise (apache#6987) Contributed by Chenyu Zheng
…ise (apache#6987) Contributed by Chenyu Zheng
Description of PR
If test on some slow server, testRegisterAndRaise may fail. The error link is https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6813/7/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
How was this patch tested?
unit test
For code changes: