Skip to content

HADOOP-19250. Fix test TestServiceInterruptHandling.testRegisterAndRaise #6987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

zhengchenyu
Copy link
Contributor

@zhengchenyu zhengchenyu commented Aug 9, 2024

Description of PR

If test on some slow server, testRegisterAndRaise may fail. The error link is https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6813/7/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

How was this patch tested?

unit test

For code changes:

  • Check the results periodically instead of after sleep

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 7m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 33m 7s trunk passed
+1 💚 compile 9m 0s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 compile 8m 16s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 checkstyle 0m 43s trunk passed
+1 💚 mvnsite 1m 0s trunk passed
+1 💚 javadoc 0m 49s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 0m 35s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 1m 34s trunk passed
+1 💚 shadedclient 21m 59s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 30s the patch passed
+1 💚 compile 8m 34s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javac 8m 34s the patch passed
+1 💚 compile 8m 11s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 8m 11s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 42s the patch passed
+1 💚 mvnsite 0m 58s the patch passed
+1 💚 javadoc 0m 44s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 0m 36s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 1m 34s the patch passed
+1 💚 shadedclient 21m 14s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 16m 25s hadoop-common in the patch passed.
+1 💚 asflicense 0m 41s The patch does not generate ASF License warnings.
145m 20s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6987/1/artifact/out/Dockerfile
GITHUB PR #6987
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 174458573ed0 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 2b53869
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6987/1/testReport/
Max. process+thread count 1311 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6987/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good; some minor suggestions

@zhengchenyu
Copy link
Contributor Author

looks good; some minor suggestions

@steveloughran Sorry, I can not find your suggestions.

@steveloughran
Copy link
Contributor

Sorry, I can not find your suggestions.

oh dear. something went wrong with the review. will try again

Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
+1

@steveloughran
Copy link
Contributor

decided my comments weren't worth a second iteration. merging as is

@zhengchenyu
Copy link
Contributor Author

@slfan1989 @steveloughran Hi! I want to rerun the failed ci for other pr, is it ready to merge?

@steveloughran steveloughran merged commit bf804cb into apache:trunk Aug 16, 2024
4 checks passed
@steveloughran
Copy link
Contributor

merged to trunk...do we need a similar PR for branch-3.4/3.4.x

@zhengchenyu
Copy link
Contributor Author

@steveloughran @slfan1989 Thanks for your review.

This pr is just to improve the success rate of the unit test. Do you need me to submit another PR to branch-3.4/3.4.x? Maybe we can cherry-pick it.

zhengchenyu added a commit to zhengchenyu/hadoop that referenced this pull request Aug 17, 2024
zhengchenyu added a commit to zhengchenyu/hadoop that referenced this pull request Aug 17, 2024
@zhengchenyu zhengchenyu deleted the HADOOP-19250 branch August 20, 2024 09:57
zhengchenyu added a commit to zhengchenyu/hadoop that referenced this pull request Aug 30, 2024
KeeProMise pushed a commit to KeeProMise/hadoop that referenced this pull request Sep 9, 2024
Hexiaoqiao pushed a commit to Hexiaoqiao/hadoop that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants