Skip to content

HDFS-17566. Got wrong sorted block order when StorageType is considered. #6919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

zhengchenyu
Copy link
Contributor

Description of PR

https://issues.apache.org/jira/browse/HDFS-17566

How was this patch tested?

unit test: org.apache.hadoop.hdfs.server.blockmanagement.testGetBlockLocationConsiderStorageType

For code changes:

  • fix comparator order

@zhengchenyu
Copy link
Contributor Author

zhengchenyu commented Jul 3, 2024

@Hexiaoqiao @slfan1989 Can you please review this PR?
Hi, I found unit test failures of org.apache.hadoop.hdfs.server.blockmanagement.testGetBlockLocationConsiderStorageType.
I think the comparator order is wrong which is introduced by HDFS-17098.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 0m 9s Docker failed to build run-specific yetus/hadoop:tp-12901}.
Subsystem Report/Notes
GITHUB PR #6919
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6919/1/console
versions git=2.34.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 0m 26s Docker failed to build run-specific yetus/hadoop:tp-2104}.
Subsystem Report/Notes
GITHUB PR #6919
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6919/2/console
versions git=2.34.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Hexiaoqiao
Copy link
Contributor

@zhengchenyu Thanks for your PR. LGTM. Try to trigger the CI manually, Let's wait what it will say.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 0m 11s Docker failed to build run-specific yetus/hadoop:tp-26}.
Subsystem Report/Notes
GITHUB PR #6919
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6919/3/console
versions git=2.34.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989
Copy link
Contributor

@zhengchenyu Thank you for your contributions and for inviting me to review the pr. I agree with @Hexiaoqiao opinion that he should be more knowledgeable in this area.

@Hexiaoqiao
Copy link
Contributor

Not sure why Domain resolve failed different times. @zhengchenyu would you mind to submit another empty commit git commit --allow-empty -m "empty" then push and try to trigger CI again.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 0m 9s Docker failed to build run-specific yetus/hadoop:tp-11672}.
Subsystem Report/Notes
GITHUB PR #6919
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6919/4/console
versions git=2.34.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 0m 10s Docker failed to build run-specific yetus/hadoop:tp-10149}.
Subsystem Report/Notes
GITHUB PR #6919
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6919/5/console
versions git=2.34.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 0m 9s Docker failed to build run-specific yetus/hadoop:tp-12002}.
Subsystem Report/Notes
GITHUB PR #6919
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6919/6/console
versions git=2.34.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@zhengchenyu
Copy link
Contributor Author

@Hexiaoqiao
It seems like build server can not connect to archive.ubuntu.com. This web page can be connected by my computer. I tried three times, but all failed.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 0m 10s Docker failed to build run-specific yetus/hadoop:tp-6016}.
Subsystem Report/Notes
GITHUB PR #6919
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6919/7/console
versions git=2.34.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 0m 9s Docker failed to build run-specific yetus/hadoop:tp-19022}.
Subsystem Report/Notes
GITHUB PR #6919
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6919/8/console
versions git=2.34.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Hexiaoqiao
Copy link
Contributor

@zhengchenyu Check other PRs, it seems CI works fine. But this one failed because domain resolved issue about *.ubuntu.com. What about submit another one PR and let's wait what it will say?

@zhengchenyu
Copy link
Contributor Author

zhengchenyu commented Jul 10, 2024

@Hexiaoqiao OK, I have submit #6934. For now, docker build pass. Let's wait #6934.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants