-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HDFS-17566. Got wrong sorted block order when StorageType is considered. #6919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Hexiaoqiao @slfan1989 Can you please review this PR? |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@zhengchenyu Thanks for your PR. LGTM. Try to trigger the CI manually, Let's wait what it will say. |
💔 -1 overall
This message was automatically generated. |
@zhengchenyu Thank you for your contributions and for inviting me to review the pr. I agree with @Hexiaoqiao opinion that he should be more knowledgeable in this area. |
Not sure why Domain resolve failed different times. @zhengchenyu would you mind to submit another empty commit |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@Hexiaoqiao |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@zhengchenyu Check other PRs, it seems CI works fine. But this one failed because domain resolved issue about *.ubuntu.com. What about submit another one PR and let's wait what it will say? |
@Hexiaoqiao OK, I have submit #6934. For now, docker build pass. Let's wait #6934. |
Description of PR
https://issues.apache.org/jira/browse/HDFS-17566
How was this patch tested?
unit test: org.apache.hadoop.hdfs.server.blockmanagement.testGetBlockLocationConsiderStorageType
For code changes: