-
Notifications
You must be signed in to change notification settings - Fork 9.1k
[HADOOP-14951] Make the KMSACLs implementation customizable, with an … #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
💔 -1 overall
This message was automatically generated. |
1533154
to
8823d72
Compare
* | ||
* @param aclName ACL name | ||
* @param opType Operation Type | ||
* @return true if AclName exists else false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
|
||
/** | ||
* Loads the ACLs from the persistent store. | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
/** | ||
* First Check if user is in ACL for the KMS operation, if yes, then return | ||
* true if user is not present in any configured blacklist for the operation. | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
* authorized to perform the specified operation on the given acl name. | ||
* @param aclName name of the key ACL | ||
* @param ugi User's UserGroupInformation | ||
* @param opType Operation Type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
|
||
/** | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace:end of line
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
8921e7b
to
9cc8eb0
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
…additional new configuration option. Adding a new FilebasedKMSACLs class for the base, file based implementation Change-Id: Ic50f25778a11a5894d958fbbfa0e0f3a1280a3a0
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Author: Hai Lu <halu@linkedin.com> Reviewers: Srinivasulu <spunuru@linkedin.com> Closes apache#664 from lhaiesp/master
…additional new configuration option.
Refactor the code to use KeyManagementACLs interface, with a default interface method.
This help external KMS services to better re-use the code, like Ranger KMS