-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19012. Use CRC tables to speed up galoisFieldMultiply in CrcUtil. #6542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
The spotbugs error above, which is an existing problem, is not related to this. |
💔 -1 overall
This message was automatically generated. |
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Description of PR
CrcUtil.galoisFieldMultiply(p, q, m)
supports multiplying two polynomials p, q modulo any modulus polynomial m over GF(2). Since the method is used for CRC calculations, the modulus polynomial m is restricted to either theGZIP_POLYNOMIAL
or theCASTAGNOLI_POLYNOMIAL
. We may use CRC tables in PureJavaCrc32/PureJavaCrc32C to speed up the computation.How was this patch tested?
Added new tests.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?