Skip to content

Conversation

@20100507
Copy link

No description provided.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 472 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1102 trunk passed
+1 compile 60 trunk passed
+1 checkstyle 54 trunk passed
+1 mvnsite 65 trunk passed
+1 shadedclient 815 branch has no errors when building and testing our client artifacts.
+1 findbugs 130 trunk passed
+1 javadoc 53 trunk passed
_ Patch Compile Tests _
+1 mvninstall 60 the patch passed
+1 compile 57 the patch passed
+1 javac 57 the patch passed
+1 checkstyle 50 the patch passed
+1 mvnsite 62 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 771 patch has no errors when building and testing our client artifacts.
+1 findbugs 131 the patch passed
+1 javadoc 46 the patch passed
_ Other Tests _
-1 unit 4674 hadoop-hdfs in the patch failed.
+1 asflicense 32 The patch does not generate ASF License warnings.
8665
Reason Tests
Failed junit tests hadoop.hdfs.web.TestWebHdfsTimeouts
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-644/1/artifact/out/Dockerfile
GITHUB PR #644
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux f4b55f57e582 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 5257f50
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-644/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-644/1/testReport/
Max. process+thread count 3454 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-644/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor

Can you create an HDFS JIRA on issues.apache.org and include it in the title of this PR? It'll glue things together and more likely to trigger a review by someone on the HDFS team. thx

@20100507 20100507 closed this Apr 3, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
Summary of API changes:
1. TimerRegistry -> KeyScheduler; _register_ -> _schedule_
2. TimerFunction -> SchedulingFunction; _registerTimer_ -> _schedulingInit_, _onTimer_ -> _executeForKey_
3. TimerCallback -> SchedulingCallback _onTimer_ -> _execute_
4. TaskContext: _registerTimer_ -> _scheduleCallback_, _deleteTimer_ -> _deleteScheduledCallback_

Only terminology changes are intended (e.g. classes, var names, logs). No functionality change is intended.
An upcoming PR will further update TaskContext and the access to the scheduling logic.

Author: Cameron Lee <calee@linkedin.com>

Reviewers: Prateek Maheshwari <pmaheshwari@apaapache.org>

Closes apache#644 from cameronlee314/rename_timer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants