-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18613. Upgrade ZooKeeper to version 3.8.3 #6296
Conversation
💔 -1 overall
This message was automatically generated. |
@BilwaST I think curator has some issue with ZK 3.8.2, they upgraded to 3.7.2 now in apache/curator#489, which is targeted to 5.6.0, not sure if that is gonna help or not... can raise it to the curator ML & see if there is any response I think curator 5.5.0 is there as well, you tried with 5.4.0, you can check if 5.5.0 works or not, maybe run any failing test locally to see if it goes through |
+can you give us the full dependency tree so we can see what we can strip (yetus annotations etc)
|
3965474
to
1d91ad1
Compare
@ayushtkn i tried running with curator 5.5.0, but still it fails. It works fine with curator 5.2.0. I just verified it by running it locally. can we just upgrade zk version? |
Should be ok, if the build comes clean |
💔 -1 overall
This message was automatically generated. |
1d91ad1
to
00db9d1
Compare
💔 -1 overall
This message was automatically generated. |
@ayushtkn I guess TestDirectoryScanner is a random failure as i can see it in other PR too and i don't think TestTimelineAuthFilterForV2 failure is related to my changes. It fails with and without my changes in local. Please review updated patch. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Rethinking: Why are we not moving to 3.8.3? |
Earlier when i had checked, the latest stable version was 3.8.2. Looks like 3.8.3 is stable too. I will update the patch |
00db9d1
to
172e83b
Compare
💔 -1 overall
This message was automatically generated. |
@ayushtkn Testcases are random failures. I ran TestBalancerWithHANameNodes locally and it passes |
LICENSE-binary
Outdated
org.apache.zookeeper:zookeeper:3.7.2 | ||
org.apache.zookeeper:zookeeper:3.8.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be 3.8.3 here as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated it
172e83b
to
4b1f99a
Compare
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ibuted by Bilwa S T. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
…on 5.4.0
Description of PR
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?