HADOOP-18613. Upgrade ZooKeeper to version 3.8.3 #6296

BilwaST · 2023-11-24T14:57:46Z

…on 5.4.0

Description of PR

How was this patch tested?

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

BilwaST · 2023-11-24T17:03:34Z

cc @brahmareddybattula @virajjasani @ayushtkn

hadoop-yetus · 2023-11-25T04:55:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 20s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+0 🆗	shelldocs	0m 1s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 3s		Maven dependency ordering for branch
+1 💚	mvninstall	19m 8s		trunk passed
+1 💚	compile	8m 19s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	7m 30s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	mvnsite	11m 54s		trunk passed
+1 💚	javadoc	4m 47s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	4m 56s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	shadedclient	28m 44s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 33s		Maven dependency ordering for patch
+1 💚	mvninstall	17m 3s		the patch passed
+1 💚	compile	8m 4s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javac	8m 4s		the patch passed
+1 💚	compile	7m 30s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	7m 30s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	7m 4s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	4m 33s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	4m 53s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	shadedclient	29m 2s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	673m 15s	/patch-unit-root.txt	root in the patch passed.
-1 ❌	asflicense	0m 52s	/results-asflicense.txt	The patch generated 6 ASF License warnings.
		836m 14s

Reason	Tests
Failed junit tests	hadoop.hdfs.tools.TestDFSAdminWithHA
	hadoop.hdfs.server.namenode.TestNamenodeRetryCache
	hadoop.hdfs.server.namenode.TestFsck
	hadoop.hdfs.tools.TestECAdmin
	hadoop.hdfs.TestQuota
	hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetCache
	hadoop.hdfs.TestDFSUpgradeFromImage
	hadoop.hdfs.server.namenode.TestFSNamesystemLock
	hadoop.hdfs.server.namenode.TestEditsDoubleBuffer
	hadoop.hdfs.tools.TestViewFileSystemOverloadSchemeWithFSCommands
	hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
	hadoop.cli.TestAclCLI
	hadoop.cli.TestHDFSCLI
	hadoop.hdfs.server.namenode.TestAuditLogAtDebug
	hadoop.hdfs.server.namenode.ha.TestObserverReadProxyProvider
	hadoop.hdfs.TestDFSShell
	hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength
	hadoop.hdfs.server.datanode.TestDataNodeMetricsLogger
	hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
	hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA
	hadoop.hdfs.TestEncryptedTransfer
	hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
	hadoop.hdfs.TestDFSRename
	hadoop.hdfs.server.datanode.TestLargeBlockReport
	hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer
	hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
	hadoop.hdfs.server.datanode.TestFsDatasetCacheRevocation
	hadoop.hdfs.tools.TestDebugAdmin
	hadoop.hdfs.server.namenode.TestAuditLoggerWithCommands
	hadoop.hdfs.server.namenode.TestNameNodeResourcePolicy
	hadoop.cli.TestAclCLIWithPosixAclInheritance
	hadoop.hdfs.server.blockmanagement.TestPendingReconstruction
	hadoop.hdfs.server.namenode.TestAuditLogger
	hadoop.hdfs.server.namenode.TestCacheDirectivesWithViewDFS
	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.hdfs.server.namenode.TestNameNodeMetricsLogger
	hadoop.hdfs.qjournal.server.TestJournaledEditsCache
	hadoop.hdfs.server.diskbalancer.TestDiskBalancer
	hadoop.hdfs.server.namenode.TestCheckpoint
	hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
	hadoop.hdfs.server.namenode.TestFSEditLogLoader
	hadoop.hdfs.server.namenode.TestAuditLogs
	hadoop.hdfs.server.namenode.TestFSNamesystemLockReport
	hadoop.hdfs.server.namenode.TestStartup
	hadoop.hdfs.TestMaintenanceState
	hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
	hadoop.hdfs.tools.TestDFSAdmin
	hadoop.hdfs.server.namenode.snapshot.TestFsShellMoveToTrashWithSnapshots
	hadoop.hdfs.server.blockmanagement.TestBlockManagerSafeMode
	hadoop.cli.TestXAttrCLI
	hadoop.hdfs.tools.TestViewFileSystemOverloadSchemeWithDFSAdmin
	hadoop.hdfs.server.namenode.TestCacheDirectives
	hadoop.util.curator.TestSecureZKCuratorManager

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6296/1/artifact/out/Dockerfile
GITHUB PR	#6296
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname	Linux bafa1fc414ac 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `3965474`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6296/1/testReport/
Max. process+thread count	4214 (vs. ulimit of 5500)
modules	C: hadoop-project . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6296/1/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ayushtkn · 2023-11-29T13:43:32Z

@BilwaST I think curator has some issue with ZK 3.8.2, they upgraded to 3.7.2 now in apache/curator#489, which is targeted to 5.6.0, not sure if that is gonna help or not...

can raise it to the curator ML & see if there is any response

I think curator 5.5.0 is there as well, you tried with 5.4.0, you can check if 5.5.0 works or not, maybe run any failing test locally to see if it goes through

steveloughran · 2023-12-04T17:55:30Z

+can you give us the full dependency tree so we can see what we can strip (yetus annotations etc)

mvn dependency:tree -Dverbose

BilwaST · 2023-12-14T14:50:17Z

@BilwaST I think curator has some issue with ZK 3.8.2, they upgraded to 3.7.2 now in apache/curator#489, which is targeted to 5.6.0, not sure if that is gonna help or not...

can raise it to the curator ML & see if there is any response

I think curator 5.5.0 is there as well, you tried with 5.4.0, you can check if 5.5.0 works or not, maybe run any failing test locally to see if it goes through

@ayushtkn i tried running with curator 5.5.0, but still it fails. It works fine with curator 5.2.0. I just verified it by running it locally. can we just upgrade zk version?

ayushtkn · 2023-12-15T13:32:24Z

Should be ok, if the build comes clean

hadoop-yetus · 2023-12-16T02:04:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 21s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 28s		Maven dependency ordering for branch
+1 💚	mvninstall	19m 21s		trunk passed
+1 💚	compile	8m 23s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	7m 33s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	mvnsite	11m 59s		trunk passed
+1 💚	javadoc	4m 40s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	4m 54s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	shadedclient	28m 29s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 30s		Maven dependency ordering for patch
+1 💚	mvninstall	17m 0s		the patch passed
+1 💚	compile	8m 7s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	8m 7s		the patch passed
+1 💚	compile	7m 28s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	7m 28s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	7m 0s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	4m 34s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	4m 53s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	shadedclient	29m 13s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	1960m 22s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	0m 54s		The patch does not generate ASF License warnings.
		2124m 3s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.TestFsck
	hadoop.hdfs.tools.TestViewFileSystemOverloadSchemeWithFSCommands
	hadoop.hdfs.server.namenode.TestCheckpoint
	hadoop.hdfs.server.datanode.TestLargeBlockReport
	hadoop.hdfs.server.namenode.TestEditsDoubleBuffer
	hadoop.hdfs.TestDFSUpgradeFromImage
	hadoop.cli.TestAclCLIWithPosixAclInheritance
	hadoop.hdfs.server.blockmanagement.TestBlockManagerSafeMode
	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.hdfs.TestEncryptedTransfer
	hadoop.hdfs.server.namenode.TestNameNodeMetricsLogger
	hadoop.fs.TestEnhancedByteBufferAccess
	hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
	hadoop.cli.TestAclCLI
	hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
	hadoop.hdfs.TestDistributedFileSystem
	hadoop.hdfs.server.namenode.TestFSNamesystemLock
	hadoop.hdfs.server.namenode.TestAuditLoggerWithCommands
	hadoop.cli.TestHDFSCLI
	hadoop.hdfs.server.namenode.TestCacheDirectivesWithViewDFS
	hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength
	hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
	hadoop.hdfs.TestQuota
	hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
	hadoop.hdfs.tools.TestViewFileSystemOverloadSchemeWithDFSAdmin
	hadoop.hdfs.server.namenode.ha.TestObserverReadProxyProvider
	hadoop.hdfs.TestDFSRename
	hadoop.hdfs.server.namenode.TestCacheDirectives
	hadoop.hdfs.tools.TestDebugAdmin
	hadoop.hdfs.server.namenode.TestAuditLogs
	hadoop.hdfs.server.datanode.TestDataNodeMetricsLogger
	hadoop.hdfs.server.blockmanagement.TestPendingReconstruction
	hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
	hadoop.hdfs.server.namenode.TestAuditLogger
	hadoop.hdfs.server.namenode.snapshot.TestFsShellMoveToTrashWithSnapshots
	hadoop.hdfs.TestMaintenanceState
	hadoop.hdfs.server.namenode.TestNameNodeResourcePolicy
	hadoop.hdfs.qjournal.server.TestJournaledEditsCache
	hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
	hadoop.hdfs.TestErasureCodingExerciseAPIs
	hadoop.hdfs.server.diskbalancer.TestDiskBalancer
	hadoop.hdfs.tools.TestDFSAdmin
	hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetCache
	hadoop.hdfs.TestDFSShell
	hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer
	hadoop.hdfs.server.namenode.TestFSNamesystemLockReport
	hadoop.hdfs.server.namenode.TestStartup
	hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA
	hadoop.hdfs.tools.TestECAdmin
	hadoop.cli.TestXAttrCLI
	hadoop.hdfs.server.namenode.TestFSEditLogLoader
	hadoop.hdfs.server.namenode.TestAuditLogAtDebug
	hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6296/2/artifact/out/Dockerfile
GITHUB PR	#6296
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname	Linux 6807d4e18fca 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `1d91ad1`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6296/2/testReport/
Max. process+thread count	4976 (vs. ulimit of 5500)
modules	C: hadoop-project . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6296/2/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-12-16T17:27:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 21s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 15s		Maven dependency ordering for branch
+1 💚	mvninstall	19m 38s		trunk passed
+1 💚	compile	8m 10s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	7m 40s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	mvnsite	12m 7s		trunk passed
+1 💚	javadoc	4m 41s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	4m 54s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	shadedclient	28m 16s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 30s		Maven dependency ordering for patch
+1 💚	mvninstall	16m 53s		the patch passed
+1 💚	compile	8m 3s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	8m 3s		the patch passed
+1 💚	compile	7m 37s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	7m 37s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	7m 5s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	4m 43s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	4m 51s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	shadedclient	29m 16s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	638m 11s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	0m 56s		The patch does not generate ASF License warnings.
		802m 21s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6296/3/artifact/out/Dockerfile
GITHUB PR	#6296
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname	Linux 0d5d230b424b 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `00db9d1`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6296/3/testReport/
Max. process+thread count	3965 (vs. ulimit of 5500)
modules	C: hadoop-project . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6296/3/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

BilwaST · 2023-12-16T17:48:15Z

@ayushtkn I guess TestDirectoryScanner is a random failure as i can see it in other PR too and i don't think TestTimelineAuthFilterForV2 failure is related to my changes. It fails with and without my changes in local. Please review updated patch. Thank you

ayushtkn

LGTM

ayushtkn · 2023-12-16T18:01:48Z

Rethinking: Why are we not moving to 3.8.3?

BilwaST · 2023-12-17T09:21:04Z

Rethinking: Why are we not moving to 3.8.3?

Earlier when i had checked, the latest stable version was 3.8.2. Looks like 3.8.3 is stable too. I will update the patch

hadoop-yetus · 2023-12-17T22:59:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	7m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 1s		Maven dependency ordering for branch
+1 💚	mvninstall	19m 21s		trunk passed
+1 💚	compile	8m 18s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	7m 35s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	mvnsite	12m 0s		trunk passed
+1 💚	javadoc	4m 43s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	4m 55s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	shadedclient	28m 24s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s		Maven dependency ordering for patch
+1 💚	mvninstall	17m 7s		the patch passed
+1 💚	compile	8m 1s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	8m 1s		the patch passed
+1 💚	compile	7m 32s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	7m 32s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	7m 10s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	4m 37s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	4m 57s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	shadedclient	29m 3s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	640m 26s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	0m 51s		The patch does not generate ASF License warnings.
		810m 54s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
	hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6296/4/artifact/out/Dockerfile
GITHUB PR	#6296
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname	Linux 573619f45acd 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `172e83b`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6296/4/testReport/
Max. process+thread count	3997 (vs. ulimit of 5500)
modules	C: hadoop-project . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6296/4/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

BilwaST · 2023-12-18T03:34:05Z

@ayushtkn Testcases are random failures. I ran TestBalancerWithHANameNodes locally and it passes

ayushtkn · 2023-12-18T07:29:58Z

LICENSE-binary

-org.apache.zookeeper:zookeeper:3.7.2
+org.apache.zookeeper:zookeeper:3.8.2


should be 3.8.3 here as well

requires licence file changes

hadoop-yetus · 2023-12-19T05:22:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 31s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 47s		Maven dependency ordering for branch
+1 💚	mvninstall	30m 47s		trunk passed
+1 💚	compile	16m 18s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	14m 48s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	mvnsite	19m 15s		trunk passed
+1 💚	javadoc	8m 25s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	7m 31s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	shadedclient	47m 26s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 37s		Maven dependency ordering for patch
+1 💚	mvninstall	28m 38s		the patch passed
+1 💚	compile	15m 51s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	15m 51s		the patch passed
+1 💚	compile	14m 51s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	14m 51s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	13m 37s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	8m 19s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	7m 37s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	shadedclient	49m 4s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	753m 16s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	1m 36s		The patch does not generate ASF License warnings.
		1026m 10s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.fs.http.server.TestHttpFSServerNoACLs

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6296/5/artifact/out/Dockerfile
GITHUB PR	#6296
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname	Linux 774b23ed49ae 5.15.0-86-generic #96-Ubuntu SMP Wed Sep 20 08:23:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `4b1f99a`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6296/5/testReport/
Max. process+thread count	3641 (vs. ulimit of 5500)
modules	C: hadoop-project . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6296/5/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ayushtkn

LGTM

…ibuted by Bilwa S T. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>

github-actions bot added build trunk labels Nov 24, 2023

BilwaST force-pushed the HADOOP-18613 branch from 3965474 to 1d91ad1 Compare December 14, 2023 14:39

BilwaST force-pushed the HADOOP-18613 branch from 1d91ad1 to 00db9d1 Compare December 16, 2023 04:04

ayushtkn previously approved these changes Dec 16, 2023

View reviewed changes

BilwaST force-pushed the HADOOP-18613 branch from 00db9d1 to 172e83b Compare December 17, 2023 09:27

BilwaST changed the title ~~HADOOP-18613. Upgrade ZooKeeper to version 3.8.2 and Curator to versi…~~ HADOOP-18613. Upgrade ZooKeeper to version 3.8.3 Dec 17, 2023

ayushtkn reviewed Dec 18, 2023

View reviewed changes

HADOOP-18613. Upgrade ZooKeeper to version 3.8.3

4b1f99a

BilwaST force-pushed the HADOOP-18613 branch from 172e83b to 4b1f99a Compare December 18, 2023 12:14

ayushtkn approved these changes Dec 19, 2023

View reviewed changes

ayushtkn merged commit f52c7d3 into apache:trunk Dec 19, 2023
1 of 4 checks passed

jiajunmao pushed a commit to jiajunmao/hadoop-MLEC that referenced this pull request Feb 6, 2024

HADOOP-18613. Upgrade ZooKeeper to version 3.8.3 (apache#6296). Contr…

7b036a4

…ibuted by Bilwa S T. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-18613. Upgrade ZooKeeper to version 3.8.3 #6296

HADOOP-18613. Upgrade ZooKeeper to version 3.8.3 #6296

BilwaST commented Nov 24, 2023

BilwaST commented Nov 24, 2023

hadoop-yetus commented Nov 25, 2023

ayushtkn commented Nov 29, 2023

steveloughran commented Dec 4, 2023

BilwaST commented Dec 14, 2023

ayushtkn commented Dec 15, 2023

hadoop-yetus commented Dec 16, 2023

hadoop-yetus commented Dec 16, 2023

BilwaST commented Dec 16, 2023

ayushtkn left a comment

ayushtkn commented Dec 16, 2023

BilwaST commented Dec 17, 2023

hadoop-yetus commented Dec 17, 2023

BilwaST commented Dec 18, 2023

ayushtkn Dec 18, 2023

BilwaST Dec 19, 2023

hadoop-yetus commented Dec 19, 2023

ayushtkn left a comment

		org.apache.zookeeper:zookeeper:3.7.2
		org.apache.zookeeper:zookeeper:3.8.2

HADOOP-18613. Upgrade ZooKeeper to version 3.8.3 #6296

HADOOP-18613. Upgrade ZooKeeper to version 3.8.3 #6296

Conversation

BilwaST commented Nov 24, 2023

Description of PR

How was this patch tested?

For code changes:

BilwaST commented Nov 24, 2023

hadoop-yetus commented Nov 25, 2023

ayushtkn commented Nov 29, 2023

steveloughran commented Dec 4, 2023

BilwaST commented Dec 14, 2023

ayushtkn commented Dec 15, 2023

hadoop-yetus commented Dec 16, 2023

hadoop-yetus commented Dec 16, 2023

BilwaST commented Dec 16, 2023

ayushtkn left a comment

Choose a reason for hiding this comment

ayushtkn commented Dec 16, 2023

BilwaST commented Dec 17, 2023

hadoop-yetus commented Dec 17, 2023

BilwaST commented Dec 18, 2023

ayushtkn Dec 18, 2023

Choose a reason for hiding this comment

BilwaST Dec 19, 2023

Choose a reason for hiding this comment

hadoop-yetus commented Dec 19, 2023

ayushtkn left a comment

Choose a reason for hiding this comment