-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-17251. RBF: Optimize MountTableResolver#TRASH_PATTERN #6268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
|
||
| /** Trash Current matching pattern. */ | ||
| private static final String TRASH_PATTERN = "/(Current|[0-9]+)"; | ||
| private static final String TRASH_PATTERN = "/(Current|[0-9]{12})"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a test for this?
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Description of PR
We should make the length of date string of MountTableResolver#TRASH_PATTERN have fixed length.
because the trash dirs look like below pattern:
/user/hdfs/.Trash/231113002000
the data string has a fixed length of 12.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?