-
Notifications
You must be signed in to change notification settings - Fork 9.1k
YARN-11597. Fix NPE when loading static files in SLSWebApp #6216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could you help review this @slfan1989 |
💔 -1 overall
This message was automatically generated. |
The ci failure looks unrelated with this PR. @slfan1989 |
@zuston Thank you for your contribution! Let us see if there are any suggestions from other partners. If there are no other suggestions, we will merge this PR in 2 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zuston Thank you for your contribution! merged into trunk. |
…) Contributed by Junfan Zhang. Reviewed-by: Shilun Fan <slfan1989@apache.org> Signed-off-by: Shilun Fan <slfan1989@apache.org>
Description of PR
JIRA: YARN-11597. Fix NPE when loading static files in SLSWebApp
When using the SLS, the web api of http://localhost:10001/simulate is broken, because the static file loading failed of 404 http code.
This is caused by the static handler is not initialized. NPE stacktrace is as follows.
How was this patch tested?
Checked in internal tests.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?