Skip to content

YARN-11597. Fix NPE when loading static files in SLSWebApp #6216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

zuston
Copy link
Member

@zuston zuston commented Oct 23, 2023

Description of PR

JIRA: YARN-11597. Fix NPE when loading static files in SLSWebApp

When using the SLS, the web api of http://localhost:10001/simulate is broken, because the static file loading failed of 404 http code.

This is caused by the static handler is not initialized. NPE stacktrace is as follows.

20231023-171754

How was this patch tested?

Checked in internal tests.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@zuston
Copy link
Member Author

zuston commented Oct 23, 2023

Could you help review this @slfan1989

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 33m 19s trunk passed
+1 💚 compile 0m 25s trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 24s trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚 checkstyle 0m 24s trunk passed
+1 💚 mvnsite 0m 27s trunk passed
+1 💚 javadoc 0m 29s trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 26s trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚 spotbugs 0m 44s trunk passed
+1 💚 shadedclient 20m 39s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 18s the patch passed
+1 💚 compile 0m 17s the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 17s the patch passed
+1 💚 compile 0m 16s the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚 javac 0m 16s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 12s the patch passed
+1 💚 mvnsite 0m 18s the patch passed
+1 💚 javadoc 0m 17s the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 17s the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚 spotbugs 0m 38s the patch passed
+1 💚 shadedclient 20m 18s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 12m 16s hadoop-sls in the patch passed.
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
96m 50s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6216/1/artifact/out/Dockerfile
GITHUB PR #6216
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 74d136bfd590 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / a7ae7b8
Default Java Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6216/1/testReport/
Max. process+thread count 656 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6216/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@zuston
Copy link
Member Author

zuston commented Oct 24, 2023

The ci failure looks unrelated with this PR. @slfan1989

@slfan1989
Copy link
Contributor

@zuston Thank you for your contribution! Let us see if there are any suggestions from other partners. If there are no other suggestions, we will merge this PR in 2 days.

Copy link
Member

@GuoPhilipse GuoPhilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slfan1989 slfan1989 merged commit e4eda40 into apache:trunk Oct 27, 2023
@slfan1989
Copy link
Contributor

@zuston Thank you for your contribution! merged into trunk.

jiajunmao pushed a commit to jiajunmao/hadoop-MLEC that referenced this pull request Feb 6, 2024
…) Contributed by Junfan Zhang.

Reviewed-by: Shilun Fan <slfan1989@apache.org>
Signed-off-by: Shilun Fan <slfan1989@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants