-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-18939. NPE in AWS v2 SDK RetryOnErrorCodeCondition.shouldRetry() #6193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18939. NPE in AWS v2 SDK RetryOnErrorCodeCondition.shouldRetry() #6193
Conversation
Contributed by Steve Loughran Change-Id: Iaeb3707bd9716b1bdc53cc17611d903215760e91
s3 london; failure is inevitably from region parser changes. will file
|
💔 -1 overall
This message was automatically generated. |
that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, code looks good.
But not super clear to me why we're doing this. The NPE will get fixed in the SDK. And I think RetryOnErrorCodeCondition.shouldRetry() will never be called with MultiObjectDeleteException
as that is an exception we create in S3A?
yes, but that's a future tense event. we are having problems with our deployments already |
…() (apache#6193) MultiObjectDeleteException to fill in the error details See also: aws/aws-sdk-java-v2#4600 Contributed by Steve Loughran
…() (apache#6193) MultiObjectDeleteException to fill in the error details See also: aws/aws-sdk-java-v2#4600 Contributed by Steve Loughran
…() (apache#6193) MultiObjectDeleteException to fill in the error details See also: aws/aws-sdk-java-v2#4600 Contributed by Steve Loughran
…() (apache#6193) MultiObjectDeleteException to fill in the error details See also: aws/aws-sdk-java-v2#4600 Contributed by Steve Loughran
Description of PR
Fixes MultiObjectDeleteException to completely fill in AWS SDK retrier requirements.
testing in progress
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?