Skip to content

HADOOP-18889. Third party storage followup. #6186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2023
Merged

HADOOP-18889. Third party storage followup. #6186

merged 1 commit into from
Oct 24, 2023

Conversation

steveloughran
Copy link
Contributor

@steveloughran steveloughran commented Oct 13, 2023 •
edited
Loading

Followup to HADOOP-18889 third party store support #6141;

Fix some minor review comments which came in after the merge.

How was this patch tested?

modified tests run in IDE; full testing in progress against s3 london

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@steveloughran
Copy link
Contributor Author

got a test failure: unaudited operation

[ERROR] Tests run: 42, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 164.026 s <<< FAILURE! - in org.apache.hadoop.fs.s3a.ITestS3AFileOperationCost
[ERROR] testCostOfGetFileStatusOnFile[keep-markers](org.apache.hadoop.fs.s3a.ITestS3AFileOperationCost)  Time elapsed: 3.971 s  <<< ERROR!
java.nio.file.AccessDeniedException: s3a://stevel-london/fork-0003/test/testCostOfGetFileStatusOnFile[keep-markers]: org.apache.hadoop.fs.s3a.audit.AuditFailureException: f5b8d4a0-f3a9-451d-bd0f-46e044313e61-00000114 unaudited operation executing a request outside an audit span {action_http_head_request 'fork-0003/test/testCostOfGetFileStatusOnFile[keep-markers]' size=0, mutating=false}
        at org.apache.hadoop.fs.s3a.audit.AuditIntegration.translateAuditException(AuditIntegration.java:161)
        at org.apache.hadoop.fs.s3a.audit.AuditIntegration.maybeTranslateAuditException(AuditIntegration.java:175)
        at org.apache.hadoop.fs.s3a.S3AUtils.translateException(S3AUtils.java:188)
        at org.apache.hadoop.fs.s3a.S3AUtils.translateException(S3AUtils.java:152)
        at org.apache.hadoop.fs.s3a.S3AFileSystem.s3GetFileStatus(S3AFileSystem.java:3956)
        at org.apache.hadoop.fs.s3a.S3AFileSystem.innerGetFileStatus(S3AFileSystem.java:3859)
        at org.apache.hadoop.fs.s3a.S3ATestUtils.innerGetFileStatus(S3ATestUtils.java:1476)
        at org.apache.hadoop.fs.s3a.performance.AbstractS3ACostTest.lambda$verifyInnerGetFileStatus$4(AbstractS3ACostTest.java:403)
        at org.apache.hadoop.fs.s3a.performance.OperationCostValidator.exec(OperationCostValidator.java:167)
        at org.apache.hadoop.fs.s3a.performance.AbstractS3ACostTest.verifyMetrics(AbstractS3ACostTest.java:295)
        at org.apache.hadoop.fs.s3a.performance.AbstractS3ACostTest.verify(AbstractS3ACostTest.java:383)
        at org.apache.hadoop.fs.s3a.performance.AbstractS3ACostTest.verifyInnerGetFileStatus(AbstractS3ACostTest.java:402)
        at org.apache.hadoop.fs.s3a.ITestS3AFileOperationCost.testCostOfGetFileStatusOnFile(ITestS3AFileOperationCost.java:199)

@steveloughran
Copy link
Contributor Author

test failure was against s3 london with -Dparallel-tests -DtestsThreadCount=10

but: the verifyCost call creates and initialises a span before calling innerGetFileStatus(); and the test works in an ide. so unless something is happening with setup() not binding span to the right span force for precisely one test case, there's no obvious source of this

mukund-thakur
mukund-thakur approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@mukund-thakur mukund-thakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1. sorry for late review

@steveloughran
Copy link
Contributor Author

actually, want to hold back on this as we are getting a test failure which appears related to the main patch

[ERROR] Tests run: 15, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 29.276 s <<< FAILURE! - in org.apache.hadoop.fs.s3a.s3guard.ITestS3GuardTool
[ERROR] testToolsNoBucket(org.apache.hadoop.fs.s3a.s3guard.ITestS3GuardTool)  Time elapsed: 1.844 s  <<< FAILURE!
java.lang.AssertionError: Expected a org.apache.hadoop.fs.s3a.UnknownStoreException to be thrown, but got the result: : 0
        at org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:499)
        at org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:384)
        at org.apache.hadoop.fs.s3a.s3guard.AbstractS3GuardToolTestBase.testToolsNoBucket(AbstractS3GuardToolTestBase.java:222)

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 11m 24s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 43m 22s trunk passed
+1 💚 compile 0m 41s trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 33s trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚 checkstyle 0m 33s trunk passed
+1 💚 mvnsite 0m 40s trunk passed
+1 💚 javadoc 0m 27s trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 35s trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚 spotbugs 1m 9s trunk passed
+1 💚 shadedclient 32m 5s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 29s the patch passed
+1 💚 compile 0m 33s the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 33s the patch passed
+1 💚 compile 0m 27s the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚 javac 0m 27s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 20s the patch passed
+1 💚 mvnsite 0m 30s the patch passed
+1 💚 javadoc 0m 16s the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 25s the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚 spotbugs 1m 5s the patch passed
+1 💚 shadedclient 32m 3s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 2m 46s hadoop-aws in the patch passed.
+1 💚 asflicense 0m 36s The patch does not generate ASF License warnings.
133m 49s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6186/1/artifact/out/Dockerfile
GITHUB PR #6186
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 18ab96580819 5.15.0-86-generic #96-Ubuntu SMP Wed Sep 20 08:23:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / fb7044d
Default Java Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6186/1/testReport/
Max. process+thread count 750 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6186/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 20s #6186 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.
Subsystem Report/Notes
GITHUB PR #6186
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6186/1/console
versions git=2.34.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran
HADOOP-18889. Third party storage followup.
f4351c2 
Followup to HADOOP-18889 third party store support;

Fix some minor review comments which came in after the merge.

Change-Id: I72c224af1a60c26d58a964b1f35014fb581359bf
@steveloughran steveloughran force-pushed the s3/HADOOP-18889-third-party-followup branch from fb7044d to f4351c2 Compare October 23, 2023 14:46
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 50m 38s trunk passed
+1 💚 compile 0m 42s trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 33s trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚 checkstyle 0m 32s trunk passed
+1 💚 mvnsite 0m 42s trunk passed
+1 💚 javadoc 0m 26s trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 34s trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚 spotbugs 1m 9s trunk passed
+1 💚 shadedclient 38m 16s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 29s the patch passed
+1 💚 compile 0m 35s the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 35s the patch passed
+1 💚 compile 0m 26s the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚 javac 0m 26s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 19s the patch passed
+1 💚 mvnsite 0m 34s the patch passed
+1 💚 javadoc 0m 14s the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 24s the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚 spotbugs 1m 10s the patch passed
+1 💚 shadedclient 38m 58s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 2m 52s hadoop-aws in the patch passed.
+1 💚 asflicense 0m 36s The patch does not generate ASF License warnings.
143m 57s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6186/2/artifact/out/Dockerfile
GITHUB PR #6186
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux f5a587ab9432 5.15.0-86-generic #96-Ubuntu SMP Wed Sep 20 08:23:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / f4351c2
Default Java Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6186/2/testReport/
Max. process+thread count 562 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6186/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran steveloughran merged commit 8b974bc into apache:trunk Oct 24, 2023
ahmarsuhail pushed a commit to ahmarsuhail/hadoop that referenced this pull request Nov 27, 2023
@steveloughran @ahmarsuhail
HADOOP-18889. Third party storage followup. (apache#6186)
189514f 
Followup to HADOOP-18889 third party store support;

Fix some minor review comments which came in after the merge.
@ahmarsuhail ahmarsuhail mentioned this pull request Nov 28, 2023
Closed
ahmarsuhail pushed a commit to ahmarsuhail/hadoop that referenced this pull request Dec 5, 2023
@steveloughran @ahmarsuhail
HADOOP-18889. Third party storage followup. (apache#6186)
298aadb 
Followup to HADOOP-18889 third party store support;

Fix some minor review comments which came in after the merge.
ahmarsuhail pushed a commit to ahmarsuhail/hadoop that referenced this pull request Dec 5, 2023
@steveloughran @ahmarsuhail
HADOOP-18889. Third party storage followup. (apache#6186)
e14b08b 
Followup to HADOOP-18889 third party store support;

Fix some minor review comments which came in after the merge.
jiajunmao pushed a commit to jiajunmao/hadoop-MLEC that referenced this pull request Feb 6, 2024
@steveloughran @jiajunmao
HADOOP-18889. Third party storage followup. (apache#6186)
ca79305 
Followup to HADOOP-18889 third party store support;

Fix some minor review comments which came in after the merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukund-thakur mukund-thakur mukund-thakur approved these changes

Assignees
No one assigned
Labels
AWS TOOLS trunk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steveloughran @hadoop-yetus @mukund-thakur