YARN-11578. Cache fs supports chmod in LogAggregationFileController. (#6120) #6143

tomicooler · 2023-10-02T14:10:33Z

Original PR: #6120

Description of PR

How was this patch tested?

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'YARN-11578. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

…pache#6120) Change-Id: I9e0fb4c6635fd365e259605ee85c91d53ba7528f

hadoop-yetus · 2023-10-02T15:35:48Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	12m 29s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ branch-3.2 Compile Tests _
+1 💚	mvninstall	35m 39s		branch-3.2 passed
+1 💚	compile	0m 38s		branch-3.2 passed
+1 💚	checkstyle	0m 33s		branch-3.2 passed
+1 💚	mvnsite	0m 44s		branch-3.2 passed
+1 💚	javadoc	0m 54s		branch-3.2 passed
+1 💚	spotbugs	1m 55s		branch-3.2 passed
+1 💚	shadedclient	18m 6s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
-1 ❌	mvninstall	0m 34s	/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt	hadoop-yarn-common in the patch failed.
-1 ❌	compile	0m 34s	/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt	hadoop-yarn-common in the patch failed.
-1 ❌	javac	0m 34s	/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt	hadoop-yarn-common in the patch failed.
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 26s		the patch passed
-1 ❌	mvnsite	0m 35s	/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt	hadoop-yarn-common in the patch failed.
+1 💚	javadoc	0m 43s		the patch passed
-1 ❌	spotbugs	0m 33s	/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt	hadoop-yarn-common in the patch failed.
-1 ❌	shadedclient	8m 7s		patch has errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	0m 34s	/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt	hadoop-yarn-common in the patch failed.
+1 💚	asflicense	0m 29s		The patch does not generate ASF License warnings.
		83m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6143/1/artifact/out/Dockerfile
GITHUB PR	#6143
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux c83622a2c3d4 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.2 / `a5faa68`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~18.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6143/1/testReport/
Max. process+thread count	338 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6143/1/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-10-03T10:00:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 54s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ branch-3.2 Compile Tests _
+1 💚	mvninstall	38m 9s		branch-3.2 passed
+1 💚	compile	0m 41s		branch-3.2 passed
+1 💚	checkstyle	0m 35s		branch-3.2 passed
+1 💚	mvnsite	0m 46s		branch-3.2 passed
+1 💚	javadoc	0m 59s		branch-3.2 passed
+1 💚	spotbugs	2m 3s		branch-3.2 passed
+1 💚	shadedclient	18m 4s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
-1 ❌	mvninstall	0m 34s	/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt	hadoop-yarn-common in the patch failed.
-1 ❌	compile	0m 33s	/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt	hadoop-yarn-common in the patch failed.
-1 ❌	javac	0m 33s	/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt	hadoop-yarn-common in the patch failed.
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 23s		the patch passed
-1 ❌	mvnsite	0m 35s	/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt	hadoop-yarn-common in the patch failed.
+1 💚	javadoc	0m 42s		the patch passed
-1 ❌	spotbugs	0m 33s	/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt	hadoop-yarn-common in the patch failed.
-1 ❌	shadedclient	8m 1s		patch has errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	0m 35s	/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt	hadoop-yarn-common in the patch failed.
+1 💚	asflicense	0m 28s		The patch does not generate ASF License warnings.
		74m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6143/2/artifact/out/Dockerfile
GITHUB PR	#6143
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 53e9e794604a 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.2 / `a5faa68`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~18.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6143/2/testReport/
Max. process+thread count	311 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6143/2/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[ERROR] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-6143/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/logaggregation/filecontroller/TestLogAggregationFileController.java:[67,41] error: incompatible types: Class<UnsupportedOperationException> cannot be converted to Throwable [ERROR] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-6143/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/logaggregation/filecontroller/TestLogAggregationFileController.java:[84,41] error: incompatible types: Class<UnsupportedOperationException> cannot be converted to Throwable Change-Id: I27b072935daa197ec981d09d0e4c1dfde187de08

hadoop-yetus · 2023-10-03T13:35:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ branch-3.2 Compile Tests _
+1 💚	mvninstall	35m 41s		branch-3.2 passed
+1 💚	compile	0m 40s		branch-3.2 passed
+1 💚	checkstyle	0m 32s		branch-3.2 passed
+1 💚	mvnsite	0m 43s		branch-3.2 passed
+1 💚	javadoc	0m 53s		branch-3.2 passed
+1 💚	spotbugs	1m 56s		branch-3.2 passed
+1 💚	shadedclient	18m 16s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 49s		the patch passed
+1 💚	compile	0m 34s		the patch passed
+1 💚	javac	0m 34s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 23s		the patch passed
+1 💚	mvnsite	0m 37s		the patch passed
+1 💚	javadoc	0m 43s		the patch passed
+1 💚	spotbugs	1m 54s		the patch passed
+1 💚	shadedclient	19m 18s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	4m 0s	/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt	hadoop-yarn-common in the patch passed.
+1 💚	asflicense	0m 32s		The patch does not generate ASF License warnings.
		90m 9s

Reason	Tests
Failed junit tests	hadoop.yarn.logaggregation.filecontroller.TestLogAggregationFileController

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6143/3/artifact/out/Dockerfile
GITHUB PR	#6143
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 319410d7418b 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.2 / `b9f156c`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~18.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6143/3/testReport/
Max. process+thread count	323 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6143/3/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

(unfortunately can't test this locally for some reason) Change-Id: I81c7f4fe2243c79f314913507e96782dbd45045f

hadoop-yetus · 2023-10-04T09:25:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	6m 9s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ branch-3.2 Compile Tests _
+1 💚	mvninstall	33m 49s		branch-3.2 passed
+1 💚	compile	0m 44s		branch-3.2 passed
+1 💚	checkstyle	0m 38s		branch-3.2 passed
+1 💚	mvnsite	0m 49s		branch-3.2 passed
+1 💚	javadoc	0m 57s		branch-3.2 passed
+1 💚	spotbugs	1m 56s		branch-3.2 passed
+1 💚	shadedclient	17m 11s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 48s		the patch passed
+1 💚	compile	0m 36s		the patch passed
+1 💚	javac	0m 36s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 25s		the patch passed
+1 💚	mvnsite	0m 37s		the patch passed
+1 💚	javadoc	0m 43s		the patch passed
+1 💚	spotbugs	1m 49s		the patch passed
+1 💚	shadedclient	17m 57s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	4m 11s		hadoop-yarn-common in the patch passed.
+1 💚	asflicense	0m 37s		The patch does not generate ASF License warnings.
		92m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6143/4/artifact/out/Dockerfile
GITHUB PR	#6143
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 824f753d684f 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.2 / `b548e39`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~18.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6143/4/testReport/
Max. process+thread count	426 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6143/4/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

brumi1024 · 2023-10-20T10:05:57Z

Thanks @tomicooler for the cherry-pick, and @slfan1989 for the review, merged.

YARN-11578. Cache fs supports chmod in LogAggregationFileController. (a…

a5faa68

…pache#6120) Change-Id: I9e0fb4c6635fd365e259605ee85c91d53ba7528f

tomicooler mentioned this pull request Oct 2, 2023

YARN-11578. Cache fs supports chmod in LogAggregationFileController. #6120

Merged

4 tasks

slfan1989 approved these changes Oct 3, 2023

View reviewed changes

fix unit test

b548e39

(unfortunately can't test this locally for some reason) Change-Id: I81c7f4fe2243c79f314913507e96782dbd45045f

brumi1024 merged commit 702e5e7 into apache:branch-3.2 Oct 20, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YARN-11578. Cache fs supports chmod in LogAggregationFileController. (#6120) #6143

YARN-11578. Cache fs supports chmod in LogAggregationFileController. (#6120) #6143

tomicooler commented Oct 2, 2023

hadoop-yetus commented Oct 2, 2023

hadoop-yetus commented Oct 3, 2023

hadoop-yetus commented Oct 3, 2023

hadoop-yetus commented Oct 4, 2023

brumi1024 commented Oct 20, 2023

YARN-11578. Cache fs supports chmod in LogAggregationFileController. (#6120) #6143

YARN-11578. Cache fs supports chmod in LogAggregationFileController. (#6120) #6143

Conversation

tomicooler commented Oct 2, 2023

Description of PR

How was this patch tested?

For code changes:

hadoop-yetus commented Oct 2, 2023

hadoop-yetus commented Oct 3, 2023

hadoop-yetus commented Oct 3, 2023

hadoop-yetus commented Oct 4, 2023

brumi1024 commented Oct 20, 2023