Skip to content

[MAPREDUCE-7193] Review of CombineFile Code #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

[MAPREDUCE-7193] Review of CombineFile Code #610

wants to merge 1 commit into from
+230 −265

Conversation

belugabehr
Copy link
Contributor

No description provided.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 25 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 13 Maven dependency ordering for branch
+1 mvninstall 1060 trunk passed
+1 compile 109 trunk passed
+1 checkstyle 39 trunk passed
+1 mvnsite 67 trunk passed
+1 shadedclient 719 branch has no errors when building and testing our client artifacts.
+1 findbugs 85 trunk passed
+1 javadoc 34 trunk passed
_ Patch Compile Tests _
0 mvndep 10 Maven dependency ordering for patch
+1 mvninstall 56 the patch passed
+1 compile 106 the patch passed
+1 javac 106 the patch passed
-0 checkstyle 37 hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 4 new + 56 unchanged - 20 fixed = 60 total (was 76)
+1 mvnsite 65 the patch passed
-1 whitespace 0 The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 shadedclient 674 patch has no errors when building and testing our client artifacts.
+1 findbugs 99 the patch passed
+1 javadoc 30 the patch passed
_ Other Tests _
+1 unit 300 hadoop-mapreduce-client-core in the patch passed.
-1 unit 8326 hadoop-mapreduce-client-jobclient in the patch failed.
-1 asflicense 33 The patch generated 1 ASF License warnings.
11928
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/1/artifact/out/Dockerfile
GITHUB PR #610
JIRA Issue MAPREDUCE-7193
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 637ab6457183 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 091a664
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-610/1/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
whitespace https://builds.apache.org/job/hadoop-multibranch/job/PR-610/1/artifact/out/whitespace-eol.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-610/1/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-610/1/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-610/1/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 1615 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-610/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus
hadoop-yetus reviewed Mar 15, 2019
View reviewed changes
...-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/CombineFileInputFormat.java Outdated
private long fileSize;

/** All blocks in this file. */
private OneBlockInfo[] blocks;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:end of line

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 52 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 36 Maven dependency ordering for branch
+1 mvninstall 1214 trunk passed
+1 compile 138 trunk passed
+1 checkstyle 47 trunk passed
+1 mvnsite 81 trunk passed
+1 shadedclient 823 branch has no errors when building and testing our client artifacts.
+1 findbugs 103 trunk passed
+1 javadoc 37 trunk passed
_ Patch Compile Tests _
0 mvndep 11 Maven dependency ordering for patch
+1 mvninstall 70 the patch passed
+1 compile 135 the patch passed
+1 javac 135 the patch passed
-0 checkstyle 44 hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 4 new + 56 unchanged - 20 fixed = 60 total (was 76)
+1 mvnsite 74 the patch passed
-1 whitespace 0 The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 shadedclient 794 patch has no errors when building and testing our client artifacts.
+1 findbugs 123 the patch passed
+1 javadoc 33 the patch passed
_ Other Tests _
+1 unit 312 hadoop-mapreduce-client-core in the patch passed.
-1 unit 7559 hadoop-mapreduce-client-jobclient in the patch failed.
-1 asflicense 36 The patch generated 1 ASF License warnings.
11761
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/2/artifact/out/Dockerfile
GITHUB PR #610
JIRA Issue MAPREDUCE-7193
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 003f60fc4836 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 091a664
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-610/2/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
whitespace https://builds.apache.org/job/hadoop-multibranch/job/PR-610/2/artifact/out/whitespace-eol.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-610/2/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-610/2/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-610/2/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 1174 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-610/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 24 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 29 Maven dependency ordering for branch
+1 mvninstall 972 trunk passed
+1 compile 111 trunk passed
+1 checkstyle 40 trunk passed
+1 mvnsite 67 trunk passed
+1 shadedclient 706 branch has no errors when building and testing our client artifacts.
+1 findbugs 86 trunk passed
+1 javadoc 30 trunk passed
_ Patch Compile Tests _
0 mvndep 10 Maven dependency ordering for patch
+1 mvninstall 59 the patch passed
+1 compile 113 the patch passed
+1 javac 113 the patch passed
-0 checkstyle 37 hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 3 new + 56 unchanged - 20 fixed = 59 total (was 76)
+1 mvnsite 65 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 691 patch has no errors when building and testing our client artifacts.
+1 findbugs 98 the patch passed
+1 javadoc 31 the patch passed
_ Other Tests _
+1 unit 309 hadoop-mapreduce-client-core in the patch passed.
-1 unit 8229 hadoop-mapreduce-client-jobclient in the patch failed.
-1 asflicense 42 The patch generated 1 ASF License warnings.
11790
Reason Tests
Failed junit tests hadoop.mapred.TestLazyOutput
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/3/artifact/out/Dockerfile
GITHUB PR #610
JIRA Issue MAPREDUCE-7193
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux bcb1af03ac72 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 2627dad
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-610/3/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-610/3/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-610/3/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-610/3/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 1599 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-610/3/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 38 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 13 Maven dependency ordering for branch
+1 mvninstall 1058 trunk passed
+1 compile 114 trunk passed
+1 checkstyle 33 trunk passed
+1 mvnsite 71 trunk passed
+1 shadedclient 731 branch has no errors when building and testing our client artifacts.
+1 javadoc 36 trunk passed
0 spotbugs 42 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 109 trunk passed
_ Patch Compile Tests _
0 mvndep 10 Maven dependency ordering for patch
+1 mvninstall 60 the patch passed
+1 compile 112 the patch passed
+1 javac 112 the patch passed
-0 checkstyle 32 hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 3 new + 56 unchanged - 20 fixed = 59 total (was 76)
+1 mvnsite 66 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 694 patch has no errors when building and testing our client artifacts.
+1 javadoc 29 the patch passed
+1 findbugs 123 the patch passed
_ Other Tests _
+1 unit 313 hadoop-mapreduce-client-core in the patch passed.
-1 unit 7568 hadoop-mapreduce-client-jobclient in the patch failed.
-1 asflicense 43 The patch generated 1 ASF License warnings.
11297
Reason Tests
Failed junit tests hadoop.mapred.TestTaskCommit
hadoop.mapred.TestMerge
hadoop.mapred.TestMiniMRChildTask
hadoop.mapred.TestYARNRunner
hadoop.mapred.TestMiniMRClientCluster
hadoop.mapred.TestMRTimelineEventHandling
Subsystem Report/Notes
Docker Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/4/artifact/out/Dockerfile
GITHUB PR #610
JIRA Issue MAPREDUCE-7193
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 9f95aa6a18ee 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / cd967c7
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-610/4/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-610/4/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-610/4/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-610/4/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 1575 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-610/4/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 41 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 10 Maven dependency ordering for branch
+1 mvninstall 1035 trunk passed
+1 compile 118 trunk passed
+1 checkstyle 31 trunk passed
+1 mvnsite 75 trunk passed
+1 shadedclient 744 branch has no errors when building and testing our client artifacts.
+1 javadoc 38 trunk passed
0 spotbugs 43 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 104 trunk passed
_ Patch Compile Tests _
0 mvndep 10 Maven dependency ordering for patch
+1 mvninstall 58 the patch passed
+1 compile 109 the patch passed
+1 javac 109 the patch passed
-0 checkstyle 29 hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 3 new + 56 unchanged - 20 fixed = 59 total (was 76)
+1 mvnsite 63 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 700 patch has no errors when building and testing our client artifacts.
+1 javadoc 30 the patch passed
+1 findbugs 134 the patch passed
_ Other Tests _
+1 unit 310 hadoop-mapreduce-client-core in the patch passed.
-1 unit 8148 hadoop-mapreduce-client-jobclient in the patch failed.
-1 asflicense 34 The patch generated 1 ASF License warnings.
11853
Reason Tests
Failed junit tests hadoop.mapreduce.TestMRJobClient
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/5/artifact/out/Dockerfile
GITHUB PR #610
JIRA Issue MAPREDUCE-7193
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 38445c7fe622 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / c0a0c35
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-610/5/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-610/5/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-610/5/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-610/5/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 1663 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-610/5/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 80 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 16 Maven dependency ordering for branch
+1 mvninstall 1336 trunk passed
+1 compile 145 trunk passed
+1 checkstyle 44 trunk passed
+1 mvnsite 94 trunk passed
+1 shadedclient 944 branch has no errors when building and testing our client artifacts.
+1 javadoc 41 trunk passed
0 spotbugs 47 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 121 trunk passed
_ Patch Compile Tests _
0 mvndep 11 Maven dependency ordering for patch
+1 mvninstall 72 the patch passed
+1 compile 139 the patch passed
+1 javac 139 the patch passed
-0 checkstyle 38 hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 3 new + 56 unchanged - 20 fixed = 59 total (was 76)
+1 mvnsite 81 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 854 patch has no errors when building and testing our client artifacts.
+1 javadoc 36 the patch passed
+1 findbugs 142 the patch passed
_ Other Tests _
+1 unit 331 hadoop-mapreduce-client-core in the patch passed.
-1 unit 8417 hadoop-mapreduce-client-jobclient in the patch failed.
-1 asflicense 41 The patch generated 1 ASF License warnings.
13005
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/6/artifact/out/Dockerfile
GITHUB PR #610
JIRA Issue MAPREDUCE-7193
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 439e02a873ae 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / e20b195
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-610/6/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-610/6/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-610/6/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-610/6/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 1189 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-610/6/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 34 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 11 Maven dependency ordering for branch
+1 mvninstall 1167 trunk passed
+1 compile 127 trunk passed
+1 checkstyle 40 trunk passed
+1 mvnsite 77 trunk passed
+1 shadedclient 850 branch has no errors when building and testing our client artifacts.
+1 javadoc 40 trunk passed
0 spotbugs 47 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 127 trunk passed
_ Patch Compile Tests _
0 mvndep 10 Maven dependency ordering for patch
+1 mvninstall 86 the patch passed
+1 compile 118 the patch passed
+1 javac 118 the patch passed
-0 checkstyle 37 hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 3 new + 56 unchanged - 20 fixed = 59 total (was 76)
+1 mvnsite 65 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 832 patch has no errors when building and testing our client artifacts.
+1 javadoc 34 the patch passed
+1 findbugs 122 the patch passed
_ Other Tests _
+1 unit 314 hadoop-mapreduce-client-core in the patch passed.
-1 unit 7536 hadoop-mapreduce-client-jobclient in the patch failed.
-1 asflicense 40 The patch generated 1 ASF License warnings.
11713
Reason Tests
Failed junit tests hadoop.mapred.TestMerge
hadoop.mapred.TestMiniMRClientCluster
hadoop.mapred.TestReduceFetch
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/7/artifact/out/Dockerfile
GITHUB PR #610
JIRA Issue MAPREDUCE-7193
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 0c06a6e9e650 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 70b4617
Default Java 1.8.0_222
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-610/7/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-610/7/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-610/7/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-610/7/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 1187 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-610/7/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 82 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 10 Maven dependency ordering for branch
+1 mvninstall 1115 trunk passed
+1 compile 105 trunk passed
+1 checkstyle 33 trunk passed
+1 mvnsite 61 trunk passed
+1 shadedclient 749 branch has no errors when building and testing our client artifacts.
+1 javadoc 35 trunk passed
0 spotbugs 37 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 99 trunk passed
_ Patch Compile Tests _
0 mvndep 12 Maven dependency ordering for patch
+1 mvninstall 58 the patch passed
+1 compile 98 the patch passed
+1 javac 98 the patch passed
-0 checkstyle 30 hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 3 new + 56 unchanged - 20 fixed = 59 total (was 76)
+1 mvnsite 56 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 745 patch has no errors when building and testing our client artifacts.
+1 javadoc 30 the patch passed
+1 findbugs 115 the patch passed
_ Other Tests _
+1 unit 334 hadoop-mapreduce-client-core in the patch passed.
-1 unit 7298 hadoop-mapreduce-client-jobclient in the patch failed.
-1 asflicense 42 The patch generated 2 ASF License warnings.
11153
Reason Tests
Failed junit tests hadoop.mapred.TestReduceFetch
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/8/artifact/out/Dockerfile
GITHUB PR #610
JIRA Issue MAPREDUCE-7193
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 4d31fe2ae987 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / e356e4f
Default Java 1.8.0_222
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-610/8/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-610/8/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-610/8/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-610/8/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 1604 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-610/8/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 65 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 9 Maven dependency ordering for branch
+1 mvninstall 1123 trunk passed
+1 compile 97 trunk passed
+1 checkstyle 31 trunk passed
+1 mvnsite 58 trunk passed
+1 shadedclient 699 branch has no errors when building and testing our client artifacts.
+1 javadoc 34 trunk passed
0 spotbugs 39 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 105 trunk passed
_ Patch Compile Tests _
0 mvndep 11 Maven dependency ordering for patch
+1 mvninstall 60 the patch passed
+1 compile 111 the patch passed
+1 javac 111 the patch passed
-0 checkstyle 39 hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 3 new + 56 unchanged - 20 fixed = 59 total (was 76)
+1 mvnsite 63 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 717 patch has no errors when building and testing our client artifacts.
+1 javadoc 28 the patch passed
+1 findbugs 111 the patch passed
_ Other Tests _
+1 unit 334 hadoop-mapreduce-client-core in the patch passed.
-1 unit 6917 hadoop-mapreduce-client-jobclient in the patch failed.
-1 asflicense 34 The patch generated 2 ASF License warnings.
10703
Reason Tests
Failed junit tests hadoop.mapreduce.lib.output.TestJobOutputCommitter
hadoop.mapreduce.v2.TestUberAM
hadoop.mapreduce.lib.join.TestJoinDatamerge
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/9/artifact/out/Dockerfile
GITHUB PR #610
JIRA Issue MAPREDUCE-7193
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 7cf1e633f128 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 094d736
Default Java 1.8.0_222
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-610/9/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-610/9/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-610/9/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-610/9/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 1562 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-610/9/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 41 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 10 Maven dependency ordering for branch
+1 mvninstall 1161 trunk passed
+1 compile 104 trunk passed
+1 checkstyle 38 trunk passed
+1 mvnsite 67 trunk passed
+1 shadedclient 763 branch has no errors when building and testing our client artifacts.
+1 javadoc 45 trunk passed
0 spotbugs 44 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 113 trunk passed
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 64 the patch passed
+1 compile 102 the patch passed
+1 javac 102 the patch passed
-0 checkstyle 32 hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 3 new + 56 unchanged - 20 fixed = 59 total (was 76)
+1 mvnsite 58 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 784 patch has no errors when building and testing our client artifacts.
+1 javadoc 38 the patch passed
+1 findbugs 117 the patch passed
_ Other Tests _
+1 unit 336 hadoop-mapreduce-client-core in the patch passed.
-1 unit 7092 hadoop-mapreduce-client-jobclient in the patch failed.
-1 asflicense 34 The patch generated 1 ASF License warnings.
11057
Reason Tests
Failed junit tests hadoop.mapred.TestJobSysDirWithDFS
hadoop.mapred.TestMiniMRClasspath
hadoop.mapred.TestMRTimelineEventHandling
hadoop.mapred.jobcontrol.TestLocalJobControl
hadoop.mapred.TestNetworkedJob
hadoop.mapred.TestReduceFetch
hadoop.mapred.TestJobName
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/10/artifact/out/Dockerfile
GITHUB PR #610
JIRA Issue MAPREDUCE-7193
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux bec3cb8d15a6 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 69ddb36
Default Java 1.8.0_212
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-610/10/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-610/10/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-610/10/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-610/10/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 1582 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-610/10/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 44 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 13 Maven dependency ordering for branch
+1 mvninstall 1105 trunk passed
+1 compile 110 trunk passed
+1 checkstyle 37 trunk passed
+1 mvnsite 76 trunk passed
+1 shadedclient 796 branch has no errors when building and testing our client artifacts.
+1 javadoc 43 trunk passed
0 spotbugs 44 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 108 trunk passed
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 68 the patch passed
+1 compile 110 the patch passed
+1 javac 110 the patch passed
-0 checkstyle 35 hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 3 new + 56 unchanged - 20 fixed = 59 total (was 76)
+1 mvnsite 64 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 788 patch has no errors when building and testing our client artifacts.
-1 javadoc 19 hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)
-1 findbugs 25 hadoop-mapreduce-client-core in the patch failed.
-1 findbugs 19 hadoop-mapreduce-client-jobclient in the patch failed.
_ Other Tests _
-1 unit 24 hadoop-mapreduce-client-core in the patch failed.
-1 unit 20 hadoop-mapreduce-client-jobclient in the patch failed.
+1 asflicense 32 The patch does not generate ASF License warnings.
3612
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/11/artifact/out/Dockerfile
GITHUB PR #610
JIRA Issue MAPREDUCE-7193
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 3e5be9795b52 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 3329257
Default Java 1.8.0_222
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-610/11/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-610/11/artifact/out/diff-javadoc-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-610/11/artifact/out/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-610/11/artifact/out/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-610/11/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-610/11/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-610/11/testReport/
Max. process+thread count 446 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-610/11/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@rmatharu @jagadish-v0
SAMZA-1733: Adding comments, adding emptyness check to MetricsSnapsho…
06488bf 
…tReporter message

* Added comments for MetricsConfig
* Added simple emptyness check for MetricsSnapshotReporter

Author: rmatharu@linkedin.com <rmatharu@linkedin.com>

Reviewers: Prateek M<pmaheshw@linkedin.com>

Closes apache#610 from rmatharu/bugfix-emptymessage
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 3m 20s Maven dependency ordering for branch
+1 💚 mvninstall 26m 23s trunk passed
+1 💚 compile 2m 14s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 1m 56s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 checkstyle 0m 45s trunk passed
+1 💚 mvnsite 1m 17s trunk passed
+1 💚 shadedclient 16m 12s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 50s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 0m 48s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗 spotbugs 0m 46s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 1m 56s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for patch
+1 💚 mvninstall 1m 1s the patch passed
+1 💚 compile 2m 7s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javac 2m 7s the patch passed
+1 💚 compile 1m 50s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 javac 1m 49s the patch passed
-0 ⚠️ checkstyle 0m 34s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 3 new + 55 unchanged - 20 fixed = 58 total (was 75)
+1 💚 mvnsite 1m 0s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 13m 59s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 43s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 0m 40s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 findbugs 2m 4s the patch passed
_ Other Tests _
+1 💚 unit 6m 48s hadoop-mapreduce-client-core in the patch passed.
+1 💚 unit 140m 46s hadoop-mapreduce-client-jobclient in the patch passed.
-1 ❌ asflicense 0m 47s The patch generated 1 ASF License warnings.
230m 14s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-610/1/artifact/out/Dockerfile
GITHUB PR #610
JIRA Issue MAPREDUCE-7193
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux a9508182a1ba 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / e5fe326
Default Java Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
checkstyle https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-610/1/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-610/1/testReport/
asflicense https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-610/1/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 1320 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-610/1/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadoop-yetus hadoop-yetus hadoop-yetus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@belugabehr @hadoop-yetus